Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[msbuild] Add support to the ResolveNativeReferences task to execute remotely. Fixes #19027. #19047

Merged
merged 2 commits into from
Sep 20, 2023
Merged

[msbuild] Add support to the ResolveNativeReferences task to execute remotely. Fixes #19027. #19047

merged 2 commits into from
Sep 20, 2023

Commits on Sep 19, 2023

  1. [msbuild] Add support to the ResolveNativeReferences task to execute … 

    …remotely. Fixes xamarin#19027.

It looks like ResolveNativeReferences was always intended to execute remotely
from Windows (when used in the _ExpandNativeReferences target, the task is
given a session id, and only called when IsMacEnabled=true), but the task
itself never implemented the code to execute remotely.

Weirdly enough this was never an issue, because the task never did something
that had to be done on a Mac.

That is, until recently, when the task learned to decompress zip files, by
executing /usr/bin/unzip.

Obviously this doesn't work on Windows, so fix it by adding support for the
task to execute remotely.

Fixes xamarin#19027.
    @rolfbjarne
    rolfbjarne committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    5a4e1c1 View commit details
    Browse the repository at this point in the history

  2. Just don't copy anything back to Windows.

    @rolfbjarne
    rolfbjarne committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    7f71999 View commit details
    Browse the repository at this point in the history