[msbuild] Re-aot referencing assemblies. Fixes #17708. #18509

rolfbjarne · 2023-06-28T19:41:23Z

If an assembly changes, then we must AOT compile that assembly again (which we already
did), in addition to any assembly that references the modified assembly (which we
didn't do).

So rework the AOTCompile target: remove the Inputs and Outputs (because the dependency
tracking is too complicated for MSBuild to resolve), and instead move the logic to
detect if an assembly must be AOT-compiled again into the AOTCompile task.

Note that this PR has a custom port to .NET 8: #18518.

Fixes #17708.

github-actions · 2023-06-28T19:46:15Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

ivanpovazan · 2023-06-29T11:29:52Z

Is the added task specific to NativeAOT builds or it is general (triggered for every AOT compilation configuration: MonoAOT and NativeAOT) ?

rolfbjarne · 2023-06-29T11:42:25Z

@ivanpovazan only MonoAOT. However, I'll likely rewrite this completely, it won't work with the aot dedup logic.

If an assembly changes, then we must AOT compile that assembly again (which we already did), in addition to any assembly that references the modified assembly (which we didn't do). So rework the AOTCompile target: remove the Inputs and Outputs (because the dependency tracking is too complicated for MSBuild to resolve), and instead move the logic to detect if an assembly must be AOT-compiled again into the AOTCompile task. Fixes xamarin#17708.

github-actions · 2023-06-29T13:20:05Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

If an assembly changes, then we must AOT compile that assembly again (which we already did), in addition to any assembly that references the modified assembly (which we didn't do). So rework the AOTCompile target: remove the Inputs and Outputs (because the dependency tracking is too complicated for MSBuild to resolve), and instead move the logic to detect if an assembly must be AOT-compiled again into the AOTCompile task. This is a port of the [original fix for main][1] to .NET 8, where we have to take the dedup assembly into account too: if any assembly has changed, then we must re-aot the dedup assembly as well. Fixes xamarin#17708. [1]: xamarin#18509

vs-mobiletools-engineering-service2 · 2023-07-24T14:03:43Z

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 3afcb7bc85d0b671ea91b6019b7f2a30dbee00ab [PR build]

vs-mobiletools-engineering-service2 · 2023-07-24T14:13:03Z

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-07-24T14:22:12Z

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-07-24T14:22:43Z

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-07-24T14:58:20Z

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)

~~iOS~~ (no change detected)
~~tvOS~~ (no change detected)
~~watchOS~~ (no change detected)
~~macOS~~ (no change detected)

NET (empty diffs)

~~iOS~~: (empty diff detected)
~~tvOS~~: (empty diff detected)
~~MacCatalyst~~: (empty diff detected)
~~macOS~~: (empty diff detected)

❗ API diff vs stable (Breaking changes)

Legacy Xamarin (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)

iOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
tvOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
watchOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
macOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)

.NET (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)

iOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
tvOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
MacCatalyst: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
macOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist

Legacy Xamarin (stable) vs .NET

iOS: vsdrops gist
tvOS: vsdrops gist
macOS: vsdrops gist

✅ Generator diff

Generator diff is empty

Pipeline on Agent
Hash: 3afcb7bc85d0b671ea91b6019b7f2a30dbee00ab [PR build]

vs-mobiletools-engineering-service2 · 2023-07-26T11:58:00Z

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: simulator tests

0 tests crashed, 2 tests failed, 233 tests passed.

Failures

❌ monotouch tests [attempt 2]

2 tests failed, 33 tests passed.

monotouch-test/Mac [dotnet]/Debug [dotnet]: Failed (Test run failed.
Tests run: 2775 Passed: 2670 Inconclusive: 3 Failed: 2 Ignored: 103)
monotouch-test/Mac [dotnet]/Release [dotnet]: Failed (Test run failed.
Tests run: 2772 Passed: 2666 Inconclusive: 3 Failed: 2 Ignored: 104)

Html Report (VSDrops) Download

Successes

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 3afcb7bc85d0b671ea91b6019b7f2a30dbee00ab [PR build]

rolfbjarne · 2023-08-07T15:54:20Z

Test failures are unrelated (https://github.com/xamarin/maccore/issues/2630).

If an assembly changes, then we must AOT compile that assembly again (which we already did), in addition to any assembly that references the modified assembly (which we didn't do). So rework the AOTCompile target: remove the Inputs and Outputs (because the dependency tracking is too complicated for MSBuild to resolve), and instead move the logic to detect if an assembly must be AOT-compiled again into the AOTCompile task. This is a port of the [original fix for main][1] to .NET 8, where we have to take the dedup assembly into account too: if any assembly has changed, then we must re-aot the dedup assembly as well. Fixes #17708. [1]: #18509 --------- Co-authored-by: Alex Soto <alex@alexsoto.me>

rolfbjarne · 2023-08-07T18:19:50Z

/sudo backport release/7.0.3xx

vs-mobiletools-engineering-service2 · 2023-08-07T18:20:20Z

Backport Job to branch release/7.0.3xx Created! The magic is happening here

vs-mobiletools-engineering-service2 · 2023-08-07T18:22:30Z

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=8213284 for more details.

…. (#18654) If an assembly changes, then we must AOT compile that assembly again (which we already did), in addition to any assembly that references the modified assembly (which we didn't do). So rework the AOTCompile target: remove the Inputs and Outputs (because the dependency tracking is too complicated for MSBuild to resolve), and instead move the logic to detect if an assembly must be AOT-compiled again into the AOTCompile task. Fixes #17708. Backport of #18509 --------- Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>

This comment has been minimized.

Sign in to view

rolfbjarne force-pushed the reaot-referencing-assemblies branch from 36478cb to e111254 Compare June 29, 2023 13:14

Auto-format source code

a0cb995

Fix indexing issue.

fbb3b02

rolfbjarne mentioned this pull request Jun 29, 2023

[net8.0] [msbuild] Re-aot referencing assemblies. Fixes #17708. #18518

Merged

This comment has been minimized.

Sign in to view

[tests] Don't run an arm64 binary unless we're on an arm64 machine.

cd7b195

rolfbjarne marked this pull request as ready for review June 30, 2023 10:49

rolfbjarne requested review from emaf and mauroa as code owners June 30, 2023 10:49

emaf approved these changes Jun 30, 2023

View reviewed changes

This comment has been minimized.

Sign in to view

Merge branch 'main' into reaot-referencing-assemblies

3afcb7b

This comment has been minimized.

Sign in to view

rolfbjarne merged commit b17626f into xamarin:main Aug 7, 2023
50 of 52 checks passed

rolfbjarne deleted the reaot-referencing-assemblies branch August 7, 2023 18:19

vs-mobiletools-engineering-service2 mentioned this pull request Aug 7, 2023

[release/7.0.3xx] [msbuild] Re-aot referencing assemblies. Fixes #17708. #18654

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[msbuild] Re-aot referencing assemblies. Fixes #17708. #18509

[msbuild] Re-aot referencing assemblies. Fixes #17708. #18509

rolfbjarne commented Jun 28, 2023 •

edited

Loading

github-actions bot commented Jun 28, 2023

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

ivanpovazan commented Jun 29, 2023

rolfbjarne commented Jun 29, 2023

github-actions bot commented Jun 29, 2023

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Jul 24, 2023

vs-mobiletools-engineering-service2 commented Jul 24, 2023

vs-mobiletools-engineering-service2 commented Jul 24, 2023

vs-mobiletools-engineering-service2 commented Jul 24, 2023

vs-mobiletools-engineering-service2 commented Jul 24, 2023

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Jul 26, 2023

rolfbjarne commented Aug 7, 2023

rolfbjarne commented Aug 7, 2023

vs-mobiletools-engineering-service2 commented Aug 7, 2023

vs-mobiletools-engineering-service2 commented Aug 7, 2023

[msbuild] Re-aot referencing assemblies. Fixes #17708. #18509

[msbuild] Re-aot referencing assemblies. Fixes #17708. #18509

Conversation

rolfbjarne commented Jun 28, 2023 • edited Loading

github-actions bot commented Jun 28, 2023

⚠️ Your code has been reformatted. ⚠️

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

ivanpovazan commented Jun 29, 2023

rolfbjarne commented Jun 29, 2023

github-actions bot commented Jun 29, 2023

⚠️ Your code has been reformatted. ⚠️

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Jul 24, 2023

💻 [CI Build] Windows Integration Tests passed 💻

vs-mobiletools-engineering-service2 commented Jul 24, 2023

📚 [PR Build] Artifacts 📚

Packages generated

vs-mobiletools-engineering-service2 commented Jul 24, 2023

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

vs-mobiletools-engineering-service2 commented Jul 24, 2023

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

vs-mobiletools-engineering-service2 commented Jul 24, 2023

✅ API diff for current PR / commit

❗ API diff vs stable (Breaking changes)

✅ Generator diff

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Jul 26, 2023

🔥 [CI Build] Test results 🔥

Test results

Failures

❌ monotouch tests [attempt 2]

Successes

rolfbjarne commented Aug 7, 2023

rolfbjarne commented Aug 7, 2023

vs-mobiletools-engineering-service2 commented Aug 7, 2023

vs-mobiletools-engineering-service2 commented Aug 7, 2023

rolfbjarne commented Jun 28, 2023 •

edited

Loading