Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs]Created a doc for preparing an app for TestFlight #18125

Merged
merged 4 commits into from
May 30, 2023

Conversation

dustin-wojciechowski
Copy link
Contributor

I created a short doc to help anyone uploading their app to Test Flight.

I targeted MacCatalyst apps for the Mac App Store but would work the same for iOS apps.

@dustin-wojciechowski dustin-wojciechowski added the documentation The issue or pull request is about documentation label Apr 24, 2023
Copy link
Contributor

@stephen-hawley stephen-hawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dustin - I approached this by strictly looking at the language and ensuring that it's crisp and clear. Editing in this way is a subjective process, but I think this will help the overall flow.

docs/preparing-your-app-for-testflight.md Outdated Show resolved Hide resolved
docs/preparing-your-app-for-testflight.md Outdated Show resolved Hide resolved
docs/preparing-your-app-for-testflight.md Show resolved Hide resolved
docs/preparing-your-app-for-testflight.md Show resolved Hide resolved
docs/preparing-your-app-for-testflight.md Outdated Show resolved Hide resolved
docs/preparing-your-app-for-testflight.md Outdated Show resolved Hide resolved
Copy link
Contributor

@tj-devel709 tj-devel709 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! I learned a lot on the process from the review! I made a small suggestion and I think after Steve's suggestions are reviewed, this PR LGTM!

docs/preparing-your-app-for-testflight.md Outdated Show resolved Hide resolved
Copy link
Member

@mandel-macaque mandel-macaque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No native speaker, but the process is correct.

Copy link
Member

@dalexsoto dalexsoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect❣️

docs/preparing-your-app-for-testflight.md Outdated Show resolved Hide resolved
docs/preparing-your-app-for-testflight.md Outdated Show resolved Hide resolved
docs/preparing-your-app-for-testflight.md Outdated Show resolved Hide resolved
@dustin-wojciechowski
Copy link
Contributor Author

Not sure I'll be able to address any more comments until after my leave, but if looks good feel free to merge :)

@mandel-macaque mandel-macaque merged commit 2606b23 into main May 30, 2023
@mandel-macaque mandel-macaque deleted the dev/dustinw/app-store-connect-doc branch May 30, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation The issue or pull request is about documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants