Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed remote and local build issues #17964

Merged
merged 2 commits into from
Apr 3, 2023
Merged

Fixed remote and local build issues #17964

merged 2 commits into from
Apr 3, 2023

Conversation

mauroa
Copy link
Contributor

@mauroa mauroa commented Apr 3, 2023

  • Updated Xamarin.Messaging to 1.9.99 to fix a connection problem in remote builds because of an invalid reference to System.Security.Cryptography.ProtectedData
  • Generate Hot Restart specific build session id to fix an issue in local builds that was conflicting with remote builds

mauroa and others added 2 commits April 3, 2023 14:26
@mauroa
Updated Xamarin.Messaging to 1.9.99
8b7236e
@emaf @mauroa
[msbuild] Set Hot Restart specific session id
5daa342 
In Hot Restart, we only use the session id to generate a unique temp path based on the project's current location.

By having a specific session id for Hot Restart, we disambiguate from the remote build session id that's used to know if a task needs to be executed remotely or locally.
@mauroa mauroa added the not-notes-worthy Ignore for release notes label Apr 3, 2023
@mauroa mauroa requested a review from dalexsoto April 3, 2023 18:31
@mauroa mauroa self-assigned this Apr 3, 2023
@mauroa
Copy link
Contributor Author

mauroa commented Apr 3, 2023

/sudo backport release/7.0.2xx

@mauroa
Copy link
Contributor Author

mauroa commented Apr 3, 2023

/sudo backport release/8.0.1xx-preview3

@mauroa
Copy link
Contributor Author

mauroa commented Apr 3, 2023

/sudo backport xcode14.2

@mauroa
Copy link
Contributor Author

mauroa commented Apr 3, 2023

/sudo backport release/6.0.4xx-xcode14.2

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Backport Job to branch release/7.0.2xx Created! The magic is happening here

Merged
@vs-mobiletools-engineering-service2
Copy link
Collaborator

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7571748 for more details.

@dalexsoto
Copy link
Member

/sudo backport xcode14.3

@dalexsoto
Copy link
Member

/sudo backport release/6.0.4xx-xcode14.3

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Backport Job to branch xcode14.3 Created! The magic is happening here

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Backport Job to branch release/6.0.4xx-xcode14.3 Created! The magic is happening here

@dalexsoto
Copy link
Member

/sudo backport release/7.0.2xx-xcode14.3

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Backport Job to branch release/7.0.2xx-xcode14.3 Created! The magic is happening here

Merged
@vs-mobiletools-engineering-service2
Copy link
Collaborator

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7571827 for more details.

This was referenced Apr 3, 2023
Merged
Merged
@vs-mobiletools-engineering-service2
Copy link
Collaborator

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7571828 for more details.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7571832 for more details.

@dalexsoto
Copy link
Member

/sudo backport release/8.0.1xx-preview3

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Backport Job to branch release/8.0.1xx-preview3 Created! The magic is happening here

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Backport Job to branch xcode14.2 Created! The magic is happening here

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Backport Job to branch release/8.0.1xx-preview3 Created! The magic is happening here

@dalexsoto
Copy link
Member

/sudo backport release/6.0.4xx-xcode14.2

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Backport Job to branch release/6.0.4xx-xcode14.2 Created! The magic is happening here

Merged
@vs-mobiletools-engineering-service2
Copy link
Collaborator

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7572014 for more details.

Merged
@vs-mobiletools-engineering-service2
Copy link
Collaborator

Oh no! Backport failed! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7572016 for more details.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7572015 for more details.

Merged
@vs-mobiletools-engineering-service2
Copy link
Collaborator

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7572017 for more details.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 5daa342db19a15a9246155187d2d15bcf6bbb935 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)
  • iOS (no change detected)
  • tvOS (no change detected)
  • watchOS (no change detected)
  • macOS (no change detected)
NET (empty diffs)
  • iOS: (empty diff detected)
  • tvOS: (empty diff detected)
  • MacCatalyst: (empty diff detected)
  • macOS: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)
.NET (No breaking changes)
Legacy Xamarin (stable) vs .NET

✅ Generator diff

Generator diff is empty

Pipeline on Agent
Hash: 5daa342db19a15a9246155187d2d15bcf6bbb935 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: 5daa342db19a15a9246155187d2d15bcf6bbb935 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: 5daa342db19a15a9246155187d2d15bcf6bbb935 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent xambot-1199.Ventura
Hash: 5daa342db19a15a9246155187d2d15bcf6bbb935 [PR build]

dalexsoto pushed a commit that referenced this pull request Apr 3, 2023
@vs-mobiletools-engineering-service2 @mauroa
[release/7.0.2xx] Fixed remote and local build issues (#17965)
af07490 
- Updated Xamarin.Messaging to 1.9.99 to fix a connection problem in
remote builds because of an invalid reference to
System.Security.Cryptography.ProtectedData
- Generate Hot Restart specific build session id to fix an issue in
local builds that was conflicting with remote builds


Backport of #17964

Co-authored-by: Mauro Agnoletti <mauro.agnoletti@gmail.com>
@vs-mobiletools-engineering-service2
Copy link
Collaborator

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 225 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 25 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 5daa342db19a15a9246155187d2d15bcf6bbb935 [PR build]

dalexsoto pushed a commit that referenced this pull request Apr 3, 2023
@vs-mobiletools-engineering-service2 @mauroa @emaf
[release/6.0.4xx-xcode14.3] Fixed remote and local build issues (#17968)
9395db7 
- Updated Xamarin.Messaging to 1.9.99 to fix a connection problem in
remote builds because of an invalid reference to
System.Security.Cryptography.ProtectedData
- Generate Hot Restart specific build session id to fix an issue in
local builds that was conflicting with remote builds


Backport of #17964

---------

Co-authored-by: Mauro Agnoletti <mauro.agnoletti@gmail.com>
Co-authored-by: Emanuel Fernandez <emafern@microsoft.com>
dalexsoto pushed a commit that referenced this pull request Apr 3, 2023
@vs-mobiletools-engineering-service2 @mauroa @emaf
[release/7.0.2xx-xcode14.3] Fixed remote and local build issues (#17967)
b4000f3 
- Updated Xamarin.Messaging to 1.9.99 to fix a connection problem in
remote builds because of an invalid reference to
System.Security.Cryptography.ProtectedData
- Generate Hot Restart specific build session id to fix an issue in
local builds that was conflicting with remote builds


Backport of #17964

---------

Co-authored-by: Mauro Agnoletti <mauro.agnoletti@gmail.com>
Co-authored-by: Emanuel Fernandez <emafern@microsoft.com>
@dalexsoto dalexsoto merged commit 1198608 into main Apr 3, 2023
@dalexsoto dalexsoto deleted the dev/mag/main branch April 3, 2023 23:46
dalexsoto pushed a commit that referenced this pull request Apr 4, 2023
@vs-mobiletools-engineering-service2 @mauroa @emaf
[xcode14.3] Fixed remote and local build issues (#17966)
e6d21b1 
- Updated Xamarin.Messaging to 1.9.99 to fix a connection problem in
remote builds because of an invalid reference to
System.Security.Cryptography.ProtectedData
- Generate Hot Restart specific build session id to fix an issue in
local builds that was conflicting with remote builds


Backport of #17964

---------

Co-authored-by: Mauro Agnoletti <mauro.agnoletti@gmail.com>
Co-authored-by: Emanuel Fernandez <emafern@microsoft.com>
dalexsoto pushed a commit that referenced this pull request Apr 4, 2023
@vs-mobiletools-engineering-service2 @mauroa @emaf
[release/6.0.4xx-xcode14.2] Fixed remote and local build issues (#17971)
6ba6383 
- Updated Xamarin.Messaging to 1.9.99 to fix a connection problem in
remote builds because of an invalid reference to
System.Security.Cryptography.ProtectedData
- Generate Hot Restart specific build session id to fix an issue in
local builds that was conflicting with remote builds


Backport of #17964

---------

Co-authored-by: Mauro Agnoletti <mauro.agnoletti@gmail.com>
Co-authored-by: Emanuel Fernandez <emafern@microsoft.com>
dalexsoto pushed a commit that referenced this pull request Apr 4, 2023
@vs-mobiletools-engineering-service2 @mauroa @emaf
[release/8.0.1xx-preview3] Fixed remote and local build issues (#17969)
76e0cc0 
- Updated Xamarin.Messaging to 1.9.99 to fix a connection problem in
remote builds because of an invalid reference to
System.Security.Cryptography.ProtectedData
- Generate Hot Restart specific build session id to fix an issue in
local builds that was conflicting with remote builds


Backport of #17964

---------

Co-authored-by: Mauro Agnoletti <mauro.agnoletti@gmail.com>
Co-authored-by: Emanuel Fernandez <emafern@microsoft.com>
dalexsoto pushed a commit that referenced this pull request Apr 4, 2023
@vs-mobiletools-engineering-service2 @mauroa @emaf
[xcode14.2] Fixed remote and local build issues (#17970)
d926f56 
- Updated Xamarin.Messaging to 1.9.99 to fix a connection problem in
remote builds because of an invalid reference to
System.Security.Cryptography.ProtectedData
- Generate Hot Restart specific build session id to fix an issue in
local builds that was conflicting with remote builds


Backport of #17964

---------

Co-authored-by: Mauro Agnoletti <mauro.agnoletti@gmail.com>
Co-authored-by: Emanuel Fernandez <emafern@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes

@emaf emaf emaf approved these changes

@mariaghiondea mariaghiondea mariaghiondea approved these changes

@srdjanjovcic srdjanjovcic srdjanjovcic approved these changes

@rolfbjarne rolfbjarne Awaiting requested review from rolfbjarne rolfbjarne is a code owner

Assignees

@mauroa mauroa

Labels
not-notes-worthy Ignore for release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mauroa @vs-mobiletools-engineering-service2 @dalexsoto @emaf @mariaghiondea @srdjanjovcic