Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Updated Xamarin.Messaging to 1.9.59 #17646

Merged
merged 2 commits into from
Mar 1, 2023
Merged

[main] Updated Xamarin.Messaging to 1.9.59 #17646

merged 2 commits into from
Mar 1, 2023

Conversation

mauroa
Copy link
Contributor

@mauroa mauroa commented Mar 1, 2023 •
edited
Loading

Includes latest fixes like support for retry and reconnect, new telemetry, bug fixing, etc.

Also added Merq.Core.dll to dotnet/Workloads/SignList.xml because now it comes as part of Xamarin.Messaging

@mauroa
Updated Xamarin.Messaging to 1.9.59
8710dc7 
Includes latest fixes like support for retry and reconnect, new telemetry, bug fixing, etc.
@mauroa mauroa added the not-notes-worthy Ignore for release notes label Mar 1, 2023
@mauroa mauroa requested a review from emaf as a code owner March 1, 2023 00:49
@mauroa mauroa self-assigned this Mar 1, 2023
@mauroa mauroa requested a review from rolfbjarne as a code owner March 1, 2023 00:49
@mauroa
Copy link
Contributor Author

mauroa commented Mar 1, 2023

/sudo backport xcode14.2

@mauroa
Copy link
Contributor Author

mauroa commented Mar 1, 2023

/sudo backport release/7.0.2xx

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Backport Job to branch xcode14.2 Created! The magic is happening here

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Backport Job to branch release/7.0.2xx Created! The magic is happening here

@mauroa
Copy link
Contributor Author

mauroa commented Mar 1, 2023 •
edited
Loading

@dalexsoto @rolfbjarne this is the bump that we need for 17.6 Preview 2. Backports are failing so I'm sending the PRs manually to xcode14.2 and release/7.0.2xx

@mauroa mauroa requested a review from dalexsoto March 1, 2023 00:50
@vs-mobiletools-engineering-service2
Copy link
Collaborator

Oh no! Backport failed! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7399691 for more details.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Oh no! Backport failed! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7399676 for more details.

@mauroa
Added Merq.Core to dotnet/Workloads/SignList.xml
f7ad7aa 
Merq.Core.dll comes as part of Xamarin.Messaging now, so we need to register it in the sign list
@mauroa
Copy link
Contributor Author

mauroa commented Mar 1, 2023

/sudo backport xcode14.2

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Backport Job to branch xcode14.2 Created! The magic is happening here

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Oh no! Backport failed! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7399716 for more details.

@mauroa mauroa changed the title Updated Xamarin.Messaging to 1.9.59 [main] Updated Xamarin.Messaging to 1.9.59 Mar 1, 2023
@mauroa
Copy link
Contributor Author

mauroa commented Mar 1, 2023

Backports:

#17647

#17648

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🔥 [PR Build] Build failed 🔥

Build failed for the job 'Detect API changes'

Pipeline on Agent
Hash: $(GIT_HASH) [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🔥 Unable to find the contents for the comment: D:\a\1\s\change-detection\results\gh-comment.md does not exist :fire

Pipeline on Agent
Hash: f7ad7aa42cf5bc7f21b8366f30c1453a287bc921 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: f7ad7aa42cf5bc7f21b8366f30c1453a287bc921 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1042.Monterey'
Hash: f7ad7aa42cf5bc7f21b8366f30c1453a287bc921 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests on macOS M1 - Mac Ventura (13.0) failed ❌

Failed tests are:

  • xammac_tests

Pipeline on Agent
Hash: f7ad7aa42cf5bc7f21b8366f30c1453a287bc921 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)
  • iOS (no change detected)
  • tvOS (no change detected)
  • watchOS (no change detected)
  • macOS (no change detected)
NET (empty diffs)
  • iOS: (empty diff detected)
  • tvOS: (empty diff detected)
  • MacCatalyst: (empty diff detected)
  • macOS: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)
.NET (No breaking changes)
Legacy Xamarin (stable) vs .NET

✅ Generator diff

Generator diff is empty

Pipeline on Agent
Hash: f7ad7aa42cf5bc7f21b8366f30c1453a287bc921 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: simulator tests

0 tests crashed, 1 tests failed, 224 tests passed.

Failures

❌ monotouch tests

1 tests failed, 24 tests passed.
  • monotouch-test/iOS Unified 64-bits - simulator/Debug: Failed

Html Report (VSDrops) Download

Successes

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: f7ad7aa42cf5bc7f21b8366f30c1453a287bc921 [PR build]

@rolfbjarne
Copy link
Member

Test failure is unrelated (https://github.com/xamarin/maccore/issues/2138).

@rolfbjarne rolfbjarne merged commit 2178951 into main Mar 1, 2023
@rolfbjarne rolfbjarne deleted the dev/mag/main branch March 1, 2023 07:21
@rolfbjarne rolfbjarne mentioned this pull request Mar 1, 2023
Merged
mauroa added a commit that referenced this pull request Mar 2, 2023
@mauroa
[main] Updated Xamarin.Messaging to 1.9.59 (#17646)
b8823cf 
Includes latest fixes like support for retry and reconnect, new telemetry, bug fixing, etc.

Also added Merq.Core.dll to dotnet/Workloads/SignList.xml because now it comes as part of Xamarin.Messaging
vs-mobiletools-engineering-service2 pushed a commit to vs-mobiletools-engineering-service2/xamarin-macios that referenced this pull request Mar 3, 2023
@mauroa
[main] Updated Xamarin.Messaging to 1.9.59 (xamarin#17646)
bbdaf5b 
Includes latest fixes like support for retry and reconnect, new telemetry, bug fixing, etc.

Also added Merq.Core.dll to dotnet/Workloads/SignList.xml because now it comes as part of Xamarin.Messaging
rolfbjarne pushed a commit to rolfbjarne/xamarin-macios that referenced this pull request Mar 3, 2023
@mauroa @rolfbjarne
[main] Updated Xamarin.Messaging to 1.9.59 (xamarin#17646)
c5516d9 
Includes latest fixes like support for retry and reconnect, new telemetry, bug fixing, etc.

Also added Merq.Core.dll to dotnet/Workloads/SignList.xml because now it comes as part of Xamarin.Messaging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolfbjarne rolfbjarne rolfbjarne approved these changes

@emaf emaf Awaiting requested review from emaf emaf is a code owner

@dalexsoto dalexsoto Awaiting requested review from dalexsoto

Assignees

@mauroa mauroa

Labels
not-notes-worthy Ignore for release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mauroa @vs-mobiletools-engineering-service2 @rolfbjarne