[AudioToolbox] Add support for xcode 14 beta6. #15877

mandel-macaque · 2022-09-06T16:18:11Z

No description provided.

rolfbjarne

Manual bindings need manual tests too :)

rolfbjarne · 2022-09-07T08:48:30Z

src/AudioUnit/AudioComponent.cs

+		[MacCatalyst (16,0)]
+#endif
+		public AudioComponentValidationResult Validate (NSDictionary validationParameters) {
+			var success = AudioComponentValidate (GetCheckedHandle (), validationParameters.GetNonNullHandle (nameof (validationParameters)), out var result);


The header says validationParameters can be null.

rolfbjarne · 2022-09-07T08:49:59Z

src/AudioUnit/AudioComponent.cs

+			var block_handler= new BlockLiteral ();
+			block_handler.SetupBlockUnsafe (static_action, onCompletion);
+			try {
+				AudioComponentValidateWithResults (GetCheckedHandle (), validationParameters.GetNonNullHandle (nameof (validationParameters)), ref block_handler);


Same, headers say validationParameters can be null.

rolfbjarne · 2022-09-07T08:53:18Z

src/AudioUnit/AudioComponent.cs

+			var success = AudioComponentValidate (GetCheckedHandle (), validationParameters.GetNonNullHandle (nameof (validationParameters)), out var result);
+			if (success == 0)
+				return result;
+			return AudioComponentValidationResult.Unknown;


Your managed bindings have one thing in common: they don't expose the returned OSStatus from the native functions. This return value can be valuable when trying to diagnose why calls to these methods fail, so we often provide another overload that users can use to get this value. In this particular case that could be something like:

public AudioComponentValidationResult Validate (NSDictionary validationParameters, out int resultCode) { ... }

This goes for all the new API.

tj-devel709

Other than this, LGTM

tj-devel709 · 2022-09-07T16:26:45Z

src/AudioToolbox/Enums.cs

+		On = 1,
+		[NoiOS, NoTV]
+		Auto = 2,
+	}


Hmm why add tv and ios support if none of the enums support it?

rolfbjarne · 2022-09-07T19:16:35Z

src/AudioUnit/AudioComponent.cs

+#endif
+		public NSDictionary? ConfigurationInfo {
+			get {
+				var success = AudioComponentCopyConfigurationInfo (GetCheckedHandle (), out var dictPtr);


This one is also needs an overload (or really a method, since this is a property)

stephen-hawley · 2022-09-08T19:09:54Z

tests/monotouch-test/AudioToolbox/AudioComponentTest.cs

+
+			var componentInfo = new AudioComponentInfo ();
+			componentInfo.Type = AudioTypeOutput.Generic.ToString ();
+			componentInfo.Subtype =  "XMPL";


nit: extra space before "XMPL"

stephen-hawley · 2022-09-08T19:10:05Z

tests/monotouch-test/AudioToolbox/AudioComponentTest.cs

+
+			var componentInfo = new AudioComponentInfo ();
+			componentInfo.Type = AudioTypeOutput.Generic.ToString ();
+			componentInfo.Subtype =  "XMPL";


stephen-hawley · 2022-09-08T19:10:14Z

tests/monotouch-test/AudioToolbox/AudioComponentTest.cs

+
+			var componentInfo = new AudioComponentInfo ();
+			componentInfo.Type = AudioTypeOutput.Generic.ToString ();
+			componentInfo.Subtype =  "XMPL";


vs-mobiletools-engineering-service2 · 2022-09-10T00:45:18Z

💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻

✅ All tests on macOS Mac Catalina (10.15) passed.

Pipeline on Agent
Hash: 501c2e1b47d297a57ce7102e139ae2171068242a [PR build]

vs-mobiletools-engineering-service2 · 2022-09-10T00:56:19Z

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1164.Monterey'
Hash: 501c2e1b47d297a57ce7102e139ae2171068242a [PR build]

vs-mobiletools-engineering-service2 · 2022-09-10T01:02:59Z

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
~~watchOS~~ (no change detected)
macOS: vsdrops gist (No breaking changes)

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
watchOS: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)
Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist

Legacy Xamarin (stable) vs .NET

iOS: vsdrops gist
tvOS: vsdrops gist
macOS: vsdrops gist

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 501c2e1b47d297a57ce7102e139ae2171068242a [PR build]

vs-mobiletools-engineering-service2 · 2022-09-10T01:11:00Z

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Failed tests are:

xammac_tests
monotouch-test

Pipeline on Agent
Hash: 501c2e1b47d297a57ce7102e139ae2171068242a [PR build]

vs-mobiletools-engineering-service2 · 2022-09-10T02:48:16Z

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: simulator tests

0 tests crashed, 1 tests failed, 119 tests passed.

Failures

❌ introspection tests

1 tests failed, 12 tests passed.

introspection/watchOS 32-bits - simulator/Debug (watchOS 6.0): Crashed Known issue: HE0038)

Html Report (VSDrops) Download

Successes

✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: [PR build]

[AudioToolbox] Add support for xcode 14 beta6.

0094948

mandel-macaque added the notes-mention Deserves a mention in release notes label Sep 6, 2022

mandel-macaque added this to the xcode14 milestone Sep 6, 2022

mandel-macaque requested a review from dalexsoto as a code owner September 6, 2022 16:18

This comment has been minimized.

Sign in to view

dalexsoto approved these changes Sep 6, 2022

View reviewed changes

This comment has been minimized.

Sign in to view

rolfbjarne requested changes Sep 7, 2022

View reviewed changes

Address reviews.

f35420d

This comment has been minimized.

Sign in to view

tj-devel709 reviewed Sep 7, 2022

View reviewed changes

src/AudioToolbox/Enums.cs

On = 1,

[NoiOS, NoTV]

Auto = 2,

}

Copy link

Contributor

tj-devel709 Sep 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm why add tv and ios support if none of the enums support it?

rolfbjarne requested changes Sep 7, 2022

View reviewed changes

mandel-macaque added 2 commits September 8, 2022 10:47

Merge branch 'xcode14' into audiotoolbox-xcode14

7397466

Add tests for manual code.

c9ff13f

stephen-hawley reviewed Sep 8, 2022

View reviewed changes

stephen-hawley approved these changes Sep 8, 2022

View reviewed changes

This comment has been minimized.

Sign in to view

rolfbjarne approved these changes Sep 9, 2022

View reviewed changes

Fix flacky test.

d38d6e4

This comment has been minimized.

Sign in to view

Fix issue with block.

501c2e1

mandel-macaque merged commit f2560aa into xamarin:xcode14 Sep 12, 2022

mandel-macaque deleted the audiotoolbox-xcode14 branch September 12, 2022 14:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[AudioToolbox] Add support for xcode 14 beta6. #15877

[AudioToolbox] Add support for xcode 14 beta6. #15877

mandel-macaque commented Sep 6, 2022

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rolfbjarne left a comment

rolfbjarne Sep 7, 2022

rolfbjarne Sep 7, 2022

rolfbjarne Sep 7, 2022

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

tj-devel709 left a comment

tj-devel709 Sep 7, 2022

rolfbjarne Sep 7, 2022

stephen-hawley Sep 8, 2022

stephen-hawley Sep 8, 2022

stephen-hawley Sep 8, 2022

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Sep 10, 2022

vs-mobiletools-engineering-service2 commented Sep 10, 2022

vs-mobiletools-engineering-service2 commented Sep 10, 2022

vs-mobiletools-engineering-service2 commented Sep 10, 2022

vs-mobiletools-engineering-service2 commented Sep 10, 2022

[AudioToolbox] Add support for xcode 14 beta6. #15877

[AudioToolbox] Add support for xcode 14 beta6. #15877

Conversation

mandel-macaque commented Sep 6, 2022

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rolfbjarne left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

tj-devel709 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Sep 10, 2022

💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻

vs-mobiletools-engineering-service2 commented Sep 10, 2022

📚 [PR Build] Artifacts 📚

Packages generated

vs-mobiletools-engineering-service2 commented Sep 10, 2022

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

vs-mobiletools-engineering-service2 commented Sep 10, 2022

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

vs-mobiletools-engineering-service2 commented Sep 10, 2022

🔥 [CI Build] Test results 🔥

Test results

Failures

❌ introspection tests

Successes