Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] Fix invalid cache management by 'dotnet tool restore'. #15227

Merged
merged 3 commits into from
Jun 9, 2022

Conversation

rolfbjarne
Copy link
Member

Attempt to fix a weird issue in CI where 'dotnet t4' claims that 'dotnet tool
restore' hasn't been executed, when it clearly has, by always executing
'dotnet tool restore' before 'dotnet t4'.

Attempt to fix a weird issue in CI where 'dotnet t4' claims that 'dotnet tool
restore' hasn't been executed, when it clearly has, by always executing
'dotnet tool restore' before 'dotnet t4'.
@rolfbjarne rolfbjarne added not-notes-worthy Ignore for release notes skip-all-tests Skip all the tests labels Jun 9, 2022
@vs-mobiletools-engineering-service2
Copy link
Collaborator

🔥 Tests failed catastrophically on VSTS: simulator tests iOS (no summary found). 🔥

Result file D:\a\1\s\Reports\TestSummary-simulator\TestSummary.md not found.

Pipeline on Agent
Merge f015917 into c68372d

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@rolfbjarne
Copy link
Member Author

It didn't work 🤦

Tool 'dotnet-t4' (version '2.2.1') was restored. Available commands: t4

Restore was successful.
Run "dotnet tool restore" to make the "t4" command available.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1044.Monterey'
Hash: 373834a000fd52c195931a31b9a79d30f123d88a

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻

All tests on macOS Mac Catalina (10.15) passed.

Pipeline on Agent
Hash: 373834a000fd52c195931a31b9a79d30f123d88a

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: 373834a000fd52c195931a31b9a79d30f123d88a

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build] Tests passed on VSTS: simulator tests iOS. ✅

Tests passed on VSTS: simulator tests iOS.

No tests selected.

Pipeline on Agent XAMBOT-1044.Monterey
Merge 373834a into 454e16a

@rolfbjarne rolfbjarne changed the title [build] Always restore dotnet tools before using t4. [build] Fix invalid cache management by 'dotnet tool restore'. Jun 9, 2022
@rolfbjarne rolfbjarne merged commit 78c7918 into xamarin:main Jun 9, 2022
@rolfbjarne rolfbjarne deleted the t4-fix branch June 9, 2022 13:39
@vs-mobiletools-engineering-service2
Copy link
Collaborator

📋 [PR Build] API Diff 📋

API diff (for current PR)

ℹ️ API Diff (from PR only) (please review changes)

API diff: vsdrops gist

Xamarin
.NET
Xamarin vs .NET
iOS vs Mac Catalyst (.NET)

API diff (vs stable)

✅ API Diff from stable

API diff: vsdrops gist

Xamarin
.NET
Xamarin vs .NET
iOS vs Mac Catalyst (.NET)

Generator diff

Generator Diff (no change)

Pipeline on Agent XAMBOT-1108.Monterey
Hash: 373834a000fd52c195931a31b9a79d30f123d88a

@rolfbjarne
Copy link
Member Author

/sudo backport release/6.0.4xx

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Backport Job to branch release/6.0.4xx Created! The magic is happening here

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Oh no! Backport failed! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=6276887 for more details.

rolfbjarne added a commit to rolfbjarne/xamarin-macios that referenced this pull request Jun 14, 2022
…l restore'.

Fix invalid cache management by 'dotnet tool restore' by deleting 'dotnet tool's cache.

This is a backport of xamarin#15227.
rolfbjarne added a commit to rolfbjarne/xamarin-macios that referenced this pull request Jun 14, 2022
…l restore'.

Fix invalid cache management by 'dotnet tool restore' by deleting 'dotnet tool's cache.

This is a backport of xamarin#15227.
vs-mobiletools-engineering-service2 pushed a commit to vs-mobiletools-engineering-service2/xamarin-macios that referenced this pull request Jun 21, 2022
…l restore'.

Fix invalid cache management by 'dotnet tool restore' by deleting 'dotnet tool's cache.

This is a backport of xamarin#15227.
rolfbjarne added a commit that referenced this pull request Jun 21, 2022
This is a backport of:

* #15226
* #15227 

These are build fixes we need to keep this branch building (which will be nice to have if we branch off release/6.0.5xx from this branch at some point).


Backport of #15264

Co-authored-by: Manuel de la Pena <mandel@microsoft.com>
Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-notes-worthy Ignore for release notes skip-all-tests Skip all the tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants