[appkit] Remove leftover code made obsolete by newrefcount. #15103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove code that we needed at some point due to memory related issues. These issues were fixed several years ago (newrefcount), so we no longer need this code (in fact it causes problems, see xamarin#15089).
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
spouliot
approved these changes
May 24, 2022
src/appkit.cs
Outdated
| @@ -15929,16 +15929,12 @@ partial interface NSView : NSDraggingDestination, NSAnimatablePropertyContainer, | |||
| void WillRemoveSubview ([NullAllowed] NSView subview); | |||
|
|
|||
| [Export ("removeFromSuperview")] | |||
| [PreSnippet ("var mySuper = Superview;", Optimizable = true)] | |||
| [PostSnippet ("if (mySuper != null) {\n\t#pragma warning disable 168\n\tvar flush = mySuper.Subviews;\n#pragma warning restore 168\n\t}", Optimizable = true)] | |||
| void RemoveFromSuperview (); | |||
|
|
|||
| [Export ("replaceSubview:with:")][PostGet ("Subviews")] | |||
There was a problem hiding this comment.
the [PostGet], like this one (there are other in the type), are also leftovers from that era and could be removed (but they are not causing the same problem).
dalexsoto
approved these changes
May 24, 2022
tj-devel709
approved these changes
May 24, 2022
chamons
approved these changes
May 24, 2022
This comment has been minimized.
This comment has been minimized.
mandel-macaque
approved these changes
May 24, 2022
💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻✅ All tests on macOS Mac Catalina (10.15) passed. Pipeline on Agent |
❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌Failed tests are:
Pipeline on Agent |
📋 [PR Build] API Diff 📋API diff (for current PR)ℹ️ API Diff (from PR only) (please review changes) .NETXamarin vs .NETAPI diff (vs stable)✅ API Diff from stable .NETXamarin vs .NETGenerator diffℹ️ Generator Diff (please review changes) Pipeline on Agent XAMBOT-1044.Monterey' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove code that we needed at some point due to memory related issues. These
issues were fixed several years ago (newrefcount), so we no longer need this
code (in fact it causes problems, see #15089).