[dotnet] Implement a workaround for .NET's lack of extensibility for 'dotnet run'. #12458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…'dotnet run'. .NET doesn't support executing other targets/tasks when doing "dotnet run". However, we need to (like we do for our current "Run" target), so implement a rather simplistic/hacky workaround by making "dotnet run" just do "dotnet build /t:Run". It doesn't support everything that "dotnet run" does (for instance it doesn't support the /no-build flag), but it should work for most use cases. Ref: dotnet/sdk#18436
rolfbjarne
added
not-notes-worthy
spouliot
approved these changes
Aug 17, 2021
dalexsoto
approved these changes
Aug 17, 2021
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diff✅ API Diff (from PR only) (no change) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results5 tests failed, 130 tests passed.Failed tests
Pipeline on Agent XAMBOT-1096.BigSur' |
|
Test failures are unrelated
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.NET doesn't support executing other targets/tasks when doing "dotnet run".
However, we need to (like we do for our current "Run" target), so implement a
rather simplistic/hacky workaround by making "dotnet run" just do "dotnet
build /t:Run".
It doesn't support everything that "dotnet run" does (for instance it doesn't
support the /no-build flag), but it should work for most use cases.
Ref: dotnet/sdk#18436
Ref: #12459