-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[QuickLookUI] Update bindings for Xcode 13.0 beta 1 #12389
Conversation
} | ||
|
||
[NoWatch, NoTV, Mac (12,0), iOS (15,0), MacCatalyst (15,0)] | ||
[BaseType (typeof(NSObject))] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add [DisableDefaultCtor]
the API seems to be used only inside a protocol and that means the instance is created by the caller (OS) and not by user code
Another hint is that there's no way to set the FileUrl
property which makes user-created instance not really usable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All your comments address things I also missed in QuickLook - I'll make a separate PR to correct those in that framework https://github.com/xamarin/xamarin-macios/pull/12337/files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
[NoWatch, NoTV, Mac (12,0), iOS (15,0), MacCatalyst (15,0)] | ||
[BaseType (typeof(NSObject))] | ||
interface QLPreviewReplyAttachment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add [DisableDefaultCtor]
there's a init*
method and no setters on the properties
src/quicklookUI.cs
Outdated
interface QLPreviewReply | ||
{ | ||
[Export ("stringEncoding")] | ||
nuint StringEncoding { get; set; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from wiki / diff
+/** String encoding for text or html based previews. Defaults to NSUTF8StringEncoding. */
+@property NSStringEncoding stringEncoding;
there's already an enum
for this, named NSStringEncoding
see src/Foundation/Enum.cs
✅ [PR Build] Tests passed on Build. ✅Tests passed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): 🎉 All 92 tests passed 🎉Pipeline on Agent XAMBOT-1096.BigSur' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address the comments from @spouliot
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results1 tests failed, 91 tests passed.Failed tests
Pipeline on Agent XAMBOT-1097.BigSur' |
test failure is unrelated https://github.com/xamarin/maccore/issues/2414 |
✅ [PR Build] Tests passed on Build. ✅Tests passed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): 🎉 All 94 tests passed 🎉Pipeline on Agent XAMBOT-1098.BigSur' |
✅ [PR Build] Tests passed on Build. ✅Tests passed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): 🎉 All 97 tests passed 🎉Pipeline on Agent XAMBOT-1094.BigSur' |
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results1 tests failed, 101 tests passed.Failed tests
Pipeline on Agent XAMBOT-1099.BigSur' |
No updates for beta 2,3,4
related: #12337, #12388