Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CoreBluetooth] Add Xcode 13 beta 3 support. #12153

Merged

Conversation

mandel-macaque
Copy link
Member

No description provided.

@mandel-macaque mandel-macaque added the note-highlight Worth calling out specifically in release notes label Jul 20, 2021
@@ -180,7 +180,7 @@ public enum CBConnectionEvent : long {
Connected = 1,
}

[Flags, iOS (13,0), TV (13,0), Watch (6,0), NoMac]
[Flags, iOS (13,0), TV (13,0), Watch (6,0), Mac (12,0)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not really available, just noise (and extra metadata for us), as the only API that use it is not available on macOS

		[iOS (13,0), TV (13,0), Watch (6,0), NoMac]
		[Static]
		[Export ("supportsFeatures:")]
		bool SupportsFeatures (CBCentralManagerFeature features);

let's just add that into the macOS-CoreBluetooth.ignore file instead

@spouliot spouliot changed the title [CoreBluetooh] Add Xcode 13 beta 3 support. [CoreBluetooth] Add Xcode 13 beta 3 support. Jul 20, 2021
@vs-mobiletools-engineering-service2
Copy link
Collaborator

🔥 Tests failed catastrophically on Build (no summary found). 🔥

Result file $(TEST_SUMMARY_PATH) not found.

Pipeline on Agent
Merge 830b68d into 09f911b

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

API Diff (from PR only) (no change)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

1 tests failed, 85 tests passed.

Failed tests

  • monotouch-test/Mac Catalyst/Debug [dotnet]: Failed (Tests run: 2629 Passed: 2494 Inconclusive: 35 Failed: 1 Ignored: 134)

Pipeline on Agent XAMBOT-1097.BigSur'
Merge 82b793e into eea8142

@mandel-macaque
Copy link
Member Author

@mandel-macaque mandel-macaque merged commit cd05031 into xamarin:main Jul 21, 2021
@mandel-macaque mandel-macaque deleted the corebluetooth-xcode13-beta3 branch July 21, 2021 17:03
@rolfbjarne
Copy link
Member

/sudo backport release/6.0.1xx-preview7

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Backport Job to branch release/6.0.1xx-preview7 Created! The magic is happening here

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=5007565 for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
note-highlight Worth calling out specifically in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants