[HomeKit] Updates for Xcode13 Beta 1-2 #12092

tj-devel709 · 2021-07-09T01:35:09Z

No description provided.

tj-devel709 · 2021-07-09T01:37:27Z

@mandel-macaque There was no MacCatalyst.todo, but most of these interfaces say they support MacCatalyst in the web docs.
I tried including the HomeKit in the MacCatalyst section of the frameworks.source file and I kept getting this error in the build:

build/dotnet/maccatalyst/generated-sources/ObjCRuntime/Libraries.g.cs(163,68): error CS0117: 'Constants' does not contain a definition for 'HomeKitLibrary'
make[1]: *** [build/dotnet/maccatalyst/64/Xamarin.MacCatalyst.dll] Error 1

Is this something I should do?

vs-mobiletools-engineering-service2 · 2021-07-09T05:23:17Z

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
macCat vsdrops gist
macCatiOS gist
tvOS vsdrops gist
watchOS vsdrops gist

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

1 tests failed, 85 tests passed.

Failed tests

Cecil-based tests/NUnit: Failed (Execution failed with exit code 4)

Pipeline on Agent XAMBOT-1104.BigSur'
Merge 3245e8b into 9d31e45

mandel-macaque

Please lets use Handler as with the other APIs:

src/homekit.cs

vs-mobiletools-engineering-service2 · 2021-07-10T00:28:17Z

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
macCat vsdrops gist
macCatiOS gist
tvOS vsdrops gist
watchOS vsdrops gist

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

2 tests failed, 84 tests passed.

Failed tests

monotouch-test/Mac Catalyst/Debug [dotnet]: Failed (Tests run: 2625 Passed: 2489 Inconclusive: 35 Failed: 1 Ignored: 135)
Cecil-based tests/NUnit: Failed (Execution failed with exit code 4)

Pipeline on Agent XAMBOT-1096.BigSur'
Merge 44d4790 into 797a2f5

rolfbjarne

@mandel-macaque There was no MacCatalyst.todo, but most of these interfaces say they support MacCatalyst in the web docs.
I tried including the HomeKit in the MacCatalyst section of the frameworks.source file and I kept getting this error in the build:
build/dotnet/maccatalyst/generated-sources/ObjCRuntime/Libraries.g.cs(163,68): error CS0117: 'Constants' does not contain a definition for 'HomeKitLibrary'
make[1]: *** [build/dotnet/maccatalyst/64/Xamarin.MacCatalyst.dll] Error 1
Is this something I should do?

You'll have to remove this line:

xamarin-macios/tools/common/Frameworks.cs

Line 632 in 9ae7d23

case "HomeKit":

but that might very well lead to other things that need to be fixed, so it's probably best to just leave HomeKit out of Mac Catalyst for now to not block this PR.

src/HomeKit/HMEnums.cs

tools/common/Frameworks.cs

vs-mobiletools-engineering-service2 · 2021-07-12T23:40:31Z

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
macCat vsdrops gist
macCatiOS gist
tvOS vsdrops gist
watchOS vsdrops gist

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

1 tests failed, 88 tests passed.

Failed tests

monotouch-test/Mac Catalyst/Debug [dotnet]: Failed (Tests run: 2625 Passed: 2489 Inconclusive: 35 Failed: 1 Ignored: 135)

Pipeline on Agent XAMBOT-1101.BigSur'
Merge f3cc71d into 26a8abe

tj-devel709 · 2021-07-13T17:06:36Z

Unrelated test failure: https://github.com/xamarin/maccore/issues/2443

rolfbjarne · 2021-07-14T11:44:39Z

/azp run

azure-pipelines · 2021-07-14T11:45:00Z

Azure Pipelines successfully started running 1 pipeline(s).

vs-mobiletools-engineering-service2 · 2021-07-14T17:18:39Z

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
macCat vsdrops gist
macCatiOS gist
tvOS vsdrops gist
watchOS vsdrops gist

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

1 tests failed, 88 tests passed.

Failed tests

framework-test/Mac Catalyst/Debug: TimedOut (Execution timed out after 1200 seconds.
No test log file was produced)

Pipeline on Agent XAMBOT-1104.BigSur'
Merge f3cc71d into a202354

spouliot · 2021-07-19T20:45:12Z

@tj-devel709 if HomeKit support is new for Catalyst 15 then all existing types needs to be annotated with [MacCatalyst (15,0)]. Otherwise they will appear available in earlier versions, but won't work

mandel-macaque

Nees to be merged with main which contains Xcode13 and changes in the framework.

tj-devel709 · 2021-07-20T15:52:04Z

@spouliot So I added what I think are the appropriate MacCatalyst attributes, but xtro is saying they are all unknown. Is there anything else I am supposed to do expect for add homekit to frameworks.sources?
https://gist.github.com/tj-devel709/0c8984d3f225a2b0999d145d52e51870

vs-mobiletools-engineering-service2 · 2021-07-20T16:58:38Z

🔥 Tests failed catastrophically on Build (no summary found). 🔥

Result file $(TEST_SUMMARY_PATH) not found.

Pipeline on Agent
Merge 2484cec into 09f911b

vs-mobiletools-engineering-service2 · 2021-07-21T05:15:07Z

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
macCat vsdrops gist
macCatiOS gist
tvOS vsdrops gist
watchOS vsdrops gist

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

1 tests failed, 88 tests passed.

Failed tests

Xtro/Mac: Failed (Test run failed.)

Pipeline on Agent XAMBOT-1107.BigSur'
Merge d554000 into eea8142

rolfbjarne · 2021-07-21T09:10:36Z

@tj-devel709 if HomeKit support is new for Catalyst 15 then all existing types needs to be annotated with [MacCatalyst (15,0)]. Otherwise they will appear available in earlier versions, but won't work

Looks like the HomeKit framework was added to Mac Catalyst in 14.0: https://developer.apple.com/documentation/homekit?language=objc

@spouliot So I added what I think are the appropriate MacCatalyst attributes, but xtro is saying they are all unknown. Is there anything else I am supposed to do expect for add homekit to frameworks.sources?
https://gist.github.com/tj-devel709/0c8984d3f225a2b0999d145d52e51870

Maybe sharpie didn't include the HomeKit headers for Mac Catalyst for some reason? Running gen-maccatalyst in tests/xtro-sharpie creates a maccatalyst-15.0.g.cs file without any HomeKit bindings.

CC @dalexsoto

spouliot · 2021-07-21T13:36:36Z

From xtro's perspective nothing is excluded for MacCatalyst.

* macosx 15.0, x86_64
sharpie query -bind ios15.0-macabi-x86_64.pch > maccatalyst-15.0.g.cs

Right now we're using the (sharpie generated) x86_64 pre-compiled headers. That makes me wonder if this could be something arch-dependent... it's something that's bound to happen at some point :(

@tj-devel709 you might want to create a small catalyst app with Xcode and see if you can use any HomeKit API.

spouliot · 2021-07-21T13:50:10Z

Switching from arm64 does not change anything (wrt HomeKit) but made me realize that macOS does not support HomeKit. It might be filtered (because of that) by sharpie or even Xcode (might need some opt-in) ?

tj-devel709 · 2021-07-21T23:12:19Z

@spouliot @rolfbjarne @dalexsoto
So I'm not sure if this is sufficient but I included Mac in an iOS Xcode project (which I think is how you enable Mac Catalyst), included HomeKit, and then called some things that are supported in Mac Catalyst (14,0) according to the web docs and Xcode does not complain about it!
https://gist.github.com/tj-devel709/07da0aff16246e04154e0a7f49acc9a4

mandel-macaque · 2021-07-22T20:07:10Z

@tj-devel709 can you please update the wiki and point to this PR for HomeKit, is confusing when I want to track the status of beta3.

tj-devel709 · 2021-07-22T22:52:00Z

@tj-devel709 can you please update the wiki and point to this PR for HomeKit, is confusing when I want to track the status of beta3.

Updated!

tj-devel709 · 2021-07-26T17:49:31Z

Created an issue regarding the xtro tests for MacCatalyst not recognizing the HomeKit selectors! https://github.com/xamarin/maccore/issues/2476

…HomeKit-Beta2

vs-mobiletools-engineering-service2 · 2021-07-26T23:39:33Z

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
macCat vsdrops gist
macCatiOS gist
tvOS vsdrops gist
watchOS vsdrops gist

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

1 tests failed, 91 tests passed.

Failed tests

monotouch-test/Mac Catalyst/Debug [dotnet]: Failed (Tests run: 2629 Passed: 2486 Inconclusive: 35 Failed: 2 Ignored: 141)

Pipeline on Agent XAMBOT-1096.BigSur'
Merge a6cf406 into c0651c9

src/frameworks.sources

mandel-macaque · 2021-07-28T22:02:26Z

Needs to be merged with main AFAIK beta4 added changes to this.

vs-mobiletools-engineering-service2 · 2021-07-30T05:21:42Z

✅ [PR Build] Tests passed on Build. ✅

Tests passed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
macCat vsdrops gist
macCatiOS gist
tvOS vsdrops gist
watchOS vsdrops gist

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

🎉 All 92 tests passed 🎉

Pipeline on Agent XAMBOT-1096.BigSur'
Merge 4933df6 into 448cc6e

rolfbjarne · 2021-07-30T09:25:55Z

tests/xtro-sharpie/common-HomeKit.ignore

+!missing-null-allowed! 'System.String HomeKit.HMCharacteristicMetadata::get_ManufacturerDescription()' is missing an [NullAllowed] on return type
+!missing-null-allowed! 'System.String HomeKit.HMService::get_AssociatedServiceType()' is missing an [NullAllowed] on return type
+!missing-null-allowed! 'System.Void HomeKit.HMCharacteristic::UpdateAuthorizationData(Foundation.NSData,System.Action`1<Foundation.NSError>)' is missing an [NullAllowed] on parameter #0
+!missing-null-allowed! 'System.Void HomeKit.HMCharacteristic::WriteValue(Foundation.NSObject,System.Action`1<Foundation.NSError>)' is missing an [NullAllowed] on parameter #0


Minor: missing end of line.

Why aren't we fixing this now?

mandel-macaque · 2021-08-03T04:10:02Z

tests/xtro-sharpie/MacCatalyst-HomeKit.ignore

+# Only supported in iOS 8
+!missing-protocol! HMAccessoryBrowserDelegate not bound
+
+# Only supported in iOS 8
+!missing-type! HMAccessoryBrowser not bound
+!missing-selector! HMAccessoryBrowser::delegate not bound
+!missing-selector! HMAccessoryBrowser::discoveredAccessories not bound
+!missing-selector! HMAccessoryBrowser::setDelegate: not bound
+!missing-selector! HMAccessoryBrowser::startSearchingForNewAccessories not bound
+!missing-selector! HMAccessoryBrowser::stopSearchingForNewAccessories not bound
+
+# Only supported in iOS 11.3
+!missing-type! HMAccessorySetupPayload not bound
+!missing-selector! HMAccessorySetupPayload::initWithURL: not bound
+!missing-selector! HMAccessorySetupPayload::initWithURL:ownershipToken: not bound
+!missing-selector! HMHome::addAndSetupAccessoriesWithPayload:completionHandler: not bound
+
+
+# Only supported in iOS 13
+!missing-type! HMAccessoryOwnershipToken not bound
+!missing-selector! HMAccessoryOwnershipToken::initWithData: not bound
+
+# Only supported in iOS 13
+!missing-type! HMAddAccessoryRequest not bound
+!missing-selector! HMAddAccessoryRequest::accessoryCategory not bound
+!missing-selector! HMAddAccessoryRequest::accessoryName not bound
+!missing-selector! HMAddAccessoryRequest::home not bound
+!missing-selector! HMAddAccessoryRequest::payloadWithOwnershipToken: not bound
+!missing-selector! HMAddAccessoryRequest::payloadWithURL:ownershipToken: not bound
+!missing-selector! HMAddAccessoryRequest::requiresOwnershipToken not bound
+!missing-selector! HMAddAccessoryRequest::requiresSetupPayloadURL not bound
+
+# Webdocs say it is supported in MacCatalyst 13, but the parameter type HMAddAccessoryRequest
+# is only supported in iOS 13
+!missing-protocol-member! HMHomeManagerDelegate::homeManager:didReceiveAddAccessoryRequest: not found
+
+# Only supported in iOS 15
+!missing-type! HMAccessorySetupManager not bound
+!missing-selector! HMAccessorySetupManager::addAndSetUpAccessoriesForTopology:completionHandler: not bound
+
+# Deprecated
+!missing-selector! HMHome::removeUser:completionHandler: not bound


All this with Xcode 13 beta 4 is not needed. I merged with main and using export AUTO_SANITIZE=1 all of them are gone.

vs-mobiletools-engineering-service2 · 2021-08-03T09:46:56Z

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
macCat vsdrops gist
macCatiOS gist
tvOS vsdrops gist
watchOS vsdrops gist

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

1 tests failed, 91 tests passed.

Failed tests

monotouch-test/Mac Catalyst/Debug [dotnet]: Failed (Tests run: 2629 Passed: 2490 Inconclusive: 35 Failed: 1 Ignored: 138)

Pipeline on Agent XAMBOT-1104.BigSur'
Merge 5eb4404 into f375881

mandel-macaque

Approving. We will clean NullAllowed later.

mandel-macaque · 2021-08-03T16:47:34Z

unrelated issues: https://github.com/xamarin/maccore/issues/2443

initial changes

909eda8

tj-devel709 added the note-highlight Worth calling out specifically in release notes label Jul 9, 2021

tj-devel709 added this to the xcode13.0 milestone Jul 9, 2021

tj-devel709 requested a review from spouliot as a code owner July 9, 2021 01:35

adding delegate

3245e8b

mandel-macaque requested changes Jul 9, 2021

View reviewed changes

src/homekit.cs Outdated Show resolved Hide resolved

src/homekit.cs Outdated Show resolved Hide resolved

using Handler

44d4790

rolfbjarne requested changes Jul 12, 2021

View reviewed changes

src/HomeKit/HMEnums.cs Outdated Show resolved Hide resolved

tj-devel709 requested a review from manish July 12, 2021 15:26

manish removed their request for review July 12, 2021 15:42

removing error availablity and trying to allow maccatalyst

f3cc71d

rolfbjarne approved these changes Jul 12, 2021

View reviewed changes

tools/common/Frameworks.cs Show resolved Hide resolved

merge main

e8f1e81

mandel-macaque requested changes Jul 19, 2021

View reviewed changes

adding MacCatalyst support

2484cec

Merge branch 'main' into Xcode13-HomeKit-Beta2

d554000

tj_devel709 added 2 commits July 26, 2021 12:50

adding ignore file for all MacCatalyst selectors

3cc71ec

Merge remote-tracking branch 'TJ/Xcode13-HomeKit-Beta2' into Xcode13-…

a6cf406

…HomeKit-Beta2

rolfbjarne requested changes Jul 27, 2021

View reviewed changes

src/frameworks.sources Show resolved Hide resolved

tj_devel709 added 3 commits July 29, 2021 13:04

Merge remote-tracking branch 'xamarin/main' into Xcode13-HomeKit-Beta2

bac5674

attempting to add homekit in maccatalyst workaround

03c4161

updated MacCatalyst ignore

4933df6

rolfbjarne approved these changes Jul 30, 2021

View reviewed changes

Merge branch 'main' into Xcode13-HomeKit-Beta2

5eb4404

mandel-macaque requested changes Aug 3, 2021

View reviewed changes

mandel-macaque approved these changes Aug 3, 2021

View reviewed changes

mandel-macaque merged commit 6ae2ca0 into xamarin:main Aug 3, 2021

[HomeKit] Updates for Xcode13 Beta 1-2 #12092

[HomeKit] Updates for Xcode13 Beta 1-2 #12092

Conversation

tj-devel709 commented Jul 9, 2021

tj-devel709 commented Jul 9, 2021

vs-mobiletools-engineering-service2 commented Jul 9, 2021

❌ [PR Build] Tests failed on Build ❌

API diff

API & Generator diff

GitHub pages

Test results

Failed tests

mandel-macaque left a comment

Choose a reason for hiding this comment

vs-mobiletools-engineering-service2 commented Jul 10, 2021

❌ [PR Build] Tests failed on Build ❌

API diff

API & Generator diff

GitHub pages

Test results

Failed tests

rolfbjarne left a comment

Choose a reason for hiding this comment

vs-mobiletools-engineering-service2 commented Jul 12, 2021

❌ [PR Build] Tests failed on Build ❌

API diff

GitHub pages

Test results

Failed tests

tj-devel709 commented Jul 13, 2021

rolfbjarne commented Jul 14, 2021

azure-pipelines bot commented Jul 14, 2021

vs-mobiletools-engineering-service2 commented Jul 14, 2021

❌ [PR Build] Tests failed on Build ❌

API diff

API & Generator diff

GitHub pages

Test results

Failed tests

spouliot commented Jul 19, 2021

mandel-macaque left a comment

Choose a reason for hiding this comment

tj-devel709 commented Jul 20, 2021 • edited Loading

vs-mobiletools-engineering-service2 commented Jul 20, 2021

🔥 Tests failed catastrophically on Build (no summary found). 🔥

vs-mobiletools-engineering-service2 commented Jul 21, 2021

❌ [PR Build] Tests failed on Build ❌

API diff

API & Generator diff

GitHub pages

Test results

Failed tests

rolfbjarne commented Jul 21, 2021

spouliot commented Jul 21, 2021

spouliot commented Jul 21, 2021

tj-devel709 commented Jul 21, 2021 • edited Loading

mandel-macaque commented Jul 22, 2021

tj-devel709 commented Jul 22, 2021

tj-devel709 commented Jul 26, 2021

vs-mobiletools-engineering-service2 commented Jul 26, 2021

❌ [PR Build] Tests failed on Build ❌

API diff

API & Generator diff

GitHub pages

Test results

Failed tests

mandel-macaque commented Jul 28, 2021

vs-mobiletools-engineering-service2 commented Jul 30, 2021

✅ [PR Build] Tests passed on Build. ✅

API diff

API & Generator diff

GitHub pages

🎉 All 92 tests passed 🎉

rolfbjarne Jul 30, 2021

Choose a reason for hiding this comment

mandel-macaque Aug 3, 2021

Choose a reason for hiding this comment

mandel-macaque Aug 3, 2021

Choose a reason for hiding this comment

vs-mobiletools-engineering-service2 commented Aug 3, 2021

tj-devel709 commented Jul 20, 2021 •

edited

Loading

tj-devel709 commented Jul 21, 2021 •

edited

Loading