Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EventKit] Updates for Xcode13 Beta1 #12022

Merged
merged 9 commits into from
Jul 1, 2021

Conversation

tj-devel709
Copy link
Contributor

I was a little confused about this Frameworks MacCatalyst's backlog.

Possibly just an output

  • !missing-enum! EKAlarmType not bound

This group below belongs to EKAlarm which the web docs say support MacCatalyst 13.0 but the selectors themselves do not say they support MacCatalyst in the webdocs

  • !missing-selector! EKAlarm::emailAddress not bound
  • !missing-selector! EKAlarm::setEmailAddress: not bound
  • !missing-selector! EKAlarm::setSoundName: not bound
  • !missing-selector! EKAlarm::setUrl: not bound
  • !missing-selector! EKAlarm::soundName not bound
  • !missing-selector! EKAlarm::type not bound
  • !missing-selector! EKAlarm::url not bound

These two are deprecated

  • !missing-selector! EKEvent::birthdayPersonUniqueID not bound
  • !missing-selector! EKEventStore::initWithAccessToEntityTypes: not bound

Similar to the EKAlarm selectors, EKEventStore says that it supports MacCatalyst but initWithSources does not say it supports MacCatalyst

  • !missing-selector! EKEventStore::initWithSources: not bound

@tj-devel709 tj-devel709 added the note-highlight Worth calling out specifically in release notes label Jun 25, 2021
@tj-devel709 tj-devel709 added this to the xcode13.0 milestone Jun 25, 2021
Copy link
Member

@mandel-macaque mandel-macaque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small fix, also a question regarding the attr.

src/eventkit.cs Outdated Show resolved Hide resolved
src/eventkit.cs Outdated Show resolved Hide resolved
src/eventkit.cs Outdated Show resolved Hide resolved
@tj-devel709
Copy link
Contributor Author

@mandel-macaque I made an attempt with the delegate, let me know if it is sufficient haha

src/eventkit.cs Show resolved Hide resolved
@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build] Tests passed on Build. ✅

Tests passed on Build.

API diff

✅ API Diff from stable

View API diff

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

🎉 All 86 tests passed 🎉

Pipeline on Agent XAMBOT-1096.BigSur'
Merge d9da0f5 into b1e8b29

src/eventkit.cs Outdated Show resolved Hide resolved
@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

1 tests failed, 85 tests passed.

Failed tests

  • monotouch-test/Mac Catalyst/Debug [dotnet]: Failed (Tests run: 2622 Passed: 2489 Inconclusive: 35 Failed: 1 Ignored: 132)

Pipeline on Agent XAMBOT-1094.BigSur'
Merge 0ba22f3 into 3240249

src/eventkit.cs Outdated Show resolved Hide resolved
Copy link
Member

@mandel-macaque mandel-macaque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving BUT the redundant attributes should be removed.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build] Tests passed on Build. ✅

Tests passed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

🎉 All 86 tests passed 🎉

Pipeline on Agent XAMBOT-1101.BigSur'
Merge 846abb5 into a64b030

Copy link
Member

@dalexsoto dalexsoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small issue

src/eventkit.cs Outdated Show resolved Hide resolved
src/eventkit.cs Outdated Show resolved Hide resolved
Co-authored-by: Alex Soto <alex@alexsoto.me>
@vs-mobiletools-engineering-service2
Copy link
Collaborator

🔥 Tests failed catastrophically on Build (no summary found). 🔥

Result file $(TEST_SUMMARY_PATH) not found.

Pipeline on Agent
Merge 6134d05 into 0bfb745

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

1 tests failed, 85 tests passed.

Failed tests

  • monotouch-test/Mac Catalyst/Debug [dotnet]: Failed (Tests run: 2622 Passed: 2489 Inconclusive: 35 Failed: 1 Ignored: 132)

Pipeline on Agent XAMBOT-1094.BigSur'
Merge 588dfb2 into 20dc67f

@tj-devel709
Copy link
Contributor Author

Unrelated test failure: https://github.com/xamarin/maccore/issues/2443

@tj-devel709 tj-devel709 merged commit 10b2f36 into xamarin:main Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
note-highlight Worth calling out specifically in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants