Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PDFKit] Updating Xcode13 Beta 1 #11987

Merged
merged 3 commits into from
Jun 22, 2021
Merged

[PDFKit] Updating Xcode13 Beta 1 #11987

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
39f006e
Initial changes xcode13 PDFKit beta 1
Jun 19, 2021
853d5b3
adding to PdfDocumentWriteOptionKeys
Jun 21, 2021
c73297b
adding availability
Jun 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/pdfkit.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,6 +425,10 @@ interface PdfDocumentWriteOptionKeys {

[Field ("PDFDocumentUserPasswordOption", "+PDFKit")]
NSString UserPasswordKey { get; }

[iOS (15,0), Mac (12,0), MacCatalyst (15,0)]
[Field ("PDFDocumentAccessPermissionsOption", "+PDFKit")]
NSString AccessPermissionsKey { get; }
}

[Mac (10,13)]
Expand All @@ -434,6 +438,7 @@ interface PdfDocumentWriteOptions {

string OwnerPassword { get; set; }
string UserPassword { get; set; }
Copy link
Member

@mandel-macaque mandel-macaque Jun 21, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is missing the availability attrs which should be the same as those of the key.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

without them the developer won't know they are not available (since the keys are not public)

and they (internal) keys also needs them otherwise introspection would not be able to do its job :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated :)

string AccessPermissions { get; set; }
}

[Mac (10,13)]
Expand Down Expand Up @@ -1179,10 +1184,6 @@ interface PdfDocument : NSCopying {
[Field ("PDFDocumentPageIndexKey")]
NSString PageIndexKey { get; }

[iOS (15,0), Mac (12,0), MacCatalyst (15,0)]
[Field ("PDFDocumentAccessPermissionsOption")]
NSString AccessPermissionsOption { get; }

// - (instancetype)init NS_DESIGNATED_INITIALIZER;
[Export ("init")]
[DesignatedInitializer]
Expand Down