Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CoreLocationUI] Add new framework for Xcode13 beta1. #11979

Merged

Conversation

mandel-macaque
Copy link
Member

No description provided.

@mandel-macaque mandel-macaque added the note-highlight Worth calling out specifically in release notes label Jun 18, 2021
Copy link
Contributor

@spouliot spouliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

watchOS is inconsistent
if the API were not added (like headers suggest) then it should not be defined for watchOS frameworks

@@ -484,6 +486,8 @@ public static Frameworks GetwatchOSFrameworks (bool is_simulator_build)

{ "Accessibility", "Accessibility", 7,0 },
{ "UniformTypeIdentifiers", "UniformTypeIdentifiers", 7,0 },

{ "CoreLocationUI", "CoreLocationUI", 8,0 },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why ? it does not look like it's available for watchOS

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove it and add the ignore

ShareMyCurrentLocation,
}

[NoTV, NoMac, NoWatch, iOS (15,0), MacCatalyst (15,0)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API_AVAILABLE(ios(15.0),watchos(8.0))
I guess it's not in the watchOS header ?

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

1 tests failed, 88 tests passed.

Failed tests

  • introspection/watchOS 32-bits - simulator/Debug (watchOS 5.0): Failed

Pipeline on Agent XAMBOT-1096.BigSur'
Merge 3e407b4 into b4dcee1

@@ -169,6 +169,8 @@ SIMLAUNCHER_FRAMEWORKS = \
-weak_framework NearbyInteraction \
\
-weak_framework AdServices \
\
-weak_framework CoreLocationUI \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this for?

@@ -418,6 +418,8 @@ public static Frameworks CreateiOSFrameworks (bool is_simulator_build)

{ "AdServices", "AdServices", 14,3 },

{ "CoreLocationUI", "CoreLocationUI", 15,0 },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When do we do this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When a new framework is added.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

2 tests failed, 87 tests passed.

Failed tests

  • monotouch-test/Mac Catalyst/Debug [dotnet]: Failed (Tests run: 2622 Passed: 2489 Inconclusive: 35 Failed: 1 Ignored: 132)
  • introspection/watchOS 32-bits - simulator/Debug (watchOS 5.0): Failed

Pipeline on Agent XAMBOT-1100.BigSur'
Merge 6769758 into 4bc32a9

@mandel-macaque
Copy link
Member Author

@mandel-macaque mandel-macaque merged commit c778e6b into xamarin:main Jun 21, 2021
@mandel-macaque mandel-macaque deleted the corelocationui-xcode13-beta1 branch June 21, 2021 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
note-highlight Worth calling out specifically in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants