-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VideoSubscriberAccount] Updates for Xcode13 Beta 1 #11977
[VideoSubscriberAccount] Updates for Xcode13 Beta 1 #11977
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there is an API that is not present in the platforms, it does not go to the ignore file, but we use a No*Attr, in all those, you should have used [NoMacCatalyst] like here: https://github.com/xamarin/xamarin-macios/blob/main/src/uikit.cs#L1519
Ah so we add the NoMacCatalyst and remove it from the ignore? |
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results1 tests failed, 85 tests passed.Failed tests
Pipeline on Agent XAMBOT-1094.BigSur' |
Part of the issue is that
is part of of So the bindings are included in Catalyst - and that means you must tell the generator not to process stuff that is not available on that platform. Now looking back at the framework headers it seems that everything is not available at Catalyst, so you can remove its inclusion. However to help "future you", the day Apple starts to include it, you better add the same |
@spouliot So after I removed VideoSubscriberAccount from the frameworks.sources and removed the ignore file, xtro still complains saying the items are not bound in MacCatalyst. So I still need the NoMacCatalyst right? |
I'm not sure why xtro pick the API as missing :(
You should add it (like my previous comment about "future you") as it might become useful later. However that won't solve the problem. Open an issue (for xtro) and add a link to it inside the |
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results3 tests failed, 83 tests passed.Failed tests
Pipeline on Agent XAMBOT-1094.BigSur' |
@spouliot @mandel-macaque |
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results1 tests failed, 85 tests passed.Failed tests
Pipeline on Agent XAMBOT-1104.BigSur' |
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results2 tests failed, 84 tests passed.Failed tests
Pipeline on Agent XAMBOT-1100.BigSur' |
✅ [PR Build] Tests passed on Build. ✅Tests passed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): 🎉 All 86 tests passed 🎉Pipeline on Agent XAMBOT-1101.BigSur' |
There were a lot of items inside the MacCatalyst todo file.
After running introspection tests, checking the web docs for all of them, and the xcode headers for most of them,
it does not look like they are valid to be marked for MacCatalyst.