Skip to content

Commit

Permalink
[QuickLookThumbnailing] Update bindings for Xcode 13.0 beta 1 (#12338)
Browse files Browse the repository at this point in the history
  • Loading branch information
rachelkang authored Aug 4, 2021
1 parent 62eec28 commit 142e717
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 10 deletions.
9 changes: 9 additions & 0 deletions src/quicklookthumbnailing.cs
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,10 @@ interface QLThumbnailRepresentation {
[NoiOS]
[Export ("NSImage", ArgumentSemantic.Strong)]
NSImage NSImage { get; }

[Mac (12, 0), iOS (15, 0), MacCatalyst (15, 0)]
[Export ("contentRect")]
CGRect ContentRect { get; }
}
}

Expand All @@ -141,6 +145,11 @@ interface QLThumbnailProvider {
[BaseType (typeof (NSObject))]
[DisableDefaultCtor]
interface QLThumbnailReply {

[Mac (12, 0), iOS (15, 0), MacCatalyst (15, 0)]
[Export ("extensionBadge")]
string ExtensionBadge { get; set; }

[Static]
[Export ("replyWithContextSize:drawingBlock:")]
QLThumbnailReply CreateReply (CGSize contextSize, Func<CGContext, bool> drawingBlock);
Expand Down
4 changes: 0 additions & 4 deletions tests/xtro-sharpie/MacCatalyst-QuickLookThumbnailing.todo
Original file line number Diff line number Diff line change
@@ -1,5 +1 @@
!missing-selector! QLThumbnailRepresentation::NSImage not bound
## appended from unclassified file
!missing-selector! QLThumbnailReply::extensionBadge not bound
!missing-selector! QLThumbnailReply::setExtensionBadge: not bound
!missing-selector! QLThumbnailRepresentation::contentRect not bound
3 changes: 0 additions & 3 deletions tests/xtro-sharpie/iOS-QuickLookThumbnailing.todo

This file was deleted.

3 changes: 0 additions & 3 deletions tests/xtro-sharpie/macOS-QuickLookThumbnailing.todo

This file was deleted.

6 comments on commit 142e717

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ [CI Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

Packages generated

View packages

Test results

3 tests failed, 222 tests passed.

Failed tests

  • monotouch-test/Mac Catalyst/Debug [dotnet]: Failed (Tests run: 2630 Passed: 2490 Inconclusive: 35 Failed: 1 Ignored: 139)
  • monotouch-test/tvOS - simulator/Debug (LinkSdk) [dotnet]: Failed
  • Documentation/All: Failed

Pipeline on Agent XAMBOT-1024.BigSur'
[QuickLookThumbnailing] Update bindings for Xcode 13.0 beta 1 (#12338)

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Tests were not ran (VSTS: device tests tvOS). ⚠️

Results were skipped for this run due to provisioning problems Azure Devops. Please contact the bot administrator.

Pipeline on Agent
[QuickLookThumbnailing] Update bindings for Xcode 13.0 beta 1 (#12338)

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Tests were not ran (VSTS: device tests iOS). ⚠️

Results were skipped for this run due to provisioning problems Azure Devops. Please contact the bot administrator.

Pipeline on Agent
[QuickLookThumbnailing] Update bindings for Xcode 13.0 beta 1 (#12338)

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Tests passed on macOS Mac Mojave (10.14) ✅

Tests passed

All tests on macOS X Mac Mojave (10.14) passed.

Pipeline on Agent
[QuickLookThumbnailing] Update bindings for Xcode 13.0 beta 1 (#12338)

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Tests failed on macOS M1 - Mac Big Sur (11.5) ❌

Tests failed on M1 - Mac Big Sur (11.5).

Failed tests are:

  • xammac_tests

Pipeline on Agent
[QuickLookThumbnailing] Update bindings for Xcode 13.0 beta 1 (#12338)

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Tests passed on macOS Mac High Sierra (10.13) ✅

Tests passed

All tests on macOS X Mac High Sierra (10.13) passed.

Pipeline on Agent
[QuickLookThumbnailing] Update bindings for Xcode 13.0 beta 1 (#12338)

Please sign in to comment.