[msbuild] Warn when we detect that the app developer is trying to lin…

…k with a static library when using Hot Restart. Fixes #17640. (#18940)

Warn when we detect that the app developer is trying to link with a static
library when using Hot Restart, because we don't support linking with static
libraries in that case.

Also change the resource generation for Xamarin.iOS.Tasks.Windows project to
generate the code-behind for the resources during the build (as opposed to by
the IDE - which won't happen unless using an IDE, while the build will always
happen).

Fixes #17640.

msbuild/Xamarin.iOS.Tasks.Windows/Properties/Resources.resx

@@ -19,4 +19,7 @@
 		<value>Info.plist file does not exist under {0}, please rebuild your project</value>
 		<comment>0: path</comment>
     </data>
+	<data name="HotRestartStaticLibraryNotSupported" xml:space="preserve">
+		<value>Linking with a static library is not supported when using Hot Restart.</value>
+	</data>
 </root>

msbuild/Xamarin.iOS.Tasks.Windows/Tasks/ComputeHotRestartBundleContents.cs

@@ -6,6 +6,7 @@
 using Microsoft.Build.Framework;
 using Microsoft.Build.Utilities;
 
+using Xamarin.iOS.Tasks.Windows.Properties;
 using Xamarin.MacDev.Tasks;
 
 #nullable enable
@@ -139,11 +140,13 @@ public override bool Execute ()
 				case PublishFolderType.Unknown: // Don't copy unknown stuff anywhere
 				case PublishFolderType.AppleBindingResourcePackage: // These aren't copied to the bundle
 				case PublishFolderType.CompressedAppleBindingResourcePackage: // These aren't copied to the bundle
-				case PublishFolderType.StaticLibrary: // These aren't copied to the bundle
 				case PublishFolderType.CompressedAppleFramework: // Shouldn't really happen? Should be uncompresed by the time we get here.
 				case PublishFolderType.CompressedPlugIns: // Shouldn't really happen? Should be uncompresed by the time we get here.
 					Log.LogMessage (MessageImportance.Low, $"    Skipped {item.ItemSpec} because PublishFolderType={publishFolderType} items aren't copied to the app bundle.");
 					continue;
+				case PublishFolderType.StaticLibrary: // These aren't copied to the bundle
+					Log.LogWarning (null, null, null, item.ItemSpec, 0, 0, 0, 0, Resources.HotRestartStaticLibraryNotSupported);
+					continue;
 				default:
 					Log.LogMessage (MessageImportance.Low, $"    Skipped {item.ItemSpec} because of unknown PublishFolderType={publishFolderType}.");
 					continue;

msbuild/Xamarin.iOS.Tasks.Windows/Xamarin.iOS.Tasks.Windows.csproj

@@ -50,16 +50,18 @@
     <Folder Include="Tasks\" />
   </ItemGroup>
   <ItemGroup>
+    <Compile Remove="Properties\Resources.Designer.cs" />
     <EmbeddedResource Update="Properties\Resources.resx">
+      <Type>Resx</Type>
       <Generator>ResXFileCodeGenerator</Generator>
       <LastGenOutput>Resources.Designer.cs</LastGenOutput>
+      <StronglyTypedFileName>Properties/Resources.Designer.cs</StronglyTypedFileName>
+      <StronglyTypedLanguage>CSharp</StronglyTypedLanguage>
+      <StronglyTypedNamespace>Xamarin.iOS.Tasks.Windows.Properties</StronglyTypedNamespace>
+      <StronglyTypedClassName>Resources</StronglyTypedClassName>
+      <GenerateResource>true</GenerateResource>
     </EmbeddedResource>
   </ItemGroup>
-  <ItemGroup>
-    <Compile Update="Properties\Resources.Designer.cs">
-      <DependentUpon>Resources.resx</DependentUpon>
-    </Compile>
-  </ItemGroup>
 
   <Import Project="$(MSBuildThisFileDirectory)..\ILMerge.targets" />