Skip to content
This repository was archived by the owner on Dec 23, 2024. It is now read-only.

Remove two types from MEF that were causing MEF errors #23

Merged
merged 1 commit into from
Dec 10, 2021

Conversation

KirillOsenkov
Copy link
Member

We don't use NavBar or breakpoint resolution in VSMac anyways

We don't use NavBar or breakpoint resolution in VSMac anyways
@KirillOsenkov
Copy link
Member Author

This fixes these two issues:

Microsoft.CodeAnalysis.ExternalAccess.FSharp.Internal.Editor.Implementation.Debugging.FSharpBreakpointResolutionService.ctor(service): expected exactly 1 export matching constraints:
    Contract name: Microsoft.CodeAnalysis.ExternalAccess.FSharp.Editor.Implementation.Debugging.IFSharpBreakpointResolutionService
    TypeIdentityName: Microsoft.CodeAnalysis.ExternalAccess.FSharp.Editor.Implementation.Debugging.IFSharpBreakpointResolutionService
but found 0.

Microsoft.CodeAnalysis.ExternalAccess.FSharp.Internal.Editor.FSharpNavigationBarItemService.ctor(service): expected exactly 1 export matching constraints:
    Contract name: Microsoft.CodeAnalysis.ExternalAccess.FSharp.Editor.IFSharpNavigationBarItemService
    TypeIdentityName: Microsoft.CodeAnalysis.ExternalAccess.FSharp.Editor.IFSharpNavigationBarItemService
but found 0.

@nosami
Copy link
Member

nosami commented Dec 10, 2021

I know that we use PathedDocument instead of NavBar but not so sure about removing the breakpoint resolution. I think it is needed in F# but I can take a look at adding that in later.

I suspect something has been added to Microsoft.CodeAnalysis.ExternalAccess.FSharp that we are missing.

@nosami nosami merged commit 9594339 into net6 Dec 10, 2021
@nosami nosami deleted the dev/kirillo/fixFSharpMEF branch December 10, 2021 09:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants