[SlackTextViewController] Updated to (almost) v1.9.6 to fix iOS 11 bugs #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much, sir! |
…version hasn't gone official
|
Because the native version is not yet released, this will be a preview release. As soon as the official version goes out, we will release the new version with any additional fixes/features. |
|
That seems eminently reasonable. |
|
does this fix the inserting/deleting cells issue? |
|
I'm not sure if it fixes that, but I have tested it and it does fix the problem where on iOS 11 the spacing at the bottom was all wrong and the text field didn't register taps. Thank you very much @mattleibow and @bholmes ! |
|
Great to hear that it fixes the iOS 11 issue. Any other issues need to be logged against the native library as this is just the binding. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #244
This build works off a specific commit due to the version not being out yet, and this is a critical fix.