-
Notifications
You must be signed in to change notification settings - Fork 686
Conversation
moljac
commented
Jul 28, 2022
- bumped several nuget versions
- matching builds for Xamarin.Android
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this also need to update the android
workload?
XamarinComponents/azure-pipelines.yml
Lines 80 to 83 in df29e1f
- pwsh: | | |
dotnet workload install android | |
displayName: install .NET 6 Android Workload | |
condition: ne(variables['System.JobName'], 'linux') |
Not sure. But I think it makes sense to update. |
Added snippet for workload installation and update from AX and/or GPS-FB-MLKit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like we did in AndroidX / GPS, can we "spot check" some of the .nupkg
files to make sure the file sizes are the same?
this would be quite difficult for XC repo. it builds according to manifest only folder involved in the PR. So if TensorFlow was updated it would build only TensorFlow. Maybe closing this PR w/o merging? |
@moljac can you make a small change in Tensorflow to test at least one of them? |
OK Should I multitarget We left it here as |
@moljac can you pick one that targets .NET 6? Maybe Xamarin.Android.Glide? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one looks fine now, but does #1398 replace it? It seems like that one also updates the Android workload.
One thing to keep in mind when changing Therefore it will never test your PR changes to YAML files. (I do not know why it is set up this way 🤷♂️) This commit breaks the Linux lane with:
As a result we can no longer publish anything out of this repository. We need to figure out if these changes were actually needed, and if so, how can we work around it for Linux. |