This repository was archived by the owner on Jan 13, 2025. It is now read-only.
[Bug] [Windows] Xamarin.Build.Download Fix Max Path Length Extraction #1296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moljac
reviewed
Nov 1, 2021
| if (Platform.IsWindows) | ||
| psi = new ProcessStartInfo (args.ProcessPath, args.ToString ()) | ||
| { | ||
| WorkingDirectory = null, |
There was a problem hiding this comment.
could you provide link to docs for this trick, please?
There was a problem hiding this comment.
Setting to null will default to System32 as the working directory, see here. This should be fine as no user/pass is specified & all the paths for the process and extraction are absolute. If we set it to contentDir it'll fail for paths over 260 chars.
This was referenced Nov 1, 2021
|
possibly related at least merge together |
This was
linked to
issues
Nov 1, 2021
dmariogatto
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #1295.
Simplified
AppendQuoted, now no longer tries to escape\or"and just wraps the text argument in double quotes (this I also believe is the same behaviour of QuotedArgument in Cake).As mentioned in the above issue this was found when testing NuGets built from xamarin/GoogleApisForiOSComponents#501 and is a blocking issue as it prevents building in VS for Windows.
New test case added
TestPathGreaterThan260Chars.Test have been validated on,