KotlinX.Coroutines 1.4.1 #1050

antonioseric · 2020-12-08T22:06:01Z

No description provided.

antonioser · 2020-12-08T22:07:15Z

waiting #987 to be merged

moljac · 2020-12-12T22:23:08Z

Must check possible duplicate:

#1053

moljac

It would be good to prefix nugets/namespaces/assemblies with Xamarin if author is Microsoft.

moljac · 2020-12-20T18:17:12Z

@antonioseric @antonioser

Antonio

I had to bind really fast 2 new bindings for 4-5 new AndroidX artifacts (androidx.window and androidx.work groups)

#1053

Would it be possible to add remaining stuff to Kotlin folder? IMO this will be most likely updated all together (though not sure)

antonioseric · 2020-12-20T18:34:24Z

I prefer not to put in Kotlin folder KotlinX is released separately. I think it is better to be decoupled. I change rootnamespace and binding namespace.

Currently working on sample app (plan to finish it today)

moljac · 2020-12-20T18:38:24Z

Don't forget nuget packagenames prefix please

moljac · 2020-12-20T18:39:06Z

OK. I will publish 1.3.4 from other PR and then delete it afterwards.

…oroutines-1.4.1 # Conflicts: # manifest.yaml

…oroutines-1.4.1

4brunu · 2021-03-03T22:43:21Z

Any news on this? 😊

antonioseric · 2021-03-08T08:11:58Z

@moljac can we merge this and publish nugets?

4brunu · 2021-04-03T20:37:04Z

Any news on this?
@moljac @jpobst @mattleibow

jpobst

Namespace that is not renamed or hidden:
### New Namespace Kotlin.Coroutines.Jvm.Internal

jpobst · 2021-05-07T13:59:36Z

Android/KotlinxCoroutines/source/Kotlinx.Coroutines.Android/Transforms/Metadata.xml

@@ -0,0 +1,6 @@
+<metadata>
+
+    <attr path="/api/package[@name='kotlinx.coroutines.android']" name="managedName">Xamarin.KotlinX.Coroutines.CoroutinesAndroid</attr>


I think we need to pick a standard capitalization for Kotlinx/KotlinX and be consistent with it.

Changing all to KotlinX

https://www.nuget.org/packages?q=Kotlinx

Looks like our existing packages have already committed to KotlinX:
https://www.fuget.org/packages/Xamarin.KotlinX.Coroutines.Core/1.3.4

😉

jpobst · 2021-05-07T14:10:56Z

Android/KotlinxCoroutines/source/Kotlinx.Coroutines.Core.Jvm/Kotlinx.Coroutines.Core.Jvm.csproj

@@ -0,0 +1,55 @@
+<?xml version="1.0" encoding="utf-8"?>


I don't think we want to bind these libraries that aren't intended for Android:

Xamarin.Kotlinx.Coroutines.Core.Jvm

Xamarin.Kotlinx.Coroutines.Core.Jdk8

Xamarin.Kotlinx.Coroutines.Core.Reactive

Xamarin.Kotlinx.Coroutines.Core.Rx2

Today it looks like we only publish 2 packages:

Xamarin.KotlinX.Coroutines.Core

Xamarin.KotlinX.Coroutines.CoroutinesAndroid

https://www.nuget.org/packages?q=xamarin+kotlin+coroutine

Today it looks like we only publish 2 packages:

I think I bound those from Kotlin folder, just minimal dependencies I needed for GPS-FB-MLKit.

So, deleting or not publishing other packages?

Dependencies listed:

kotlinx-coroutines-android

dependencies

kotlin-stdlib

kotlinx-coroutines-core-jvm

kotlinx-coroutines-core-jvm

dependencies

kotlin-stdlib

kotlin-stdlib-common

kotlinx-coroutines-jdk8

dependencies

kotlin-stdlib

kotlinx-coroutines-core-jvm

kotlinx-coroutines-reactive

dependencies

kotlin-stdlib

kotlinx-coroutines-core-jvm

org.reactivestreams:reactive-streams

kotlinx-coroutines-rx2

dependencies

kotlin-stdlib

kotlinx-coroutines-core-jvm

io.reactivex.rxjava2:rxjava

kotlinx-coroutines-reactive

Already bound:

Kotlin.StdLib

Xamarin.Android.ReactiveStreams

RxJava

So seem like those could be used on Android and it

moljac · 2021-05-11T19:52:55Z

because of conflicts manual merge had to be performed.

branch: https://github.com/xamarin/XamarinComponents/tree/antonioseric-KotlinxCoroutines-1.4.1

PR: #1155

moljac · 2021-05-13T15:45:42Z

closing this PR. Published from other PR/branch after manual merging

added Kotlinx.Coroutines 1.4.1

20b46af

Added KotlinxCoroutines to manifest.yaml

a88f18e

moljac mentioned this pull request Dec 12, 2020

KotlinX coroutines #1053

Merged

Merge branch 'master' into KotlinxCoroutines-1.4.1

c131bb3

moljac suggested changes Dec 20, 2020

View reviewed changes

Merge branch 'master' into KotlinxCoroutines-1.4.1

f7d8f78

fix namespace

42339fd

added sample app, fixed bindings, added targets

7b0af54

antonioseric marked this pull request as ready for review December 20, 2020 22:39

Antonio Seric and others added 7 commits January 9, 2021 19:40

Merge commit '124451a30b5598c10271102229ee8adfdfb97a47' into KotlinxC…

2c45fb9

…oroutines-1.4.1 # Conflicts: # manifest.yaml

removed kotlinx-coroutines from kotlin binding

983644f

fix kotlinx coroutines bindings metadata

e627f1e

add .idea/ to gitignore

f339004

remove kotlinx coroutines from Kotlin config.json

8ab0881

Merge branch 'master' into KotlinxCoroutines-1.4.1

7f8613c

Merge commit 'fe2166d118b70ce7950d518cdc26de18132238bd' into KotlinxC…

9edf0e5

…oroutines-1.4.1

antonioseric mentioned this pull request Mar 5, 2021

Kotlin 1.4.21 #1059

Closed

anTONIos and others added 2 commits April 29, 2021 14:39

Merge branch 'master' into KotlinxCoroutines-1.4.1

8d621a4

Merge branch 'master' into KotlinxCoroutines-1.4.1

adb82c1

moljac approved these changes May 7, 2021

View reviewed changes

moljac requested a review from jpobst May 7, 2021 12:14

jpobst reviewed May 7, 2021

View reviewed changes

moljac added 7 commits May 7, 2021 17:32

Kotlinx to KotlinX renaming

88e5fca

typo fixed

15facce

target framework 9.0

a5e958b

Create global.json

da7067d

old/stale cake script fixes

23ea606

BetterPickers cake script ci target

ca0dcf9

Merge branch 'master' into KotlinxCoroutines-1.4.1

c5eea29

moljac changed the title ~~Kotlinx.Coroutines 1.4.1~~ KotlinX.Coroutines 1.4.1 May 11, 2021

moljac self-assigned this May 13, 2021

moljac added do-not-merge in-progress Work is in progress labels May 13, 2021

moljac mentioned this pull request May 13, 2021

kotlinx coroutines 1.4.1 after manual merge #1155

Merged

Merge branch 'main' into KotlinxCoroutines-1.4.1

d1c7b5e

moljac closed this May 13, 2021

antonioseric deleted the KotlinxCoroutines-1.4.1 branch July 17, 2021 11:56

		@@ -0,0 +1,6 @@
		<metadata>

		<attr path="/api/package[@name='kotlinx.coroutines.android']" name="managedName">Xamarin.KotlinX.Coroutines.CoroutinesAndroid</attr>

KotlinX.Coroutines 1.4.1 #1050

KotlinX.Coroutines 1.4.1 #1050

Uh oh!

Conversation

antonioseric commented Dec 8, 2020

Uh oh!

antonioser commented Dec 8, 2020

Uh oh!

moljac commented Dec 12, 2020

Uh oh!

moljac left a comment

Choose a reason for hiding this comment

Uh oh!

moljac commented Dec 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

antonioseric commented Dec 20, 2020

Uh oh!

moljac commented Dec 20, 2020

Uh oh!

moljac commented Dec 20, 2020

Uh oh!

4brunu commented Mar 3, 2021

Uh oh!

antonioseric commented Mar 8, 2021

Uh oh!

4brunu commented Apr 3, 2021

Uh oh!

jpobst left a comment

Choose a reason for hiding this comment

Uh oh!

jpobst May 7, 2021

Choose a reason for hiding this comment

Uh oh!

moljac May 7, 2021

Choose a reason for hiding this comment

Uh oh!

jpobst May 7, 2021

Choose a reason for hiding this comment

Uh oh!

jpobst May 7, 2021

Choose a reason for hiding this comment

Uh oh!

moljac May 7, 2021

Choose a reason for hiding this comment

Uh oh!

moljac May 11, 2021

Choose a reason for hiding this comment

Uh oh!

moljac commented May 11, 2021

Uh oh!

moljac commented May 13, 2021

Uh oh!

Uh oh!

moljac commented Dec 20, 2020 •

edited

Loading