DrawingView #468

VladislavAntonyuk · 2020-10-19T19:36:36Z

Description of Change

Create DrawingView control, add DrawingViewService to get the image stream

Bugs Fixed

Fixes [Enhancement] GesturePad #467

Screenshots

Android:

UWP:

PR Checklist

Has tests (if omitted, state reason in description)
Has samples (if omitted, state reason in description)
Rebased on top of main at time of PR
Changes adhere to coding standard

Updated documentation

README.md

AndreiMisiukevich · 2020-10-20T14:50:50Z

But definitely, this is a great contribution! Well done

pictos

@VladislavAntonyuk thank you for this contribution. I tested on Android and I found some issues.

Looks like the Linker is messing up with the DependencyService, as can see in the image below
Also, on Android, I can't draw a full line, for some reason it lost track when a draw starting in the bottom and moving up.

For issue 1, instead of using the DependencyService, we can use Xamarin.Essentials approach and use partial static class that way the linker will be happy and we don't need the Init (not sure about Tizen).

XamarinCommunityToolkit/Views/GesturePad/Service/GesturePadService.gtk.cs

pictos · 2020-10-20T23:44:21Z

XamarinCommunityToolkit/Views/GesturePad/Renderer/GesturePadRenderer.tizen.cs

+using System.ComponentModel;
+using System.Linq;
+using ElmSharp;
+using SkiaSharp;


@VladislavAntonyuk do you know if we can do it in a native way?
Do we want to add this reference (SkiaSharp)? cc: @jfversluis , @AndreiMisiukevich

it should be possible, because SkiaSharp doing it. But I am not Tizen API expert, so I chose SkiaSharp

We can ask @rookiejava about this. But I think SkiaSharp is the way to go on Tizen.

@pictos I noticed, but the SkiaSharp is only for Tizen, right?

@jfversluis, yes

Thanks @VladislavAntonyuk for implementing tizen. 👍
Yes, native also supports simple primitive drawing, but using skiaSharp looks good.

VladislavAntonyuk · 2020-10-21T14:51:16Z

@pictos I removed interface IDrawingViewService. as for the 2nd issue, most likely you drawing out of the control. please try to setup background color

XamarinCommunityToolkit/Views/DrawingView/Renderer/DrawingViewRenderer.tizen.cs

pictos

Now Android is much better! Thank you! Also, we should just be able to draw on the gray area or the entire screen?

I'm sorry for the delay in the reviews, during the week I just can find time to review at night. If you need anything, please let me know (:

XamarinCommunityToolkit/Views/DrawingView/DrawingView.shared.cs

XamarinCommunityToolkit/Views/DrawingView/Renderer/DrawingViewRenderer.android.cs

XamarinCommunityToolkit/Views/DrawingView/Renderer/DrawingViewRenderer.ios.cs

XamarinCommunityToolkit/Views/DrawingView/Renderer/DrawingViewRenderer.macos.cs

XamarinCommunityToolkit/Views/DrawingView/Renderer/DrawingViewRenderer.tizen.cs

XamarinCommunityToolkit/Views/DrawingView/Service/DrawingViewService.android.cs

XamarinCommunityToolkit/Views/DrawingView/Service/DrawingViewService.tizen.cs

VladislavAntonyuk · 2020-10-22T17:55:06Z

Now Android is much better! Thank you! Also, we should just be able to draw on the gray area or the entire screen?

I'm sorry for the delay in the reviews, during the week I just can find time to review at night. If you need anything, please let me know (:

probably because I added Parent?.RequestDisallowInterceptTouchEvent(true); could you suggest how to fix it?

pictos · 2020-10-22T22:44:59Z

probably because I added Parent?.RequestDisallowInterceptTouchEvent(true); could you suggest how to fix it?

@VladislavAntonyuk I have no idea, to be honest. So will just think aloud here, hope that can inspire you somehow. Ca we limit the drawing area to the bounds of the gray rectangle? If so maybe that can solve our trouble.(?)

VladislavAntonyuk · 2020-10-23T12:27:58Z

probably because I added Parent?.RequestDisallowInterceptTouchEvent(true); could you suggest how to fix it?

@VladislavAntonyuk I have no idea, to be honest. So will just think aloud here, hope that can inspire you somehow. Ca we limit the drawing area to the bounds of the gray rectangle? If so maybe that can solve our trouble.(?)

also as you can see from the example after you stop drawing the drawing line is cut. to be honest I am also expect that it should work out of the box, but it draws on the whole screen. looks like it draws on the parent instead of view. it is the only 1 explanation which I have so far

VladislavAntonyuk · 2020-10-23T14:40:24Z

@pictos, it is fixed

pictos · 2020-10-25T16:25:50Z

@VladislavAntonyuk I'll re-review it ASAP, in the meanwhile can you solve these conflicts?

pictos · 2020-10-28T02:07:24Z

@VladislavAntonyuk I did a review here, and something went wrong with the update, the Tizen project doesn't load and I found an error in the Spanish rex file. I prefer to not push the changes to don't mess with your work.

Also on android, I faced an exception inside the DrawingViewService.GetImageInternal(IList<Point> points, float lineWidth, Color strokeColor, Color backgroundColor) method

To prevent this kind of error we can create an extension methods with math helpers, like MakeSureIsPositive, SafeDivideByZero, etc.

I think that @Clancey don't mind if we bring a couple of his helpers here.

Also for the VM sample, if you change the code for this one, it stops to work and shouldn't be.
https://gist.github.com/pictos/f612adf546b054c5d4cf8dd939cd6d92

Please let me know if I can help you with something. I'll try to find time to give more love to the XCT this weekend.

And one more time, thank you to move this forward❣

VladislavAntonyuk · 2020-10-28T18:38:48Z

@VladislavAntonyuk I did a review here, and something went wrong with the update, the Tizen project doesn't load and I found an error in the Spanish rex file. I prefer to not push the changes to don't mess with your work.

These issues are fixed

Also on android, I faced an exception inside the DrawingViewService.GetImageInternal(IList<Point> points, float lineWidth, Color strokeColor, Color backgroundColor) method

To prevent this kind of error we can create an extension methods with math helpers, like MakeSureIsPositive, SafeDivideByZero, etc.

I think that @Clancey don't mind if we bring a couple of his helpers here.

This one is also fixed for all platforms.

Also for the VM sample, if you change the code for this one, it stops to work and shouldn't be.
https://gist.github.com/pictos/f612adf546b054c5d4cf8dd939cd6d92

Please commit your code to fix this case

XamarinCommunityToolkit/Views/DrawingView/DrawingView.shared.cs

XamarinCommunityToolkit/Views/DrawingView/Renderer/DrawingViewRenderer.android.cs

XamarinCommunityToolkitSample.Android/Xamarin.CommunityToolkit.Sample.Android.csproj

pictos · 2020-10-29T01:04:36Z

@VladislavAntonyuk I did a review here, and something went wrong with the update, the Tizen project doesn't load and I found an error in the Spanish rex file. I prefer to not push the changes to don't mess with your work.

These issues are fixed

Also on android, I faced an exception inside the DrawingViewService.GetImageInternal(IList<Point> points, float lineWidth, Color strokeColor, Color backgroundColor) method

To prevent this kind of error we can create an extension methods with math helpers, like MakeSureIsPositive, SafeDivideByZero, etc.
I think that @Clancey don't mind if we bring a couple of his helpers here.

This one is also fixed for all platforms.

Also for the VM sample, if you change the code for this one, it stops to work and shouldn't be.
https://gist.github.com/pictos/f612adf546b054c5d4cf8dd939cd6d92

Please commit your code to fix this case

I can commit the changes on the weekend, I think. To be honest I didn't implement the fix for that one xP

pictos · 2020-11-02T15:44:05Z

@VladislavAntonyuk the solution to make this control be able to handle with INCC is bigger than I thought. We need to implement this per platform. Right now my focus is on re-implement the android camera view so I can't do it for now. If you want and can implement it here is a reference if you can't don't worry I'll jump into this ASAP.

Thanks.

XamarinCommunityToolkit/Views/DrawingView/DrawingView.shared.cs

VladislavAntonyuk · 2020-11-15T16:13:40Z

sorry, I am out of time to fix all comments right now. hope to have more time next weekends

VladislavAntonyuk · 2020-11-20T20:20:12Z

@pictos I made the changes in renderers. I subscribed to collectionChanged event. Looks like it works as you expect. Please let me know if I missed something.

XamarinCommunityToolkit/Views/SnackBar/Options/ToastOptions.shared.cs

VladislavAntonyuk · 2020-11-20T22:48:55Z

...olkit/Xamarin.CommunityToolkit.Sample.Android/Xamarin.CommunityToolkit.Sample.Android.csproj

    <PackageReference Include="Xamarin.Essentials" Version="1.5.3.2" />
    <PackageReference Include="Xamarin.Forms.PancakeView">
-      <Version>2.1.0.714</Version>
+      <Version>2.3.0.759</Version>


fix pancakeView for GTK and WPF

VladislavAntonyuk · 2020-11-20T22:51:29Z

src/CommunityToolkit/Xamarin.CommunityToolkit/Views/Snackbar/Options/ToastOptions.shared.cs

@@ -23,7 +23,7 @@ public class ToastOptions
 		/// </summary>
 		public Color BackgroundColor { get; set; } = DefaultBackgroundColor;

-		public static Color DefaultBackgroundColor { get; set; } = Color.Default;
+		public static Color DefaultBackgroundColor { get; set; } = Color.White;


not related, but fix uwp toast background color (default text color is black)

pictos · 2020-11-21T01:13:52Z

@pictos I made the changes in renderers. I subscribed to collectionChanged event. Looks like it works as you expect. Please let me know if I missed something.

@VladislavAntonyuk you rock man! I'll review it by tomorrow. Thanks again for this PR, I think that now I'll be ready to go.

pictos · 2020-11-21T02:33:42Z

@VladislavAntonyuk looks like that the build failed for GTK, can you take a look at it?

VladislavAntonyuk · 2020-11-21T05:45:50Z

Path to the libs folder has changed after rebase and folder reorganization. I will fix it

pictos · 2020-11-22T22:22:53Z

@VladislavAntonyuk I'll review it this week. And do small adjustments (code style, csproj editions, etc). Thanks again for your hard work on this one.

pictos · 2020-11-22T23:47:49Z

Since we don't have access to the PR made by contributors, I'll merge this PR in another branch and work from there. When it's finished I'll open a PR targeting the main branch.

* DrawingView (#468) * DrawingView control, samples, documentation * fix build issues Co-authored-by: Vladislav Antonyuk <vlad.antonyuk@outlook.com> Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com> * fixed codestyle on Android renderer * GTK renderer adjustments * iOS renderer adjustments * MacOS renderer adjustments * TIzen rendere adjustments * UWP renderer adjustments * WPF tests * Fixed merge conflict * Fixed wpf stackoverflow exception * fixed iOS leaks * revert toast change * removed wpf implementations * root sample page to WelcomePage * removed DrawingView ctor from MainWindow * removed drawing instructions from readme * Update README.md * Drawing View - Fix nullable, add doc to the public method (#1293) * Fix nullable, add doc to the public method. add WPF * Remove WPF renderer from the library. * Change exception message for small images, fix nullable * return null instead of exception (#1339) Co-authored-by: Vladislav Antonyuk <33021114+VladislavAntonyuk@users.noreply.github.com> Co-authored-by: Vladislav Antonyuk <vlad.antonyuk@outlook.com> Co-authored-by: Brandon Minnick <13558917+brminnick@users.noreply.github.com> Co-authored-by: Javier Suárez <javiersuarezruiz@hotmail.com> Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com>

* merge main -> dev (#1300) * Automated dotnet-format update (#1296) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * #1292 (#1301) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Andrei <andrei.misiukevich@gmail.com> * Expander: Add touch capture view + common animation length / easing properties (#1349) * Added base animation props * Added TouchCaptureView property * Updated light dismiss xml docs (#1366) * [Converter] Added IsInRangeConverter (#1158) * Added IsBetweenConverter * Renamed to IsInRangeConverter * Added Sample Page * Added IsInRangeConverterViewModel * Updated UnitTests * Cleanup * Removed RevertResult * Implemented BindableObjectExtension * Made ValueConverterExtension inherited from BindableObject Co-authored-by: Brandon Minnick <13558917+brminnick@users.noreply.github.com> Co-authored-by: Javier Suárez <javiersuarezruiz@hotmail.com> Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com> Co-authored-by: Andrei <andrei.misiukevich@gmail.com> Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com> * Drawing View (#740) * DrawingView (#468) * DrawingView control, samples, documentation * fix build issues Co-authored-by: Vladislav Antonyuk <vlad.antonyuk@outlook.com> Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com> * fixed codestyle on Android renderer * GTK renderer adjustments * iOS renderer adjustments * MacOS renderer adjustments * TIzen rendere adjustments * UWP renderer adjustments * WPF tests * Fixed merge conflict * Fixed wpf stackoverflow exception * fixed iOS leaks * revert toast change * removed wpf implementations * root sample page to WelcomePage * removed DrawingView ctor from MainWindow * removed drawing instructions from readme * Update README.md * Drawing View - Fix nullable, add doc to the public method (#1293) * Fix nullable, add doc to the public method. add WPF * Remove WPF renderer from the library. * Change exception message for small images, fix nullable * return null instead of exception (#1339) Co-authored-by: Vladislav Antonyuk <33021114+VladislavAntonyuk@users.noreply.github.com> Co-authored-by: Vladislav Antonyuk <vlad.antonyuk@outlook.com> Co-authored-by: Brandon Minnick <13558917+brminnick@users.noreply.github.com> Co-authored-by: Javier Suárez <javiersuarezruiz@hotmail.com> Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com> * Added IsLightDismissed to PopupDismissedEvent (#1362) * Added IsLightDismissed to PopupDismissedEvent; Fixed Dismissed event so it fires when light dismissed for UWP and Android * Removing stale comments * Added Opened event handler to set isOpen to true when Popup displays * Fixed event cleanup code to unregisterd Closing event Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com> * Fix Android crashes if Bitmap is small, Fix iOS drawing in scrollView (#1421) * Add StatusBarEffect and NavigationBarEffect classes to manage their color and style (#812) * Sample Android implementation (doesn't work) * Update to Android 11 * Add OnElementPropertyChanged * Refactor GetWindow a bit * Add dummy implementations for iOS and UWP * Update Xamarin.CommunityToolkit.csproj * Update Xamarin.CommunityToolkit.csproj * Fixed get Activity property * Update PlatformBarStyle.android.cs * Remove NavigationBar bits * Make SetStatusBarColor available on API 23+ * Make StatusBar white for demo app * Rename BarStyle to Window * Fix spaces * Revert "Update to Android 11" This reverts commit 656f0d0. * Update Xamarin.CommunityToolkit.csproj * Rename Window to WindowEffect * Revert Android 11 API support * Set status bar style in app.xaml * Replaced Window with WindowEffect is other places * Remove Detached implementation * Add WindowEffectAndroid for navigation bar stuff * Refactor SetBarStyle methods * Add UWP implementation * Add iOS implemetation (not tested) * Use switch expression * Add `#region` to specify Linker Work-Around * Rename WindowEffect to StatusBarEffect * Rename WindowEffectAndroid to PlatformNavigationBarEffect * Fix nullability errors * Commit to rerun tests * Revert "Commit to rerun tests" This reverts commit f207c74. * Add sample page * Fix default is not applied on Android * Fix radiobutton name on sample page * Add android specific NavigationBar class * Remove unneeded null checks * Coverted StatusBarEffect to static class * Improve description * Update EffectIds.shared.cs * Remove unneeded activity parameter * Refactor StatusBar.uwp * Setting view model in XAML * Update NavigationBar.android.cs * Make StatusBar style setters accessible from C# * Add XML documentation * Remove unrelated code * Move constant outside the loop * Add logs if bar style is not supported * Remove LightContent case * Commit to rerun build * Revert "Commit to rerun build" This reverts commit a49e18f. * Revert "Revert "Commit to rerun build"" This reverts commit c9b3d5b. * Revert "Revert "Revert "Commit to rerun build""" This reverts commit 7152b25. * Change Debug to Trace * Replace Trace with Log * Update src/CommunityToolkit/Xamarin.CommunityToolkit/PlatformConfiguration/AndroidSpecific/NavigationBar.shared.cs Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com> * Update src/CommunityToolkit/Xamarin.CommunityToolkit/PlatformConfiguration/AndroidSpecific/NavigationBar.shared.cs Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com> * Revert "Update src/CommunityToolkit/Xamarin.CommunityToolkit/PlatformConfiguration/AndroidSpecific/NavigationBar.shared.cs" This reverts commit c56f02b. * Revert "Update src/CommunityToolkit/Xamarin.CommunityToolkit/PlatformConfiguration/AndroidSpecific/NavigationBar.shared.cs" This reverts commit 6d37b50. * Move enums to sepparate files * Replace linq with methods * Update UpdateStatusBarAppearance to support iOS 13 Co-Authored-By: Daniel Christmas <1112585+justadaniel@users.noreply.github.com> * View controller-based status bar appearance: No Co-Authored-By: Daniel Christmas <1112585+justadaniel@users.noreply.github.com> * Commit to rerun tests * Update EffectsGalleryViewModel.cs * Move files to Effects folder * Converted BarStyle to effects * Update sample app * Drop Windows Mobile support * Get activity from control * Update NavigationBarEffect.shared.cs * Commit to rerun tests * refactoring ios * removed UWP linker hack We don't need it for UWP since we don't have a Linker for it * Removed not needed properties * Remove not needed null checks * Remove using * Commit to rerun tests * Moved NavigationBarEffect to use the platformspecific API * Updated the sample * Fix test * Little better styling Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com> Co-authored-by: Brandon Minnick <13558917+brminnick@users.noreply.github.com> Co-authored-by: Javier Suárez <javiersuarezruiz@hotmail.com> Co-authored-by: Daniel Christmas <1112585+justadaniel@users.noreply.github.com> Co-authored-by: Gerald Versluis <gerald@verslu.is> * Drawing view fixes (#1459) * Set default line LineColor as black, Fix ClearOnFinish * Fix SmoothPath issue, update macOS renderer, update sample * Fix tizen build * Snackbar corner radius (#1437) * Snackbar/Toast CornerRadius * iOS, macOS * UWP * WPF * Update sample, add NativeSnackBar.ios.macos.cs * Fix ios, macos corner radius * Update default corner radius to 4 ```xml <shape android:shape="rectangle" xmlns:android="http://schemas.android.com/apk/res/android"> <solid android:color="#323232"/> <corners android:radius="4dp"/> </shape> ``` * Set CornerRadius to 10 * Set CornerRadius to 10 * Use default Corner Radius if not specified Co-authored-by: Brandon Minnick <13558917+brminnick@users.noreply.github.com> Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com> Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Andrei <andrei.misiukevich@gmail.com> Co-authored-by: Andrew Hoefling <andrewh@fileonq.com> Co-authored-by: Brandon Minnick <13558917+brminnick@users.noreply.github.com> Co-authored-by: Gustavo Oliveira <gu.ol@hotmail.com> Co-authored-by: Javier Suárez <javiersuarezruiz@hotmail.com> Co-authored-by: Vladislav Antonyuk <33021114+VladislavAntonyuk@users.noreply.github.com> Co-authored-by: Vladislav Antonyuk <vlad.antonyuk@outlook.com> Co-authored-by: Maksym Koshovyi <maximkoshevoi61@gmail.com> Co-authored-by: Daniel Christmas <1112585+justadaniel@users.noreply.github.com>

* merge main -> dev (#1300) * Automated dotnet-format update (#1296) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * #1292 (#1301) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Andrei <andrei.misiukevich@gmail.com> * Expander: Add touch capture view + common animation length / easing properties (#1349) * Added base animation props * Added TouchCaptureView property * Updated light dismiss xml docs (#1366) * [Converter] Added IsInRangeConverter (#1158) * Added IsBetweenConverter * Renamed to IsInRangeConverter * Added Sample Page * Added IsInRangeConverterViewModel * Updated UnitTests * Cleanup * Removed RevertResult * Implemented BindableObjectExtension * Made ValueConverterExtension inherited from BindableObject Co-authored-by: Brandon Minnick <13558917+brminnick@users.noreply.github.com> Co-authored-by: Javier Suárez <javiersuarezruiz@hotmail.com> Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com> Co-authored-by: Andrei <andrei.misiukevich@gmail.com> Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com> * Drawing View (#740) * DrawingView (#468) * DrawingView control, samples, documentation * fix build issues Co-authored-by: Vladislav Antonyuk <vlad.antonyuk@outlook.com> Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com> * fixed codestyle on Android renderer * GTK renderer adjustments * iOS renderer adjustments * MacOS renderer adjustments * TIzen rendere adjustments * UWP renderer adjustments * WPF tests * Fixed merge conflict * Fixed wpf stackoverflow exception * fixed iOS leaks * revert toast change * removed wpf implementations * root sample page to WelcomePage * removed DrawingView ctor from MainWindow * removed drawing instructions from readme * Update README.md * Drawing View - Fix nullable, add doc to the public method (#1293) * Fix nullable, add doc to the public method. add WPF * Remove WPF renderer from the library. * Change exception message for small images, fix nullable * return null instead of exception (#1339) Co-authored-by: Vladislav Antonyuk <33021114+VladislavAntonyuk@users.noreply.github.com> Co-authored-by: Vladislav Antonyuk <vlad.antonyuk@outlook.com> Co-authored-by: Brandon Minnick <13558917+brminnick@users.noreply.github.com> Co-authored-by: Javier Suárez <javiersuarezruiz@hotmail.com> Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com> * Added IsLightDismissed to PopupDismissedEvent (#1362) * Added IsLightDismissed to PopupDismissedEvent; Fixed Dismissed event so it fires when light dismissed for UWP and Android * Removing stale comments * Added Opened event handler to set isOpen to true when Popup displays * Fixed event cleanup code to unregisterd Closing event Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com> * Fix Android crashes if Bitmap is small, Fix iOS drawing in scrollView (#1421) * Add StatusBarEffect and NavigationBarEffect classes to manage their color and style (#812) * Sample Android implementation (doesn't work) * Update to Android 11 * Add OnElementPropertyChanged * Refactor GetWindow a bit * Add dummy implementations for iOS and UWP * Update Xamarin.CommunityToolkit.csproj * Update Xamarin.CommunityToolkit.csproj * Fixed get Activity property * Update PlatformBarStyle.android.cs * Remove NavigationBar bits * Make SetStatusBarColor available on API 23+ * Make StatusBar white for demo app * Rename BarStyle to Window * Fix spaces * Revert "Update to Android 11" This reverts commit 656f0d0. * Update Xamarin.CommunityToolkit.csproj * Rename Window to WindowEffect * Revert Android 11 API support * Set status bar style in app.xaml * Replaced Window with WindowEffect is other places * Remove Detached implementation * Add WindowEffectAndroid for navigation bar stuff * Refactor SetBarStyle methods * Add UWP implementation * Add iOS implemetation (not tested) * Use switch expression * Add `#region` to specify Linker Work-Around * Rename WindowEffect to StatusBarEffect * Rename WindowEffectAndroid to PlatformNavigationBarEffect * Fix nullability errors * Commit to rerun tests * Revert "Commit to rerun tests" This reverts commit f207c74. * Add sample page * Fix default is not applied on Android * Fix radiobutton name on sample page * Add android specific NavigationBar class * Remove unneeded null checks * Coverted StatusBarEffect to static class * Improve description * Update EffectIds.shared.cs * Remove unneeded activity parameter * Refactor StatusBar.uwp * Setting view model in XAML * Update NavigationBar.android.cs * Make StatusBar style setters accessible from C# * Add XML documentation * Remove unrelated code * Move constant outside the loop * Add logs if bar style is not supported * Remove LightContent case * Commit to rerun build * Revert "Commit to rerun build" This reverts commit a49e18f. * Revert "Revert "Commit to rerun build"" This reverts commit c9b3d5b. * Revert "Revert "Revert "Commit to rerun build""" This reverts commit 7152b25. * Change Debug to Trace * Replace Trace with Log * Update src/CommunityToolkit/Xamarin.CommunityToolkit/PlatformConfiguration/AndroidSpecific/NavigationBar.shared.cs Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com> * Update src/CommunityToolkit/Xamarin.CommunityToolkit/PlatformConfiguration/AndroidSpecific/NavigationBar.shared.cs Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com> * Revert "Update src/CommunityToolkit/Xamarin.CommunityToolkit/PlatformConfiguration/AndroidSpecific/NavigationBar.shared.cs" This reverts commit c56f02b. * Revert "Update src/CommunityToolkit/Xamarin.CommunityToolkit/PlatformConfiguration/AndroidSpecific/NavigationBar.shared.cs" This reverts commit 6d37b50. * Move enums to sepparate files * Replace linq with methods * Update UpdateStatusBarAppearance to support iOS 13 Co-Authored-By: Daniel Christmas <1112585+justadaniel@users.noreply.github.com> * View controller-based status bar appearance: No Co-Authored-By: Daniel Christmas <1112585+justadaniel@users.noreply.github.com> * Commit to rerun tests * Update EffectsGalleryViewModel.cs * Move files to Effects folder * Converted BarStyle to effects * Update sample app * Drop Windows Mobile support * Get activity from control * Update NavigationBarEffect.shared.cs * Commit to rerun tests * refactoring ios * removed UWP linker hack We don't need it for UWP since we don't have a Linker for it * Removed not needed properties * Remove not needed null checks * Remove using * Commit to rerun tests * Moved NavigationBarEffect to use the platformspecific API * Updated the sample * Fix test * Little better styling Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com> Co-authored-by: Brandon Minnick <13558917+brminnick@users.noreply.github.com> Co-authored-by: Javier Suárez <javiersuarezruiz@hotmail.com> Co-authored-by: Daniel Christmas <1112585+justadaniel@users.noreply.github.com> Co-authored-by: Gerald Versluis <gerald@verslu.is> * Drawing view fixes (#1459) * Set default line LineColor as black, Fix ClearOnFinish * Fix SmoothPath issue, update macOS renderer, update sample * Fix tizen build * Snackbar corner radius (#1437) * Snackbar/Toast CornerRadius * iOS, macOS * UWP * WPF * Update sample, add NativeSnackBar.ios.macos.cs * Fix ios, macos corner radius * Update default corner radius to 4 ```xml <shape android:shape="rectangle" xmlns:android="http://schemas.android.com/apk/res/android"> <solid android:color="#323232"/> <corners android:radius="4dp"/> </shape> ``` * Set CornerRadius to 10 * Set CornerRadius to 10 * Use default Corner Radius if not specified Co-authored-by: Brandon Minnick <13558917+brminnick@users.noreply.github.com> Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com> * Added missing using System (#1483) * [MacOS] Added MediaElement implementation (#1488) Co-authored-by: Yuriy Holembyovskyy <yuriy.holembyovskyy@gmail.com> Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com> Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Andrei <andrei.misiukevich@gmail.com> Co-authored-by: Andrew Hoefling <andrewh@fileonq.com> Co-authored-by: Brandon Minnick <13558917+brminnick@users.noreply.github.com> Co-authored-by: Gustavo Oliveira <gu.ol@hotmail.com> Co-authored-by: Javier Suárez <javiersuarezruiz@hotmail.com> Co-authored-by: Vladislav Antonyuk <33021114+VladislavAntonyuk@users.noreply.github.com> Co-authored-by: Vladislav Antonyuk <vlad.antonyuk@outlook.com> Co-authored-by: Maksym Koshovyi <maximkoshevoi61@gmail.com> Co-authored-by: Daniel Christmas <1112585+justadaniel@users.noreply.github.com> Co-authored-by: Yuriy Holembyovskyy <yholembyovskyy@gmail.com> Co-authored-by: Yuriy Holembyovskyy <yuriy.holembyovskyy@gmail.com>

* merge main -> dev (#1300) * Automated dotnet-format update (#1296) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * #1292 (#1301) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Andrei <andrei.misiukevich@gmail.com> * Expander: Add touch capture view + common animation length / easing properties (#1349) * Added base animation props * Added TouchCaptureView property * Updated light dismiss xml docs (#1366) * [Converter] Added IsInRangeConverter (#1158) * Added IsBetweenConverter * Renamed to IsInRangeConverter * Added Sample Page * Added IsInRangeConverterViewModel * Updated UnitTests * Cleanup * Removed RevertResult * Implemented BindableObjectExtension * Made ValueConverterExtension inherited from BindableObject Co-authored-by: Brandon Minnick <13558917+brminnick@users.noreply.github.com> Co-authored-by: Javier Suárez <javiersuarezruiz@hotmail.com> Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com> Co-authored-by: Andrei <andrei.misiukevich@gmail.com> Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com> * Drawing View (#740) * DrawingView (#468) * DrawingView control, samples, documentation * fix build issues Co-authored-by: Vladislav Antonyuk <vlad.antonyuk@outlook.com> Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com> * fixed codestyle on Android renderer * GTK renderer adjustments * iOS renderer adjustments * MacOS renderer adjustments * TIzen rendere adjustments * UWP renderer adjustments * WPF tests * Fixed merge conflict * Fixed wpf stackoverflow exception * fixed iOS leaks * revert toast change * removed wpf implementations * root sample page to WelcomePage * removed DrawingView ctor from MainWindow * removed drawing instructions from readme * Update README.md * Drawing View - Fix nullable, add doc to the public method (#1293) * Fix nullable, add doc to the public method. add WPF * Remove WPF renderer from the library. * Change exception message for small images, fix nullable * return null instead of exception (#1339) Co-authored-by: Vladislav Antonyuk <33021114+VladislavAntonyuk@users.noreply.github.com> Co-authored-by: Vladislav Antonyuk <vlad.antonyuk@outlook.com> Co-authored-by: Brandon Minnick <13558917+brminnick@users.noreply.github.com> Co-authored-by: Javier Suárez <javiersuarezruiz@hotmail.com> Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com> * Added IsLightDismissed to PopupDismissedEvent (#1362) * Added IsLightDismissed to PopupDismissedEvent; Fixed Dismissed event so it fires when light dismissed for UWP and Android * Removing stale comments * Added Opened event handler to set isOpen to true when Popup displays * Fixed event cleanup code to unregisterd Closing event Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com> * Fix Android crashes if Bitmap is small, Fix iOS drawing in scrollView (#1421) * Add StatusBarEffect and NavigationBarEffect classes to manage their color and style (#812) * Sample Android implementation (doesn't work) * Update to Android 11 * Add OnElementPropertyChanged * Refactor GetWindow a bit * Add dummy implementations for iOS and UWP * Update Xamarin.CommunityToolkit.csproj * Update Xamarin.CommunityToolkit.csproj * Fixed get Activity property * Update PlatformBarStyle.android.cs * Remove NavigationBar bits * Make SetStatusBarColor available on API 23+ * Make StatusBar white for demo app * Rename BarStyle to Window * Fix spaces * Revert "Update to Android 11" This reverts commit 656f0d0. * Update Xamarin.CommunityToolkit.csproj * Rename Window to WindowEffect * Revert Android 11 API support * Set status bar style in app.xaml * Replaced Window with WindowEffect is other places * Remove Detached implementation * Add WindowEffectAndroid for navigation bar stuff * Refactor SetBarStyle methods * Add UWP implementation * Add iOS implemetation (not tested) * Use switch expression * Add `#region` to specify Linker Work-Around * Rename WindowEffect to StatusBarEffect * Rename WindowEffectAndroid to PlatformNavigationBarEffect * Fix nullability errors * Commit to rerun tests * Revert "Commit to rerun tests" This reverts commit f207c74. * Add sample page * Fix default is not applied on Android * Fix radiobutton name on sample page * Add android specific NavigationBar class * Remove unneeded null checks * Coverted StatusBarEffect to static class * Improve description * Update EffectIds.shared.cs * Remove unneeded activity parameter * Refactor StatusBar.uwp * Setting view model in XAML * Update NavigationBar.android.cs * Make StatusBar style setters accessible from C# * Add XML documentation * Remove unrelated code * Move constant outside the loop * Add logs if bar style is not supported * Remove LightContent case * Commit to rerun build * Revert "Commit to rerun build" This reverts commit a49e18f. * Revert "Revert "Commit to rerun build"" This reverts commit c9b3d5b. * Revert "Revert "Revert "Commit to rerun build""" This reverts commit 7152b25. * Change Debug to Trace * Replace Trace with Log * Update src/CommunityToolkit/Xamarin.CommunityToolkit/PlatformConfiguration/AndroidSpecific/NavigationBar.shared.cs Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com> * Update src/CommunityToolkit/Xamarin.CommunityToolkit/PlatformConfiguration/AndroidSpecific/NavigationBar.shared.cs Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com> * Revert "Update src/CommunityToolkit/Xamarin.CommunityToolkit/PlatformConfiguration/AndroidSpecific/NavigationBar.shared.cs" This reverts commit c56f02b. * Revert "Update src/CommunityToolkit/Xamarin.CommunityToolkit/PlatformConfiguration/AndroidSpecific/NavigationBar.shared.cs" This reverts commit 6d37b50. * Move enums to sepparate files * Replace linq with methods * Update UpdateStatusBarAppearance to support iOS 13 Co-Authored-By: Daniel Christmas <1112585+justadaniel@users.noreply.github.com> * View controller-based status bar appearance: No Co-Authored-By: Daniel Christmas <1112585+justadaniel@users.noreply.github.com> * Commit to rerun tests * Update EffectsGalleryViewModel.cs * Move files to Effects folder * Converted BarStyle to effects * Update sample app * Drop Windows Mobile support * Get activity from control * Update NavigationBarEffect.shared.cs * Commit to rerun tests * refactoring ios * removed UWP linker hack We don't need it for UWP since we don't have a Linker for it * Removed not needed properties * Remove not needed null checks * Remove using * Commit to rerun tests * Moved NavigationBarEffect to use the platformspecific API * Updated the sample * Fix test * Little better styling Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com> Co-authored-by: Brandon Minnick <13558917+brminnick@users.noreply.github.com> Co-authored-by: Javier Suárez <javiersuarezruiz@hotmail.com> Co-authored-by: Daniel Christmas <1112585+justadaniel@users.noreply.github.com> Co-authored-by: Gerald Versluis <gerald@verslu.is> * Drawing view fixes (#1459) * Set default line LineColor as black, Fix ClearOnFinish * Fix SmoothPath issue, update macOS renderer, update sample * Fix tizen build * Snackbar corner radius (#1437) * Snackbar/Toast CornerRadius * iOS, macOS * UWP * WPF * Update sample, add NativeSnackBar.ios.macos.cs * Fix ios, macos corner radius * Update default corner radius to 4 ```xml <shape android:shape="rectangle" xmlns:android="http://schemas.android.com/apk/res/android"> <solid android:color="#323232"/> <corners android:radius="4dp"/> </shape> ``` * Set CornerRadius to 10 * Set CornerRadius to 10 * Use default Corner Radius if not specified Co-authored-by: Brandon Minnick <13558917+brminnick@users.noreply.github.com> Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com> * Added missing using System (#1483) * [MacOS] Added MediaElement implementation (#1488) Co-authored-by: Yuriy Holembyovskyy <yuriy.holembyovskyy@gmail.com> Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com> * Drawing view multi line (#1475) * DrawingView MultiLine WPF, UWP * Android * GTK, Tizen * iOS, macOS * DrawingViewService Get Stream from lines * added missing System using * Add GetImageStream * Fix tests * Add description to switches * Styling and comments * DrawingLineCompletedEventArgs * Add summary, Add tests Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com> Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com> Co-authored-by: Gerald Versluis <gerald@verslu.is> * [Bug] Fixed CameraView Linker issue (#1503) * Fixed CameraView linker issue * Added Preserve Conditional * Added test case Co-authored-by: Gustavo Oliveira <gustavo.oliveira@inspectrealestate.com.au> Co-authored-by: Andrei <andrei.misiukevich@gmail.com> Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com> * [iOS | Android] TextSwitcher + [iOS] ImageSwitcher (#1422) * Added text switcher * Added text switcher sample * Address comments * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Views/ViewSwitcher/TextSwitcherRenderer.android.cs Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com> * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Views/ViewSwitcher/TextSwitcherRenderer.android.cs Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com> * address comment * fixed build * fixed typo * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Views/ViewSwitcher/TextSwitcherRenderer.android.cs Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com> * cached sdk int * Fixed warnings Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com> * iOS, macOS - Clean DrawingView on Lines clean (#1520) * [Bug] Fixed CameraView crash on FlashMode Torch (#1522) * Update FormsCameraView.ios.cs Fixed CameraView crashing in Torch FlashMode * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Views/CameraView/iOS/FormsCameraView.ios.cs Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com> Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com> Co-authored-by: Andrei <andrei.misiukevich@gmail.com> * Consolidate our XCT platform class (#1559) * Moved and renamed ToolkitPlatform to XCT inside helpers folder * replaced all SDK version calls to XCT cached one * removed unecessary space * Added a cache to the iOS version * [Bug] Fixed CameraView Shutter not responding (#1535) * Fixed CameraView Shutter not responding * Fixed Merge conflict * Update FormsCameraView.ios.cs Removed unnecessary code * Update FormsCameraView.ios.cs Co-authored-by: Andrei <andrei.misiukevich@gmail.com> Co-authored-by: Gerald Versluis <gerald@verslu.is> Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com> * Added Speed Property to mediaelement (#1570) * Added Speed control for MediaElement in iOS and Android * Added Update Speed inside Play Method so after pausing and playing speed will be remembered * Added Sample for speed * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Views/MediaElement/Android/MediaElementRenderer.android.cs Co-authored-by: Andrei <andrei.misiukevich@gmail.com> * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Views/MediaElement/Android/MediaElementRenderer.android.cs Co-authored-by: Andrei <andrei.misiukevich@gmail.com> * Changed Speed Property binding mode to oneway and removed un necessary property Speed from IMediaElementController * Added Speed control for MediaElement in iOS and Android * Changed Speed Property binding mode to oneway and removed un necessary property Speed from IMediaElementController Co-authored-by: Aswin P G <aswinpg@outlook.in> Co-authored-by: Andrei <andrei.misiukevich@gmail.com> Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Andrei <andrei.misiukevich@gmail.com> Co-authored-by: Andrew Hoefling <andrewh@fileonq.com> Co-authored-by: Brandon Minnick <13558917+brminnick@users.noreply.github.com> Co-authored-by: Gustavo Oliveira <gu.ol@hotmail.com> Co-authored-by: Javier Suárez <javiersuarezruiz@hotmail.com> Co-authored-by: Vladislav Antonyuk <33021114+VladislavAntonyuk@users.noreply.github.com> Co-authored-by: Vladislav Antonyuk <vlad.antonyuk@outlook.com> Co-authored-by: Maksym Koshovyi <maximkoshevoi61@gmail.com> Co-authored-by: Daniel Christmas <1112585+justadaniel@users.noreply.github.com> Co-authored-by: Yuriy Holembyovskyy <yholembyovskyy@gmail.com> Co-authored-by: Yuriy Holembyovskyy <yuriy.holembyovskyy@gmail.com> Co-authored-by: Gustavo Oliveira <gustavo.oliveira@inspectrealestate.com.au> Co-authored-by: Aswin P G <aswinpg@outlook.in>

* merge main -> dev (#1300) * Automated dotnet-format update (#1296) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * #1292 (#1301) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Andrei <andrei.misiukevich@gmail.com> * Expander: Add touch capture view + common animation length / easing properties (#1349) * Added base animation props * Added TouchCaptureView property * Updated light dismiss xml docs (#1366) * [Converter] Added IsInRangeConverter (#1158) * Added IsBetweenConverter * Renamed to IsInRangeConverter * Added Sample Page * Added IsInRangeConverterViewModel * Updated UnitTests * Cleanup * Removed RevertResult * Implemented BindableObjectExtension * Made ValueConverterExtension inherited from BindableObject Co-authored-by: Brandon Minnick <13558917+brminnick@users.noreply.github.com> Co-authored-by: Javier Suárez <javiersuarezruiz@hotmail.com> Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com> Co-authored-by: Andrei <andrei.misiukevich@gmail.com> Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com> * Drawing View (#740) * DrawingView (#468) * DrawingView control, samples, documentation * fix build issues Co-authored-by: Vladislav Antonyuk <vlad.antonyuk@outlook.com> Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com> * fixed codestyle on Android renderer * GTK renderer adjustments * iOS renderer adjustments * MacOS renderer adjustments * TIzen rendere adjustments * UWP renderer adjustments * WPF tests * Fixed merge conflict * Fixed wpf stackoverflow exception * fixed iOS leaks * revert toast change * removed wpf implementations * root sample page to WelcomePage * removed DrawingView ctor from MainWindow * removed drawing instructions from readme * Update README.md * Drawing View - Fix nullable, add doc to the public method (#1293) * Fix nullable, add doc to the public method. add WPF * Remove WPF renderer from the library. * Change exception message for small images, fix nullable * return null instead of exception (#1339) Co-authored-by: Vladislav Antonyuk <33021114+VladislavAntonyuk@users.noreply.github.com> Co-authored-by: Vladislav Antonyuk <vlad.antonyuk@outlook.com> Co-authored-by: Brandon Minnick <13558917+brminnick@users.noreply.github.com> Co-authored-by: Javier Suárez <javiersuarezruiz@hotmail.com> Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com> * Added IsLightDismissed to PopupDismissedEvent (#1362) * Added IsLightDismissed to PopupDismissedEvent; Fixed Dismissed event so it fires when light dismissed for UWP and Android * Removing stale comments * Added Opened event handler to set isOpen to true when Popup displays * Fixed event cleanup code to unregisterd Closing event Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com> * Fix Android crashes if Bitmap is small, Fix iOS drawing in scrollView (#1421) * Add StatusBarEffect and NavigationBarEffect classes to manage their color and style (#812) * Sample Android implementation (doesn't work) * Update to Android 11 * Add OnElementPropertyChanged * Refactor GetWindow a bit * Add dummy implementations for iOS and UWP * Update Xamarin.CommunityToolkit.csproj * Update Xamarin.CommunityToolkit.csproj * Fixed get Activity property * Update PlatformBarStyle.android.cs * Remove NavigationBar bits * Make SetStatusBarColor available on API 23+ * Make StatusBar white for demo app * Rename BarStyle to Window * Fix spaces * Revert "Update to Android 11" This reverts commit 656f0d0. * Update Xamarin.CommunityToolkit.csproj * Rename Window to WindowEffect * Revert Android 11 API support * Set status bar style in app.xaml * Replaced Window with WindowEffect is other places * Remove Detached implementation * Add WindowEffectAndroid for navigation bar stuff * Refactor SetBarStyle methods * Add UWP implementation * Add iOS implemetation (not tested) * Use switch expression * Add `#region` to specify Linker Work-Around * Rename WindowEffect to StatusBarEffect * Rename WindowEffectAndroid to PlatformNavigationBarEffect * Fix nullability errors * Commit to rerun tests * Revert "Commit to rerun tests" This reverts commit f207c74. * Add sample page * Fix default is not applied on Android * Fix radiobutton name on sample page * Add android specific NavigationBar class * Remove unneeded null checks * Coverted StatusBarEffect to static class * Improve description * Update EffectIds.shared.cs * Remove unneeded activity parameter * Refactor StatusBar.uwp * Setting view model in XAML * Update NavigationBar.android.cs * Make StatusBar style setters accessible from C# * Add XML documentation * Remove unrelated code * Move constant outside the loop * Add logs if bar style is not supported * Remove LightContent case * Commit to rerun build * Revert "Commit to rerun build" This reverts commit a49e18f. * Revert "Revert "Commit to rerun build"" This reverts commit c9b3d5b. * Revert "Revert "Revert "Commit to rerun build""" This reverts commit 7152b25. * Change Debug to Trace * Replace Trace with Log * Update src/CommunityToolkit/Xamarin.CommunityToolkit/PlatformConfiguration/AndroidSpecific/NavigationBar.shared.cs Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com> * Update src/CommunityToolkit/Xamarin.CommunityToolkit/PlatformConfiguration/AndroidSpecific/NavigationBar.shared.cs Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com> * Revert "Update src/CommunityToolkit/Xamarin.CommunityToolkit/PlatformConfiguration/AndroidSpecific/NavigationBar.shared.cs" This reverts commit c56f02b. * Revert "Update src/CommunityToolkit/Xamarin.CommunityToolkit/PlatformConfiguration/AndroidSpecific/NavigationBar.shared.cs" This reverts commit 6d37b50. * Move enums to sepparate files * Replace linq with methods * Update UpdateStatusBarAppearance to support iOS 13 Co-Authored-By: Daniel Christmas <1112585+justadaniel@users.noreply.github.com> * View controller-based status bar appearance: No Co-Authored-By: Daniel Christmas <1112585+justadaniel@users.noreply.github.com> * Commit to rerun tests * Update EffectsGalleryViewModel.cs * Move files to Effects folder * Converted BarStyle to effects * Update sample app * Drop Windows Mobile support * Get activity from control * Update NavigationBarEffect.shared.cs * Commit to rerun tests * refactoring ios * removed UWP linker hack We don't need it for UWP since we don't have a Linker for it * Removed not needed properties * Remove not needed null checks * Remove using * Commit to rerun tests * Moved NavigationBarEffect to use the platformspecific API * Updated the sample * Fix test * Little better styling Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com> Co-authored-by: Brandon Minnick <13558917+brminnick@users.noreply.github.com> Co-authored-by: Javier Suárez <javiersuarezruiz@hotmail.com> Co-authored-by: Daniel Christmas <1112585+justadaniel@users.noreply.github.com> Co-authored-by: Gerald Versluis <gerald@verslu.is> * Drawing view fixes (#1459) * Set default line LineColor as black, Fix ClearOnFinish * Fix SmoothPath issue, update macOS renderer, update sample * Fix tizen build * Snackbar corner radius (#1437) * Snackbar/Toast CornerRadius * iOS, macOS * UWP * WPF * Update sample, add NativeSnackBar.ios.macos.cs * Fix ios, macos corner radius * Update default corner radius to 4 ```xml <shape android:shape="rectangle" xmlns:android="http://schemas.android.com/apk/res/android"> <solid android:color="#323232"/> <corners android:radius="4dp"/> </shape> ``` * Set CornerRadius to 10 * Set CornerRadius to 10 * Use default Corner Radius if not specified Co-authored-by: Brandon Minnick <13558917+brminnick@users.noreply.github.com> Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com> * Added missing using System (#1483) * [MacOS] Added MediaElement implementation (#1488) Co-authored-by: Yuriy Holembyovskyy <yuriy.holembyovskyy@gmail.com> Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com> * Drawing view multi line (#1475) * DrawingView MultiLine WPF, UWP * Android * GTK, Tizen * iOS, macOS * DrawingViewService Get Stream from lines * added missing System using * Add GetImageStream * Fix tests * Add description to switches * Styling and comments * DrawingLineCompletedEventArgs * Add summary, Add tests Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com> Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com> Co-authored-by: Gerald Versluis <gerald@verslu.is> * [Bug] Fixed CameraView Linker issue (#1503) * Fixed CameraView linker issue * Added Preserve Conditional * Added test case Co-authored-by: Gustavo Oliveira <gustavo.oliveira@inspectrealestate.com.au> Co-authored-by: Andrei <andrei.misiukevich@gmail.com> Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com> * [iOS | Android] TextSwitcher + [iOS] ImageSwitcher (#1422) * Added text switcher * Added text switcher sample * Address comments * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Views/ViewSwitcher/TextSwitcherRenderer.android.cs Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com> * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Views/ViewSwitcher/TextSwitcherRenderer.android.cs Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com> * address comment * fixed build * fixed typo * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Views/ViewSwitcher/TextSwitcherRenderer.android.cs Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com> * cached sdk int * Fixed warnings Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com> * iOS, macOS - Clean DrawingView on Lines clean (#1520) * [Bug] Fixed CameraView crash on FlashMode Torch (#1522) * Update FormsCameraView.ios.cs Fixed CameraView crashing in Torch FlashMode * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Views/CameraView/iOS/FormsCameraView.ios.cs Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com> Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com> Co-authored-by: Andrei <andrei.misiukevich@gmail.com> * Consolidate our XCT platform class (#1559) * Moved and renamed ToolkitPlatform to XCT inside helpers folder * replaced all SDK version calls to XCT cached one * removed unecessary space * Added a cache to the iOS version * [Bug] Fixed CameraView Shutter not responding (#1535) * Fixed CameraView Shutter not responding * Fixed Merge conflict * Update FormsCameraView.ios.cs Removed unnecessary code * Update FormsCameraView.ios.cs Co-authored-by: Andrei <andrei.misiukevich@gmail.com> Co-authored-by: Gerald Versluis <gerald@verslu.is> Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com> * Added Speed Property to mediaelement (#1570) * Added Speed control for MediaElement in iOS and Android * Added Update Speed inside Play Method so after pausing and playing speed will be remembered * Added Sample for speed * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Views/MediaElement/Android/MediaElementRenderer.android.cs Co-authored-by: Andrei <andrei.misiukevich@gmail.com> * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Views/MediaElement/Android/MediaElementRenderer.android.cs Co-authored-by: Andrei <andrei.misiukevich@gmail.com> * Changed Speed Property binding mode to oneway and removed un necessary property Speed from IMediaElementController * Added Speed control for MediaElement in iOS and Android * Changed Speed Property binding mode to oneway and removed un necessary property Speed from IMediaElementController Co-authored-by: Aswin P G <aswinpg@outlook.in> Co-authored-by: Andrei <andrei.misiukevich@gmail.com> * Utc to local string converter (#1555) * Added UtcDateTimeToLocalStringConverter with page to test. * Tests class added * Refactored Tests * Added some additional tests * Added new converter to the Converters gallery * Minor fixes * Code tidy. * Some passing test. * Resolves Error CS8625. * All tests passing * Suggest changes including: Moved BindableProperty to top of class. IsValidDateFormat uses DateTime.TryParse rather then DateTime.Parse. Removed is string type check for DateTimeFormat. * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Converters/UtcDateTimeToLocalStringConverter.shared.cs * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Converters/UtcDateTimeToLocalStringConverter.shared.cs * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Converters/UtcDateTimeToLocalStringConverter.shared.cs * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Converters/UtcDateTimeToLocalStringConverter.shared.cs * removed private from method Co-authored-by: Andrei <andrei.misiukevich@gmail.com> Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com> * Update RangeSlider.shared.cs (#1545) Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com> Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com> * Removed unused code (#1586) Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com> * [Enhancement][Converter] Add Expression property to MathExpressionConverter and MultiMathExpressionConverter (#1609) * Added Expression parameter * Fixed Expression property declaration * Updated sample page * Added Tests Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com> * [Bug] [XCT.Sample] Fixed ContentPages BackgroundColor (#1595) * Removed SetAppThemeColor * Move `BasePage` to `Pages` folder * Handle Null Dereferences introduced in .NET 6 Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com> Co-authored-by: Andrei <andrei.misiukevich@gmail.com> Co-authored-by: Brandon Minnick <13558917+brminnick@users.noreply.github.com> * CornerRadiusEffect (#1316) * CornerRadiusEffect added * cosmetics * Safe corner radius value impl * nullable fix * reduce to one linq call Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com> * Effect replaced by event subscription * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Effects/CornerRadius/CornerRadiusEffect.shared.cs * C#9 cleanup * removed extra ) * Update src/CommunityToolkit/Xamarin.CommunityToolkit/Effects/CornerRadius/CornerRadiusEffect.shared.cs Co-authored-by: Javier Suárez <javiersuarezruiz@hotmail.com> Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com> Co-authored-by: Andrei <andrei.misiukevich@gmail.com> Co-authored-by: Brandon Minnick <13558917+brminnick@users.noreply.github.com> * Update dotnet-format-daily.yml * MauiCompat Fix for preview 12 (#1792) * Fix for preview 12 * Allow Prerelease of .NET 6 * Add `--include-previews` to Install .NET MAUI Workload * Specify .NET v6.0.2 * Install Nightly .NET Build * Update azure-pipelines.yml * Update azure-pipelines.yml * Update azure-pipelines.yml * Update azure-pipelines.yml * Update azure-pipelines.yml * Update azure-pipelines.yml * Update azure-pipelines.yml * Update azure-pipelines.yml * dotnet install with script * Update azure-pipelines.yml * install using script * Update azure-pipelines.yml * set version * remove dir Co-authored-by: Brandon Minnick <13558917+brminnick@users.noreply.github.com> * Match Visual Studio 2022 .NET 6.0.2 Preview Version * Update azure-pipelines.yml Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Andrei <andrei.misiukevich@gmail.com> Co-authored-by: Gerald Versluis <gerald@verslu.is> Co-authored-by: Andrew Hoefling <andrewh@fileonq.com> Co-authored-by: Gustavo Oliveira <gu.ol@hotmail.com> Co-authored-by: Javier Suárez <javiersuarezruiz@hotmail.com> Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com> Co-authored-by: Vladislav Antonyuk <33021114+VladislavAntonyuk@users.noreply.github.com> Co-authored-by: Vladislav Antonyuk <vlad.antonyuk@outlook.com> Co-authored-by: Maksym Koshovyi <maximkoshevoi61@gmail.com> Co-authored-by: Daniel Christmas <1112585+justadaniel@users.noreply.github.com> Co-authored-by: Yuriy Holembyovskyy <yholembyovskyy@gmail.com> Co-authored-by: Yuriy Holembyovskyy <yuriy.holembyovskyy@gmail.com> Co-authored-by: Gustavo Oliveira <gustavo.oliveira@inspectrealestate.com.au> Co-authored-by: Aswin P G <aswinpg@outlook.in> Co-authored-by: Leonard <leojharris@hotmail.com> Co-authored-by: Yann Zahringer Ferrando <YZahringer@users.noreply.github.com>

VladislavAntonyuk changed the title ~~GesturePad initial commit~~ GesturePad Oct 19, 2020

VladislavAntonyuk marked this pull request as ready for review October 19, 2020 20:24

AndreiMisiukevich reviewed Oct 20, 2020

View reviewed changes

README.md Outdated Show resolved Hide resolved

pictos suggested changes Oct 20, 2020

View reviewed changes

VladislavAntonyuk changed the title ~~GesturePad~~ DrawingView Oct 21, 2020

VladislavAntonyuk requested review from jfversluis, pictos, AndreiMisiukevich and roubachof October 21, 2020 15:45

rookiejava reviewed Oct 22, 2020

View reviewed changes

XamarinCommunityToolkit/Views/DrawingView/Renderer/DrawingViewRenderer.tizen.cs Outdated Show resolved Hide resolved

rookiejava reviewed Oct 22, 2020

View reviewed changes

XamarinCommunityToolkit/Views/DrawingView/Renderer/DrawingViewRenderer.tizen.cs Outdated Show resolved Hide resolved

pictos suggested changes Oct 22, 2020

View reviewed changes

VladislavAntonyuk requested a review from pictos October 22, 2020 17:47

AndreiMisiukevich reviewed Oct 28, 2020

View reviewed changes

felipebaltazar reviewed Nov 15, 2020

View reviewed changes

XamarinCommunityToolkit/Views/DrawingView/DrawingView.shared.cs Outdated Show resolved Hide resolved

VladislavAntonyuk requested a review from AndreiMisiukevich November 20, 2020 20:20

VladislavAntonyuk commented Nov 20, 2020

View reviewed changes

XamarinCommunityToolkit/Views/SnackBar/Options/ToastOptions.shared.cs Outdated Show resolved Hide resolved

DrawingView control, samples, documentation

bbe7c4a

VladislavAntonyuk commented Nov 20, 2020

View reviewed changes

fix build issues

e678b8b

Merge branch 'main' into feature/vantonyuk-gesture-pad

078b0c6

pictos changed the base branch from main to drawingViewHolder November 22, 2020 23:46

pictos merged commit 8292f3b into xamarin:drawingViewHolder Nov 22, 2020

VladislavAntonyuk deleted the feature/vantonyuk-gesture-pad branch November 23, 2020 09:09

pictos mentioned this pull request Jan 10, 2021

Drawing View #740

Merged

5 tasks

DrawingView #468

DrawingView #468

Uh oh!

Conversation

VladislavAntonyuk commented Oct 19, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of Change

Bugs Fixed

Screenshots

PR Checklist

Uh oh!

Uh oh!

AndreiMisiukevich commented Oct 20, 2020

Uh oh!

pictos left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pictos Oct 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

VladislavAntonyuk Oct 21, 2020

Choose a reason for hiding this comment

Uh oh!

roubachof Oct 21, 2020

Choose a reason for hiding this comment

Uh oh!

jfversluis Oct 21, 2020

Choose a reason for hiding this comment

Uh oh!

VladislavAntonyuk Oct 21, 2020

Choose a reason for hiding this comment

Uh oh!

rookiejava Oct 22, 2020

Choose a reason for hiding this comment

Uh oh!

VladislavAntonyuk commented Oct 21, 2020

Uh oh!

Uh oh!

Uh oh!

pictos left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

VladislavAntonyuk commented Oct 22, 2020

Uh oh!

pictos commented Oct 22, 2020

Uh oh!

VladislavAntonyuk commented Oct 23, 2020

Uh oh!

VladislavAntonyuk commented Oct 23, 2020

Uh oh!

pictos commented Oct 25, 2020

Uh oh!

pictos commented Oct 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

VladislavAntonyuk commented Oct 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pictos commented Oct 29, 2020

Uh oh!

pictos commented Nov 2, 2020

Uh oh!

VladislavAntonyuk commented Oct 19, 2020 •

edited

Loading

pictos Oct 20, 2020 •

edited

Loading

pictos left a comment •

edited

Loading

pictos commented Oct 28, 2020 •

edited

Loading

VladislavAntonyuk commented Oct 28, 2020 •

edited

Loading