Skip to content
This repository was archived by the owner on May 1, 2024. It is now read-only.

added additional ctor to AccessibilityListener to avoid app crash #1924

Merged
merged 3 commits into from
Feb 11, 2023

Conversation

thisisthekap
Copy link
Contributor

@thisisthekap thisisthekap commented Oct 11, 2022

Description of Bug

Added additional ctor AccessibilityListener(IntPtr handle, JniHandleOwnership transfer) in order to fix #1923.

Issues Fixed

Behavioral Changes

None.

PR Checklist

  • Has a linked Issue, and the Issue has been approved
  • Has tests (if omitted, state reason in description)
  • Has samples (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Changes adhere to coding standard
  • Updated documentation

@pictos pictos added the DO-NOT-MERGE Don't merge it.... don't do it! Really... label Oct 11, 2022
@thisisthekap
Copy link
Contributor Author

@pictos Could you please share a link to the nugets created by the CI jobs? I want to use these nugets while waiting for the PR getting reviewed.

@thisisthekap
Copy link
Contributor Author

@thisisthekap
Copy link
Contributor Author

@pictos Are you able to provide a rough ETA when this PR is going to be reviewed?

@thisisthekap
Copy link
Contributor Author

@pictos The failing CI seems to be unrelated to my change.

@pictos pictos force-pushed the fix_1923_AccessibilityListener_ctor branch from 109f4f6 to 33c36af Compare November 22, 2022 01:46
@pictos pictos removed the DO-NOT-MERGE Don't merge it.... don't do it! Really... label Nov 22, 2022
Copy link
Contributor

@pictos pictos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thisisthekap thanks for this, and sorry for taking so long to review it!
We can merge it as soon the CI is green

@pictos pictos enabled auto-merge (squash) November 22, 2022 01:47
@thisisthekap
Copy link
Contributor Author

@pictos Thank you for the review. The failing CI seems to be unrelated to my change. When is the next (preview) release planned?

@thisisthekap
Copy link
Contributor Author

@pictos Any ETA on a new release including the approved changes?

@pictos
Copy link
Contributor

pictos commented Feb 9, 2023

@thisisthekap as soon as we fix our CI

@pictos pictos merged commit 3f5d7cd into xamarin:main Feb 11, 2023
@thisisthekap
Copy link
Contributor Author

@pictos When is this fix going to be released?

@pictos
Copy link
Contributor

pictos commented Apr 25, 2023

@thisisthekap I don't have a date for you right now. But should be soon-sh

@bijington
Copy link
Contributor

@thisisthekap there was a release (https://github.com/xamarin/XamarinCommunityToolkit/releases/tag/2.0.6) a few days ago that should include this fix.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants