-
Notifications
You must be signed in to change notification settings - Fork 457
added additional ctor to AccessibilityListener to avoid app crash #1924
added additional ctor to AccessibilityListener to avoid app crash #1924
Conversation
@pictos Could you please share a link to the nugets created by the CI jobs? I want to use these nugets while waiting for the PR getting reviewed. |
@pictos Are you able to provide a rough ETA when this PR is going to be reviewed? |
@pictos The failing CI seems to be unrelated to my change. |
109f4f6
to
33c36af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thisisthekap thanks for this, and sorry for taking so long to review it!
We can merge it as soon the CI is green
@pictos Thank you for the review. The failing CI seems to be unrelated to my change. When is the next (preview) release planned? |
@pictos Any ETA on a new release including the approved changes? |
@thisisthekap as soon as we fix our CI |
@pictos When is this fix going to be released? |
@thisisthekap I don't have a date for you right now. But should be soon-sh |
@thisisthekap there was a release (https://github.com/xamarin/XamarinCommunityToolkit/releases/tag/2.0.6) a few days ago that should include this fix. |
Description of Bug
Added additional ctor
AccessibilityListener(IntPtr handle, JniHandleOwnership transfer)
in order to fix #1923.Issues Fixed
Behavioral Changes
None.
PR Checklist
approved