This repository was archived by the owner on May 1, 2024. It is now read-only.
Nullable fixes in DrawingView #1817
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VladislavAntonyuk
requested review from
TheCodeTraveler,
bijington and
pictos
bijington
reviewed
Feb 22, 2022
...munityToolkit/Xamarin.CommunityToolkit/Views/DrawingView/Renderer/DrawingViewRenderer.gtk.cs
Outdated
Show resolved
Hide resolved
bijington
reviewed
Feb 22, 2022
...nityToolkit/Xamarin.CommunityToolkit/Views/DrawingView/Renderer/DrawingViewRenderer.tizen.cs
Show resolved
Hide resolved
|
Thanks @VladislavAntonyuk my comments may well be my not understanding how the |
bijington
approved these changes
Feb 23, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Bug
Remove null-forgiving operator in drawing view.
I am not able to deploy the app to android device with VS 17.2, I was not able to test it on Android.
It works fine on UWP, WPF
Issues Fixed
Behavioral Changes
PR Checklist
approved