This repository was archived by the owner on May 1, 2024. It is now read-only.
Fix NRE for a11y semantic heading #1728
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hello @rachelkang , does the NRE happen only on UWP? |
@VladislavAntonyuk yep, this is only an issue on UWP! |
pictos
approved these changes
Nov 24, 2021
VladislavAntonyuk
approved these changes
Nov 24, 2021
|
Thanks @rachelkang! And thanks @pictos and @VladislavAntonyuk for the quick review!!! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Bug
Null views were getting passed into the semantic heading, causing an NRE to get thrown and crashing.
Added a null check to account for this
Behavioral Changes
App will no longer crash if one attempts to set a semantic heading on a null view
PR Checklist
approved