[Bug] [Fixed] #1712

[rxDietel]

Description of Bug

src/CommunityToolkit/Xamarin.CommunityToolkit/Views/Popup/UWP/PopupRenderer.uwp.cs
Call OnClosing even if no LightDismiss enabled
OnClosing won't let the PopUp close if the Close wasn't triggered by dismiss.

Issues Fixed

• Fixes [Bug] UWP PopUp LightDissmis disable not working as expected #1712

Annotations

Documentation: Created issue that documentation for Popup is missing
Tests: No test created, Change is only in the reaction of the UWP UI

PR Checklist

• Has a linked Issue, and the Issue has been approved
• Has tests (if omitted, state reason in description)
• Has samples (if omitted, state reason in description)
• Rebased on top of main at time of PR
• Changes adhere to coding standard
• Updated documentation

[TheCodeTraveler]

Thanks! Could you add Unit Tests and a reproduction in the Sample App?

[ghost]

All CLA requirements met.

[rxDietel]

Just modified the already existing Sample for the light dismiss Popup in the project.
I can't find a usefull thing to unittest the popup, because it would need a UI Test to confirm the changes.

[bijington]

this is on my queue to review I just need to fix my VM to checkout the code and confirm it

[bijington]

Looks good to me! Thank you for this