Skip to content
This repository was archived by the owner on May 1, 2024. It is now read-only.

Update MauiCompatSteps, MauiCompat script #1683

Merged
merged 8 commits into from
Nov 25, 2021
Merged

Update MauiCompatSteps, MauiCompat script #1683

merged 8 commits into from
Nov 25, 2021

Conversation

VladislavAntonyuk
Copy link
Contributor

@VladislavAntonyuk VladislavAntonyuk commented Oct 23, 2021

Description of Bug

Added MauiCompat script, updated instruction (Maui preview9) to build Compat package

Issues Fixed

PR Checklist

  • Has a linked Issue, and the Issue has been approved
  • Has tests (if omitted, state reason in description)
  • Has samples (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Changes adhere to coding standard

@VladislavAntonyuk
Copy link
Contributor Author

@brminnick should I include generated file in the PR?

@TheCodeTraveler
Copy link
Contributor

Nope, we'll automatically generate the files branched off of each Release tag

@maxkoshevoi
Copy link
Contributor

@jfversluis @brminnick @pictos Is there any ETA on this pr?

@TheCodeTraveler
Copy link
Contributor

Yup!

Our plan is to release Xamarin.CommunityToolkit v1.3.0 in the next few days.

Once that Release tag has been created, I'll create Xamarin.CommunityToolkit.MauiCompat v1.3.0 using the updated steps in this PR. If everything works, we'll merge the PR!

@maxkoshevoi
Copy link
Contributor

@brminnick Sounds great! Could you please also address #1645 in the 1.3.0 MauiCompat release?
I wanted to create a PR myself, but current MauiCompat code fails to build with latest MAUI preview, so I'm unable to validate that adding .net6 won't break the build.

@TheCodeTraveler
Copy link
Contributor

Of course!

@VladislavAntonyuk
Copy link
Contributor Author

@maxkoshevoi Unfortunately, it is not included in this PR. Adding net6.0 cause a lot of build issues and require manual changes.
In most cases we need to wrap shared code with #if !Android && !iOS.

@maxkoshevoi
Copy link
Contributor

maxkoshevoi commented Oct 29, 2021

Unfortunately, it is not included in this PR

I know. I meant there should be another PR after this one that addresses #1645

Adding net6.0 cause a lot of build issues and require manual changes. In most cases we need to wrap shared code with #if !Android && !iOS.

That's strange. XCT supported platform-agnistic build targets (line .netstandard), so in theory it also should be able to support .net6.0. In any case, users should be able to include MauiCompat toolkit in pratform-agnostic projects, since they were able to do it with XCT (and are able to do it with MauiToolkit, and Maui itself).

@TheCodeTraveler TheCodeTraveler linked an issue Nov 11, 2021 that may be closed by this pull request
@TheCodeTraveler
Copy link
Contributor

Thanks @VladislavAntonyuk!! 🙌

@VladislavAntonyuk
Copy link
Contributor Author

@brminnick could you please reapprove it?

@TheCodeTraveler TheCodeTraveler merged commit f3f1a80 into xamarin:main Nov 25, 2021
@VladislavAntonyuk VladislavAntonyuk deleted the maui-compat branch November 25, 2021 07:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Unable to build MauiCompat project with MAUI Preview 9 [MauiCompat] Add .net6 support
4 participants