This repository was archived by the owner on May 1, 2024. It is now read-only.
Fixed drawing outside of DrawingView control #1680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VladislavAntonyuk
suggested changes
Oct 24, 2021
...tyToolkit/Xamarin.CommunityToolkit/Views/DrawingView/Renderer/DrawingViewRenderer.android.cs
Outdated
Show resolved
Hide resolved
ghost
deleted a comment from
|
Thanks! Can you add Unit Tests and a reproduction to the Sample App? |
|
|
samples/XCT.Sample.Android/Xamarin.CommunityToolkit.Sample.Android.csproj
Show resolved
Hide resolved
pictos
reviewed
Dec 9, 2021
...tyToolkit/Xamarin.CommunityToolkit/Views/DrawingView/Renderer/DrawingViewRenderer.android.cs
Show resolved
Hide resolved
VladislavAntonyuk
approved these changes
Dec 10, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Bug
Fixed the bug on Android where it was possible to draw outside of the DrawingView control.
It's not possible anymore to draw outside of the control:
Issues Fixed
PR Checklist
approved