This repository was archived by the owner on May 1, 2024. It is now read-only.
Fixing Popup Uwp Release Compilation Crash #1303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/CommunityToolkit/Xamarin.CommunityToolkit/Extensions/Navigation/NavigationExtensions.uwp.cs
Outdated
Show resolved
Hide resolved
Simplyfy workaround
|
@AndreiMisiukevich I changed it as in Xamarin.Forms. it looks now cleaner. |
src/CommunityToolkit/Xamarin.CommunityToolkit/Extensions/Navigation/NavigationExtensions.uwp.cs
Outdated
Show resolved
Hide resolved
…ation/NavigationExtensions.uwp.cs
AndreiMisiukevich
previously approved these changes
May 18, 2021
|
for me it looks good. But I can't test on UWP |
SkyeHoefling
previously approved these changes
Jun 7, 2021
There was a problem hiding this comment.
The code looks good to me but we need to certify the following works
- XCT Samples Project displays popups for UWP in release mode
- The https://github.com/ahoefling/XCT-Popups-Samples solution displays popups correctly when using the nightly nuget generated from this PR
I can confirm that XCT Samples Project in this repo is working after cloning this branch. I still need to test the other project.
5 tasks
|
@jfversluis Can this be merged? Without this UWP Store Apps won't work with Popup. |
Opps, I misread the original post. It would be great if this fix was merged. I am using a previous workaround to issue #1251 (1.1.0-preview2508) and I would love to get back on the main release again. |
inforithmics
dismissed stale reviews from SkyeHoefling and AndreiMisiukevich
via
f4f0212
TheCodeTraveler
approved these changes
Nov 11, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Changes the NavigationExtensions.uwp.cs to avoid a UWP Native Compilation Bug.
Bugs Fixed
API Changes
None
Behavioral Changes
Native Compiled UWP Apps Work with Popups
PR Checklist
Has a linked Issue, and the Issue has been
approvedHas tests (if omitted, state reason in description)
Bug only happens during Release can be reproduced by changing compilation to Release in Samples project and execute
the Popup samples.
Has samples (if omitted, state reason in description)
Has already Popup samples.
Rebased on top of main at time of PR
Changes adhere to coding standard
Updated documentation
Is only a Bug fix.