This repository was archived by the owner on May 1, 2024. It is now read-only.
[windows] fix for when $(VsInstallRoot) is missing a trailing slash #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usage of Xamarin.Legacy.Sdk on xamarin-android's CI fails with:
error MSB4057: The target "_GetRestoreSettingsPerFramework" does not exist in the project.
Reviewing the build logs, `Xamarin.Android.CSharp.targets` fails to be
imported at all due to:
_LegacyExtensionsPath = C:\Program Files (x86)\Microsoft Visual Studio\2019\EnterpriseMSBuild
It appears that if either `%VSINSTALLDIR%` or `$(VsInstallRoot)` were
missing a trailing slash, then `$(_LegacyExtensionsPath)` would be
incorrect.
First I added a new `samples/tests` folder, to start throwing in
one-off projects as pseudo-unit tests. Or maybe integration tests is a
better term? `dotnet build samples.sln` should be the equivalent of
running tests in this repo.
Next, I moved the `$(VsInstallRoot)` logic to its own
`Xamarin.VsInstallRoot.targets` file to be shared between iOS and
Android.
Lastly, I added the appropriate `EnsureTrailingSlash()` call:
https://docs.microsoft.com/visualstudio/msbuild/property-functions#msbuild-ensuretrailingslash
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage of Xamarin.Legacy.Sdk on xamarin-android's CI fails with:
Reviewing the build logs,
Xamarin.Android.CSharp.targetsfails to beimported at all due to:
It appears that if either
%VSINSTALLDIR%or$(VsInstallRoot)weremissing a trailing slash, then
$(_LegacyExtensionsPath)would beincorrect.
First I added a new
samples/testsfolder, to start throwing inone-off projects as pseudo-unit tests. Or maybe integration tests is a
better term?
dotnet build samples.slnshould be the equivalent ofrunning tests in this repo.
Next, I moved the
$(VsInstallRoot)logic to its ownXamarin.VsInstallRoot.targetsfile to be shared between iOS andAndroid.
Lastly, I added the appropriate
EnsureTrailingSlash()call:https://docs.microsoft.com/visualstudio/msbuild/property-functions#msbuild-ensuretrailingslash