This repository was archived by the owner on May 1, 2024. It is now read-only.
[android] guard against accidental \**\* wildcards
#49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: dotnet/android#7837 Context: #46 I ended up making this change in xamarin-android to avoid a potential issue in all .NET projects, so bringing it here as well. In cases where the `android` workload is not installed, Xamarin.Legacy.Sdk can accidentally wildcard your entire disk: MSBUILD : warning MSB5029: The value “\**\.*\**” of the “Exclude” attribute in element <ItemGroup> in file “/Users/moljac/.nuget/packages/xamarin.legacy.sdk/0.2.0-alpha2/Sdk/AutoImport.Android.props (26,61)” is a wildcard that results in enumerating all files on the drive, which was likely not intended. Check that referenced properties are always defined. Add checks that `$(MonoAndroidAssetsPrefix)` and `$(MonoAndroidResourcePrefix)` are not blank.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: dotnet/android#7837
Context: #46
I ended up making this change in xamarin-android to avoid a potential issue in all .NET projects, so bringing it here as well.
In cases where the
androidworkload is not installed, Xamarin.Legacy.Sdk can accidentally wildcard your entire disk:Add checks that
$(MonoAndroidAssetsPrefix)and$(MonoAndroidResourcePrefix)are not blank.