This repository was archived by the owner on May 1, 2024. It is now read-only.
[Android] add support for AutoImport.props across .NET versions #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: dotnet/android#7023 In order to support `AutoImport.props` across multiple versions of the Android workload in .NET 6 and .NET 7, we have to condition `AutoImport.props` behind: Condition=" '$(TargetPlatformIdentifier)' == 'android' and $([MSBuild]::VersionEquals($(TargetFrameworkVersion), '6.0')) ..." Condition=" '$(TargetPlatformIdentifier)' == 'android' and $([MSBuild]::VersionEquals($(TargetFrameworkVersion), '7.0')) ..." This breaks `Xamarin.Legacy.Sdk`, as a `monoandroid12` application would have `$(TargetFrameworkVersion)` set to `v12.0`. The only sensible way to workaround this is to provide an Android `AutoImport.props` in Xamarin.Legacy.Sdk. We need to do this, because xamarin/AndroidX builds using Xamarin.Legacy.Sdk. TBD what happens for iOS and macOS, as they have not implemented the `Condition` in `AutoImport.props` yet in the xamarin-macios repo.
jonathanpeppers
force-pushed
the
AutoImport.Android.props
branch
from
3d772f2 to
2257252
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: dotnet/android#7023
In order to support
AutoImport.propsacross multiple versions of theAndroid workload in .NET 6 and .NET 7, we have to condition
AutoImport.propsbehind:This breaks
Xamarin.Legacy.Sdk, as amonoandroid12applicationwould have
$(TargetFrameworkVersion)set tov12.0.The only sensible way to workaround this is to provide an Android
AutoImport.propsin Xamarin.Legacy.Sdk. We need to do this, becausexamarin/AndroidX builds using Xamarin.Legacy.Sdk.
TBD what happens for iOS and macOS, as they have not implemented the
ConditioninAutoImport.propsyet in the xamarin-macios repo.