Bump to .NET 6 stable #32

mfkl · 2021-11-24T06:46:27Z

No description provided.

mfkl · 2021-11-24T07:03:53Z

I'm HTTP 401 to access the CI build logs, but my guess is the samples don't build because of #33, or did I mess up somewhere else?

jonathanpeppers · 2021-11-24T23:19:56Z

There is some failure in the iOS workload:

C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Xamarin\iOS\Xamarin.Messaging.Build.targets(79,3): error MSB4018: The "GenerateBuildSessionId" task failed unexpectedly. [D:\a\1\s\samples\Hello\Hello.csproj]
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Xamarin\iOS\Xamarin.Messaging.Build.targets(79,3): error MSB4018: System.TypeLoadException: Method 'Trace' in type 'NullTracer' from assembly 'Xamarin.iOS.Tasks, Version=0.0.0.0, Culture=neutral, PublicKeyToken=null' does not have an implementation. [D:\a\1\s\samples\Hello\Hello.csproj]
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Xamarin\iOS\Xamarin.Messaging.Build.targets(79,3): error MSB4018:    at Xamarin.Messaging.Build.Client.BuildTracerManager..ctor() [D:\a\1\s\samples\Hello\Hello.csproj]
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Xamarin\iOS\Xamarin.Messaging.Build.targets(79,3): error MSB4018:    at Xamarin.Messaging.Build.Client.BuildTracerManager.get_Instance() in D:\a\_work\1\s\src\MSBuild\Xamarin.Messaging.Build.Client\BuildTracerManager.cs:line 23 [D:\a\1\s\samples\Hello\Hello.csproj]
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Xamarin\iOS\Xamarin.Messaging.Build.targets(79,3): error MSB4018:    at Xamarin.Messaging.Build.Client.MessagingBuildContext.SetupTracing() in D:\a\_work\1\s\src\MSBuild\Xamarin.Messaging.Build.Client\MessagingBuildContext.cs:line 49 [D:\a\1\s\samples\Hello\Hello.csproj]
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Xamarin\iOS\Xamarin.Messaging.Build.targets(79,3): error MSB4018:    at Xamarin.Messaging.Build.Client.MessagingBuildContext.Initialize(String version) in D:\a\_work\1\s\src\MSBuild\Xamarin.Messaging.Build.Client\MessagingBuildContext.cs:line 15 [D:\a\1\s\samples\Hello\Hello.csproj]
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Xamarin\iOS\Xamarin.Messaging.Build.targets(79,3): error MSB4018:    at Xamarin.Messaging.Build.Client.Tasks.GenerateBuildSessionId.Execute() in D:\a\_work\1\s\src\MSBuild\Xamarin.Messaging.Build.Client\Tasks\GenerateBuildSessionId.cs:line 26 [D:\a\1\s\samples\Hello\Hello.csproj]
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Xamarin\iOS\Xamarin.Messaging.Build.targets(79,3): error MSB4018:    at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute() [D:\a\1\s\samples\Hello\Hello.csproj]
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Xamarin\iOS\Xamarin.Messaging.Build.targets(79,3): error MSB4018:    at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask(ITaskExecutionHost taskExecutionHost, TaskLoggingContext taskLoggingContext, TaskHost taskHost, ItemBucket bucket, TaskExecutionMode howToExecuteTask) [D:\a\1\s\samples\Hello\Hello.csproj]
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Xamarin\iOS\Xamarin.Messaging.Build.targets(79,3): error MSB4018: The "GenerateBuildSessionId" task failed unexpectedly. [D:\a\1\s\samples\tests\VsInstallRoot\VsInstallRoot.csproj]
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Xamarin\iOS\Xamarin.Messaging.Build.targets(79,3): error MSB4018: System.TypeLoadException: Method 'Trace' in type 'NullTracer' from assembly 'Xamarin.iOS.Tasks, Version=0.0.0.0, Culture=neutral, PublicKeyToken=null' does not have an implementation. [D:\a\1\s\samples\tests\VsInstallRoot\VsInstallRoot.csproj]
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Xamarin\iOS\Xamarin.Messaging.Build.targets(79,3): error MSB4018:    at Xamarin.Messaging.Build.Client.BuildTracerManager..ctor() [D:\a\1\s\samples\tests\VsInstallRoot\VsInstallRoot.csproj]
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Xamarin\iOS\Xamarin.Messaging.Build.targets(79,3): error MSB4018:    at Xamarin.Messaging.Build.Client.BuildTracerManager.get_Instance() in D:\a\_work\1\s\src\MSBuild\Xamarin.Messaging.Build.Client\BuildTracerManager.cs:line 23 [D:\a\1\s\samples\tests\VsInstallRoot\VsInstallRoot.csproj]
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Xamarin\iOS\Xamarin.Messaging.Build.targets(79,3): error MSB4018:    at Xamarin.Messaging.Build.Client.MessagingBuildContext.SetupTracing() in D:\a\_work\1\s\src\MSBuild\Xamarin.Messaging.Build.Client\MessagingBuildContext.cs:line 49 [D:\a\1\s\samples\tests\VsInstallRoot\VsInstallRoot.csproj]
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Xamarin\iOS\Xamarin.Messaging.Build.targets(79,3): error MSB4018:    at Xamarin.Messaging.Build.Client.MessagingBuildContext.Initialize(String version) in D:\a\_work\1\s\src\MSBuild\Xamarin.Messaging.Build.Client\MessagingBuildContext.cs:line 15 [D:\a\1\s\samples\tests\VsInstallRoot\VsInstallRoot.csproj]
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Xamarin\iOS\Xamarin.Messaging.Build.targets(79,3): error MSB4018:    at Xamarin.Messaging.Build.Client.Tasks.GenerateBuildSessionId.Execute() in D:\a\_work\1\s\src\MSBuild\Xamarin.Messaging.Build.Client\Tasks\GenerateBuildSessionId.cs:line 26 [D:\a\1\s\samples\tests\VsInstallRoot\VsInstallRoot.csproj]
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Xamarin\iOS\Xamarin.Messaging.Build.targets(79,3): error MSB4018:    at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute() [D:\a\1\s\samples\tests\VsInstallRoot\VsInstallRoot.csproj]
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Xamarin\iOS\Xamarin.Messaging.Build.targets(79,3): error MSB4018:    at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask(ITaskExecutionHost taskExecutionHost, TaskLoggingContext taskLoggingContext, TaskHost taskHost, ItemBucket bucket, TaskExecutionMode howToExecuteTask) [D:\a\1\s\samples\tests\VsInstallRoot\VsInstallRoot.csproj]

We're using Xamarin.Legacy.Sdk + .NET 6 GA, in AndroidX and Google Play Services bindings...

Maybe there is something I can do to work around the iOS issue.

Context: https://docs.microsoft.com/azure/devops/pipelines/agents/hosted?view=azure-devops&tabs=yaml

* Install .NET 6 GA * Xcode 13.1 is default now: actions/runner-images#4355

$(SupportedOSPlatformVersion) should be 10.14

Fixes: D:\a\1\s\samples\Hello\Hello.csproj error MSB4057: The target "_GetRestoreSettingsPerFramework" does not exist in the project.

jonathanpeppers · 2021-11-29T21:00:27Z

src/Xamarin.Legacy.Sdk/Sdk/Sdk.props

+  <!--
+    HACK: declare a _GetRestoreSettingsPerFramework target that some versions of NuGet expect to exist.
+    This target should get replaced by NuGet.targets if needed:
+    https://github.com/NuGet/NuGet.Client/blob/914cacea77660b8758014912ee127c82469ac1d9/src/NuGet.Core/NuGet.Build.Tasks/NuGet.targets#L635-L651
+  -->
+  <Target Name="_GetRestoreSettingsPerFramework" Returns="@(_RestoreSettingsPerFramework)">
+    <ItemGroup>
+      <_RestoreSettingsPerFramework Include="$([System.Guid]::NewGuid())">
+        <RestoreAdditionalProjectSources>$(RestoreAdditionalProjectSources)</RestoreAdditionalProjectSources>
+        <RestoreAdditionalProjectFallbackFolders>$(RestoreAdditionalProjectFallbackFolders)</RestoreAdditionalProjectFallbackFolders>
+        <RestoreAdditionalProjectFallbackFoldersExcludes>$(RestoreAdditionalProjectFallbackFoldersExcludes)</RestoreAdditionalProjectFallbackFoldersExcludes>
+      </_RestoreSettingsPerFramework>
+    </ItemGroup>
+  </Target>


@mfkl adding this solved one issue, were you getting errors about this target missing?

After adding this, I hit a new missing target, which is too large to replicate in this project:

https://github.com/NuGet/NuGet.Client/blob/914cacea77660b8758014912ee127c82469ac1d9/src/NuGet.Core/NuGet.Build.Tasks/NuGet.targets#L856-L863

I think these were very late changes to improve no-op restore performance in NuGet in .NET 6.

Need to think on this one...

Ok remembering now... This needs to be updated for VS 2022:

Xamarin.Legacy.Sdk/src/Xamarin.Legacy.Sdk/Sdk/Xamarin.VsInstallRoot.targets

Lines 6 to 7 in 4ba5930

<VsInstallRoot Condition=" '$(VsInstallRoot)' == '' and Exists ('$(MSBuildProgramFiles32)/Microsoft Visual Studio/2019/Preview/') ">$(MSBuildProgramFiles32)/Microsoft Visual Studio/2019/Preview/</VsInstallRoot>

<VsInstallRoot Condition=" '$(VsInstallRoot)' == '' ">$(MSBuildProgramFiles32)/Microsoft Visual Studio/2019/Enterprise/</VsInstallRoot>

This reverts commit 81dbd0d.

jonathanpeppers · 2021-11-29T22:57:15Z

This is now hitting a new iOS error:

C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Xamarin\iOS\Xamarin.Messaging.Build.targets(79,3): error MSB4018: The "GenerateBuildSessionId" task failed unexpectedly. [D:\a\1\s\samples\Hello\Hello.csproj]
C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Xamarin\iOS\Xamarin.Messaging.Build.targets(79,3): error MSB4018: System.TypeLoadException: Method 'Trace' in type 'NullTracer' from assembly 'Xamarin.iOS.Tasks, Version=15.2.0.17, Culture=neutral, PublicKeyToken=84e04ff9cfb79065' does not have an implementation. [D:\a\1\s\samples\Hello\Hello.csproj]
C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Xamarin\iOS\Xamarin.Messaging.Build.targets(79,3): error MSB4018:    at Xamarin.Messaging.Build.Client.BuildTracerManager..ctor() [D:\a\1\s\samples\Hello\Hello.csproj]
C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Xamarin\iOS\Xamarin.Messaging.Build.targets(79,3): error MSB4018:    at Xamarin.Messaging.Build.Client.BuildTracerManager.get_Instance() in D:\a\_work\1\s\src\MSBuild\Xamarin.Messaging.Build.Client\BuildTracerManager.cs:line 23 [D:\a\1\s\samples\Hello\Hello.csproj]
C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Xamarin\iOS\Xamarin.Messaging.Build.targets(79,3): error MSB4018:    at Xamarin.Messaging.Build.Client.MessagingBuildContext.SetupTracing() in D:\a\_work\1\s\src\MSBuild\Xamarin.Messaging.Build.Client\MessagingBuildContext.cs:line 49 [D:\a\1\s\samples\Hello\Hello.csproj]
C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Xamarin\iOS\Xamarin.Messaging.Build.targets(79,3): error MSB4018:    at Xamarin.Messaging.Build.Client.MessagingBuildContext.Initialize(String version) in D:\a\_work\1\s\src\MSBuild\Xamarin.Messaging.Build.Client\MessagingBuildContext.cs:line 15 [D:\a\1\s\samples\Hello\Hello.csproj]
C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Xamarin\iOS\Xamarin.Messaging.Build.targets(79,3): error MSB4018:    at Xamarin.Messaging.Build.Client.Tasks.GenerateBuildSessionId.Execute() in D:\a\_work\1\s\src\MSBuild\Xamarin.Messaging.Build.Client\Tasks\GenerateBuildSessionId.cs:line 26 [D:\a\1\s\samples\Hello\Hello.csproj]
C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Xamarin\iOS\Xamarin.Messaging.Build.targets(79,3): error MSB4018:    at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute() [D:\a\1\s\samples\Hello\Hello.csproj]
C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Xamarin\iOS\Xamarin.Messaging.Build.targets(79,3): error MSB4018:    at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask(ITaskExecutionHost taskExecutionHost, TaskLoggingContext taskLoggingContext, TaskHost taskHost, ItemBucket bucket, TaskExecutionMode howToExecuteTask) [D:\a\1\s\samples\Hello\Hello.csproj]
C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Xamarin\iOS\Xamarin.Messaging.Build.targets(79,3): error MSB4018: The "GenerateBuildSessionId" task failed unexpectedly. [D:\a\1\s\samples\tests\VsInstallRoot\VsInstallRoot.csproj]
C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Xamarin\iOS\Xamarin.Messaging.Build.targets(79,3): error MSB4018: System.TypeLoadException: Method 'Trace' in type 'NullTracer' from assembly 'Xamarin.iOS.Tasks, Version=15.2.0.17, Culture=neutral, PublicKeyToken=84e04ff9cfb79065' does not have an implementation. [D:\a\1\s\samples\tests\VsInstallRoot\VsInstallRoot.csproj]
C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Xamarin\iOS\Xamarin.Messaging.Build.targets(79,3): error MSB4018:    at Xamarin.Messaging.Build.Client.BuildTracerManager..ctor() [D:\a\1\s\samples\tests\VsInstallRoot\VsInstallRoot.csproj]
C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Xamarin\iOS\Xamarin.Messaging.Build.targets(79,3): error MSB4018:    at Xamarin.Messaging.Build.Client.BuildTracerManager.get_Instance() in D:\a\_work\1\s\src\MSBuild\Xamarin.Messaging.Build.Client\BuildTracerManager.cs:line 23 [D:\a\1\s\samples\tests\VsInstallRoot\VsInstallRoot.csproj]
C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Xamarin\iOS\Xamarin.Messaging.Build.targets(79,3): error MSB4018:    at Xamarin.Messaging.Build.Client.MessagingBuildContext.SetupTracing() in D:\a\_work\1\s\src\MSBuild\Xamarin.Messaging.Build.Client\MessagingBuildContext.cs:line 49 [D:\a\1\s\samples\tests\VsInstallRoot\VsInstallRoot.csproj]
C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Xamarin\iOS\Xamarin.Messaging.Build.targets(79,3): error MSB4018:    at Xamarin.Messaging.Build.Client.MessagingBuildContext.Initialize(String version) in D:\a\_work\1\s\src\MSBuild\Xamarin.Messaging.Build.Client\MessagingBuildContext.cs:line 15 [D:\a\1\s\samples\tests\VsInstallRoot\VsInstallRoot.csproj]
C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Xamarin\iOS\Xamarin.Messaging.Build.targets(79,3): error MSB4018:    at Xamarin.Messaging.Build.Client.Tasks.GenerateBuildSessionId.Execute() in D:\a\_work\1\s\src\MSBuild\Xamarin.Messaging.Build.Client\Tasks\GenerateBuildSessionId.cs:line 26 [D:\a\1\s\samples\tests\VsInstallRoot\VsInstallRoot.csproj]
C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Xamarin\iOS\Xamarin.Messaging.Build.targets(79,3): error MSB4018:    at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute() [D:\a\1\s\samples\tests\VsInstallRoot\VsInstallRoot.csproj]
C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Xamarin\iOS\Xamarin.Messaging.Build.targets(79,3): error MSB4018:    at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask(ITaskExecutionHost taskExecutionHost, TaskLoggingContext taskLoggingContext, TaskHost taskHost, ItemBucket bucket, TaskExecutionMode howToExecuteTask) [D:\a\1\s\samples\tests\VsInstallRoot\VsInstallRoot.csproj]

This reverts commit 8176afc.

This solves an assembly-load error at build time.

mfkl · 2021-12-01T01:55:04Z

Good job!

Bump to .NET 6 stable

d0a4176

jonathanpeppers added 5 commits November 29, 2021 13:11

Bump to windows-2022 image

ce18bea

Context: https://docs.microsoft.com/azure/devops/pipelines/agents/hosted?view=azure-devops&tabs=yaml

Update Github actions

8824c3e

* Install .NET 6 GA * Xcode 13.1 is default now: actions/runner-images#4355

Use nuget.org instead of dotnet6 feed

ec8dfcf

Update HelloMac.csproj

afbe57b

$(SupportedOSPlatformVersion) should be 10.14

Add HACK for NuGet.targets

81dbd0d

Fixes: D:\a\1\s\samples\Hello\Hello.csproj error MSB4057: The target "_GetRestoreSettingsPerFramework" does not exist in the project.

jonathanpeppers reviewed Nov 29, 2021

View reviewed changes

jonathanpeppers added 2 commits November 29, 2021 16:01

Revert "Add HACK for NuGet.targets"

0592a3f

This reverts commit 81dbd0d.

VS 2022 paths

0387403

jonathanpeppers added 3 commits November 29, 2021 22:51

Install newer Xamarin.VisualStudio.Apple.Sdk.vsix

8176afc

Revert "Install newer Xamarin.VisualStudio.Apple.Sdk.vsix"

bfb4c03

This reverts commit 8176afc.

[ios] patch $(MessagingBuildClientAssemblyFile)

e25b02d

This solves an assembly-load error at build time.

jonathanpeppers merged commit 478d486 into xamarin:main Nov 30, 2021

mfkl deleted the net6-stable branch December 1, 2021 01:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Bump to .NET 6 stable #32

Bump to .NET 6 stable #32

Uh oh!

mfkl commented Nov 24, 2021

Uh oh!

mfkl commented Nov 24, 2021

Uh oh!

jonathanpeppers commented Nov 24, 2021

Uh oh!

jonathanpeppers Nov 29, 2021

Uh oh!

jonathanpeppers Nov 29, 2021

Uh oh!

jonathanpeppers commented Nov 29, 2021

Uh oh!

mfkl commented Dec 1, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	<VsInstallRoot Condition=" '$(VsInstallRoot)' == '' and Exists ('$(MSBuildProgramFiles32)/Microsoft Visual Studio/2019/Preview/') ">$(MSBuildProgramFiles32)/Microsoft Visual Studio/2019/Preview/</VsInstallRoot>
	<VsInstallRoot Condition=" '$(VsInstallRoot)' == '' ">$(MSBuildProgramFiles32)/Microsoft Visual Studio/2019/Enterprise/</VsInstallRoot>

Bump to .NET 6 stable #32

Bump to .NET 6 stable #32

Uh oh!

Conversation

mfkl commented Nov 24, 2021

Uh oh!

mfkl commented Nov 24, 2021

Uh oh!

jonathanpeppers commented Nov 24, 2021

Uh oh!

jonathanpeppers Nov 29, 2021

Choose a reason for hiding this comment

Uh oh!

jonathanpeppers Nov 29, 2021

Choose a reason for hiding this comment

Uh oh!

jonathanpeppers commented Nov 29, 2021

Uh oh!

mfkl commented Dec 1, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants