Add macOS support #20

filipnavara · 2021-06-21T08:40:00Z

Gets the basics working. It's missing the default items and I haven't been able to fix that but that's already missing on iOS.

jonathanpeppers · 2021-06-21T14:49:31Z

Let me open a different PR to see if this is happening with main:

  C:\Program Files\dotnet\packs\Microsoft.iOS.Windows.Sdk\14.5.100-preview.4.638\tools\msbuild\iOS\Xamarin.Messaging.Build.targets(109,7): error MSB4064: The "ServerPort" parameter is not supported by the "SayHello" task loaded from assembly: Xamarin.iOS.Tasks, Version=0.0.0.0, Culture=neutral, PublicKeyToken=null from the path: C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Xamarin\iOS\Xamarin.iOS.Tasks.dll. Verify that the parameter exists on the task, the <UsingTask> points to the correct assembly, and it is a settable public instance property. [D:\a\1\s\samples\tests\VsInstallRoot\VsInstallRoot.csproj]
  C:\Program Files\dotnet\packs\Microsoft.iOS.Windows.Sdk\14.5.100-preview.4.638\tools\msbuild\iOS\Xamarin.Messaging.Build.targets(107,3): error MSB4063: The "SayHello" task could not be initialized with its input parameters.  [D:\a\1\s\samples\tests\VsInstallRoot\VsInstallRoot.csproj]

filipnavara · 2021-06-21T14:51:26Z

The test failures seemed unrelated but would be nice to fix. Default item inclusion will be unblocked by dotnet/macios#11991.

jonathanpeppers · 2021-06-30T21:22:16Z

/azp run

azure-pipelines · 2021-06-30T21:22:42Z

Azure Pipelines successfully started running 1 pipeline(s).

jonathanpeppers · 2021-07-01T00:40:07Z

@filipnavara sorry for the delay, it's been busy for me lately.

If this is green, do you think it's working enough to merge?

We probably shouldn't add this to `samples.sln`, because it would fail CI phases on Windows.

filipnavara · 2021-07-01T06:05:31Z

If this is green, do you think it's working enough to merge?

It should be on par with the iOS code. I'll submit another PR to fix the automatic file inclusions once the next workload previews are shipped.

jonathanpeppers · 2021-07-01T13:42:36Z

An error came up when I setup the HelloMac project to build:

Main.storyboard : error : The file 'Main.storyboard' conflicts with 'Main.storyboard'. [/Users/runner/work/1/s/samples/HelloMac/HelloMac.csproj]
Main.storyboard : error :          [/Users/runner/work/1/s/samples/HelloMac/HelloMac.csproj]
    2 Warning(s)
    1 Error(s)

filipnavara · 2021-07-01T14:35:13Z

Thanks, I will check.

filipnavara · 2021-07-06T17:51:10Z

@jonathanpeppers I cannot see the AzDO pages and the build log. Can you post the failing part please? Local build seems to work just fine for me with the same command as in azure-pipelines.yml.

jonathanpeppers · 2021-07-06T19:39:46Z

The latest error is new:

/usr/local/share/dotnet/sdk/6.0.100-preview.5.21302.13/NuGet.targets(131,5): The local source '/Users/runner/work/1/s/bin/Debug/' doesn't exist. [/Users/runner/work/1/s/samples/HelloMac/HelloMac.csproj]

.binlog: HelloMac.zip

I'm not immediately seeing what is wrong...

filipnavara · 2021-07-06T20:00:50Z

It seems to be a mismatch between the Debug/Release of the projects being built. I cannot quite reproduce the same error but I have very similar one reproduced locally.

filipnavara · 2021-07-06T20:08:29Z

I'm kinda surprised that it doesn't error out on the other samples. Maybe it behaves differently when compiled through .sln.

jonathanpeppers · 2021-07-06T20:10:57Z

I added a step creating the directory.

These sources are static, doesn't make sense why samples.sln can build, but your new sample doesn't?

Xamarin.Legacy.Sdk/samples/nuget.config

Lines 5 to 6 in f78e04e

    
           <add key="debug"   value="../bin/Debug/" /> 
        
           <add key="release" value="../bin/Release/" />

jonathanpeppers · 2021-07-07T02:08:36Z

Ok, now we have a real error:

/usr/local/share/dotnet/sdk/6.0.100-preview.5.21302.13/Microsoft.Common.CurrentVersion.targets(2202,5): warning MSB3245: Could not resolve this reference. Could not locate the assembly "System.Drawing.Common.dll". Check to make sure the assembly exists on disk. If this reference is required by your code, you may get compilation errors. [/Users/runner/work/1/s/samples/HelloMac/HelloMac.csproj]
ILLINK : warning MM0079: The recommended Xcode version for Microsoft.macOS 11.3.100 is Xcode 12.5 or later. The current Xcode version (found in /Applications/Xcode_12.4.app/Contents/Developer) is 12.4. [/Users/runner/work/1/s/samples/HelloMac/HelloMac.csproj]
MMP : warning MM5220: Skipping framework 'QTKit'. It is prohibited (rejected) by the Mac App Store [/Users/runner/work/1/s/samples/HelloMac/HelloMac.csproj]
ILLink : unknown error IL6999: Failed to execute the custom steps. [/Users/runner/work/1/s/samples/HelloMac/HelloMac.csproj]
ILLINK : error MM2301: The linker step 'Setup' failed during processing: This version of Microsoft.macOS requires the macOS 11.3 SDK (shipped with Xcode 12.5). Either upgrade Xcode to get the required header files or use the dynamic registrar or set the managed linker behaviour to Link Platform or Link Framework SDKs Only in your project's Mac Build Options > Linker Behavior) (to try to avoid the new APIs). [/Users/runner/work/1/s/samples/HelloMac/HelloMac.csproj]
/usr/local/share/dotnet/sdk/6.0.100-preview.5.21302.13/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.ILLink.targets(77,5): error NETSDK1144: Optimizing assemblies for size failed. Optimization can be disabled by setting the PublishTrimmed property to false. [/Users/runner/work/1/s/samples/HelloMac/HelloMac.csproj]
    3 Warning(s)
    3 Error(s)

Let me check on what Xcode I can get -- or could we change the sample project to a class library? We wouldn't need the linker in that case?

filipnavara · 2021-07-07T06:37:00Z

Let me check on what Xcode I can get -- or could we change the sample project to a class library?

I tried to make it as close as possible to the actual usage which is why I chose to use an app as a sample. It also allows to verify easily if all the assets were embedded correctly because the app would not build or run. That said, I am fine with temporarily changing it to a class library if it can unblock the PR.

…into macOS Conflicts: azure-pipelines.yml src/Xamarin.Legacy.Sdk/Sdk/Sdk.props

jonathanpeppers · 2021-08-21T23:48:56Z

I was checking if we could do this now, you can get Big Sur (with Xcode 12.5) on Github Actions now:

https://github.blog/changelog/2021-08-16-github-actions-macos-11-big-sur-is-generally-available-on-github-hosted-runners/

Still not available on Azure DevOps:

https://docs.microsoft.com/en-us/azure/devops/pipelines/agents/hosted

Let's see if this is any closer now.

jonathanpeppers · 2021-08-22T16:22:31Z

Ugh, seems like we need Xcode 13 now...

ILLINK : error MM2301: The linker step 'Setup' failed during processing: This version of Microsoft.macOS requires the macOS 12.0 SDK (shipped with Xcode 13.0). Either upgrade Xcode to get the required header files or use the dynamic registrar or set the managed linker behaviour to Link Platform or Link Framework SDKs Only in your project's Mac Build Options > Linker Behavior) (to try to avoid the new APIs). [/Users/runner/work/Xamarin.Legacy.Sdk/Xamarin.Legacy.Sdk/samples/HelloMac/HelloMac.csproj]

filipnavara · 2021-08-23T10:46:39Z

The Xcode 13 beta should be in the image (https://github.com/actions/virtual-environments/blob/main/images/macos/macos-11-Readme.md) and there's a GH Action to install/switch it. I am out on vacation now but I can take a look when I return.

Context: https://github.com/actions/virtual-environments/blob/main/images/macos/macos-11-Readme.md

jonathanpeppers · 2021-08-23T13:57:07Z

This seems to be using Xcode 13 now, but we get:

 In file included from /Users/runner/work/Xamarin.Legacy.Sdk/Xamarin.Legacy.Sdk/samples/HelloMac/obj/Release/net6.0-macos/osx-x64/linker-cache/registrar.mm:2:
  /Users/runner/work/Xamarin.Legacy.Sdk/Xamarin.Legacy.Sdk/samples/HelloMac/obj/Release/net6.0-macos/osx-x64/linker-cache/registrar.h:1124:80: error: 'CMHeadphoneMotionManagerDelegate' is unavailable: not available on macOS
  @interface Xamarin_Mac__CoreMotion_CMHeadphoneMotionManagerDelegate : NSObject<CMHeadphoneMotionManagerDelegate> {
                                                                                 ^
  /Applications/Xcode_13.0.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.0.sdk/System/Library/Frameworks/CoreMotion.framework/Headers/CMHeadphoneMotionManagerDelegate.h:22:11: note: 'CMHeadphoneMotionManagerDelegate' has been explicitly marked unavailable here
  @protocol CMHeadphoneMotionManagerDelegate<NSObject>
            ^
  1 error generated.
  
/Users/runner/.dotnet/packs/Microsoft.macOS.Sdk/12.0.100-preview.7.230/targets/Xamarin.Shared.Sdk.targets(805,3): error : clang exited with code 1 [/Users/runner/work/Xamarin.Legacy.Sdk/Xamarin.Legacy.Sdk/samples/HelloMac/HelloMac.csproj]
/Users/runner/.dotnet/packs/Microsoft.macOS.Sdk/12.0.100-preview.7.230/targets/Xamarin.Shared.Sdk.targets(805,3): error :          [/Users/runner/work/Xamarin.Legacy.Sdk/Xamarin.Legacy.Sdk/samples/HelloMac/HelloMac.csproj]

Build FAILED.

/Users/runner/.dotnet/sdk/6.0.100-preview.7.21379.14/Microsoft.Common.CurrentVersion.targets(2205,5): warning MSB3245: Could not resolve this reference. Could not locate the assembly "System.Drawing.Common.dll". Check to make sure the assembly exists on disk. If this reference is required by your code, you may get compilation errors. [/Users/runner/work/Xamarin.Legacy.Sdk/Xamarin.Legacy.Sdk/samples/HelloMac/HelloMac.csproj]
MMP : warning MM5220: Skipping framework 'QTKit'. It is prohibited (rejected) by the Mac App Store [/Users/runner/work/Xamarin.Legacy.Sdk/Xamarin.Legacy.Sdk/samples/HelloMac/HelloMac.csproj]
/Users/runner/.dotnet/packs/Microsoft.macOS.Sdk/12.0.100-preview.7.230/targets/Xamarin.Shared.Sdk.targets(805,3): error : clang exited with code 1 [/Users/runner/work/Xamarin.Legacy.Sdk/Xamarin.Legacy.Sdk/samples/HelloMac/HelloMac.csproj]
/Users/runner/.dotnet/packs/Microsoft.macOS.Sdk/12.0.100-preview.7.230/targets/Xamarin.Shared.Sdk.targets(805,3): error :          [/Users/runner/work/Xamarin.Legacy.Sdk/Xamarin.Legacy.Sdk/samples/HelloMac/HelloMac.csproj]
    2 Warning(s)
    1 Error(s)

filipnavara · 2021-08-26T13:29:55Z

Xcode 13 beta 5 (as available on the GH Actions macOS image) removed CMHeadphoneMotionManagerDelegate from macOS where it was previously available. This was already updated on Xamarin side but the Preview 7 packages predate that.

jonathanpeppers · 2021-08-26T14:55:20Z

I'll probably come back to this when .NET 6 RC 1 ships, thanks.

@filipnavara do you need this in quicker than that? We could also just not build the Mac sample on CI yet and ship it?

filipnavara · 2021-08-26T14:57:02Z

No rush here. Let's revisit it once RC1 ships.

filipnavara · 2021-09-19T06:28:46Z

I wanted to re-run the GitHub Actions / Azure Pipelines but apparently I don't have enough rights to do so.

jonathanpeppers · 2021-09-20T13:58:24Z

I think the general CI also broke when RC1 shipped.

Let me update .NET 6 in this repo.

filipnavara · 2021-09-20T14:46:46Z

Thanks for the merge. Looks like the macOS image was updated with Xcode 13 RC already (which dropped macOS 12 SDK at last minute) :-(

filipnavara · 2021-09-20T14:49:18Z

Looks like there's some attempt to bring back Xcode 13 beta 5 back into the images. Not sure if it's deployed already.

filipnavara · 2021-09-21T02:42:46Z

Looks like a new macOS 11 image went live around ~8 hours ago. Hopefully the Xcode step should succeed now.

filipnavara · 2021-09-21T13:41:22Z

🎉

jonathanpeppers · 2021-10-12T15:02:49Z

@filipnavara we shipped this:

https://www.nuget.org/packages/Xamarin.Legacy.Sdk/0.1.1-alpha5

Sorry, I forgot to actually publish the release on this one.

filipnavara · 2021-10-12T15:20:02Z

Thanks!

Add macOS support

d32578e

Merge branch 'main' into pr/20

0f08373

Build HelloMac sample on CI

95af0ca

We probably shouldn't add this to `samples.sln`, because it would fail CI phases on Windows.

filipnavara marked this pull request as ready for review July 1, 2021 06:03

Fix the sample

94039eb

Update azure-pipelines.yml

afa8b9e

filipnavara force-pushed the macOS branch from cf5c3db to afa8b9e Compare July 7, 2021 22:50

Merge branch 'main' of https://github.com/xamarin/Xamarin.Legacy.Sdk …

6527e2f

…into macOS Conflicts: azure-pipelines.yml src/Xamarin.Legacy.Sdk/Sdk/Sdk.props

jonathanpeppers added 4 commits August 22, 2021 11:11

Updates for C# 10 and macOS

6506664

Build HelloMac on Github Actions

d1e844c

AutoImport.props should work by default now

9d7d878

Update actions.yml

b126b83

jonathanpeppers added 3 commits August 23, 2021 08:05

Switch to Xcode 13 beta

d37a287

Context: https://github.com/actions/virtual-environments/blob/main/images/macos/macos-11-Readme.md

Update actions.yml

3b1c83c

Update actions.yml

48014d6

Update actions.yml

5e3a6d9

Empty commit

5ed46a8

Merge branch 'main' into macOS

ef7ef84

Switch to Xcode 13 beta

2e5cc5b

jonathanpeppers approved these changes Sep 21, 2021

View reviewed changes

jonathanpeppers merged commit 7bc810c into xamarin:main Sep 21, 2021

Add macOS support #20

Add macOS support #20

Uh oh!

Conversation

filipnavara commented Jun 21, 2021

Uh oh!

jonathanpeppers commented Jun 21, 2021

Uh oh!

filipnavara commented Jun 21, 2021

Uh oh!

jonathanpeppers commented Jun 30, 2021

Uh oh!

azure-pipelines bot commented Jun 30, 2021

Uh oh!

jonathanpeppers commented Jul 1, 2021

Uh oh!

filipnavara commented Jul 1, 2021

Uh oh!

jonathanpeppers commented Jul 1, 2021

Uh oh!

filipnavara commented Jul 1, 2021

Uh oh!

filipnavara commented Jul 6, 2021

Uh oh!

jonathanpeppers commented Jul 6, 2021

Uh oh!

filipnavara commented Jul 6, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

filipnavara commented Jul 6, 2021

Uh oh!

jonathanpeppers commented Jul 6, 2021

Uh oh!

jonathanpeppers commented Jul 7, 2021

Uh oh!

filipnavara commented Jul 7, 2021

Uh oh!

jonathanpeppers commented Aug 21, 2021

Uh oh!

jonathanpeppers commented Aug 22, 2021

Uh oh!

filipnavara commented Aug 23, 2021

Uh oh!

jonathanpeppers commented Aug 23, 2021

Uh oh!

filipnavara commented Aug 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jonathanpeppers commented Aug 26, 2021

Uh oh!

filipnavara commented Aug 26, 2021

Uh oh!

filipnavara commented Sep 19, 2021

Uh oh!

jonathanpeppers commented Sep 20, 2021

Uh oh!

filipnavara commented Sep 20, 2021

Uh oh!

filipnavara commented Sep 20, 2021

Uh oh!

filipnavara commented Sep 21, 2021

Uh oh!

filipnavara commented Sep 21, 2021

Uh oh!

jonathanpeppers commented Oct 12, 2021

Uh oh!

filipnavara commented Oct 12, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

filipnavara commented Jul 6, 2021 •

edited

Loading

filipnavara commented Aug 26, 2021 •

edited

Loading