This repository has been archived by the owner on May 1, 2024. It is now read-only.
[Android] TalkBack now reads name and helptext on buttons. #9728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ryl No worries! Thanks!! |
samhouts
added
ControlGallery
p/Android
a/a11y 🔍
t/bug 🐛
i/high
samhouts
added
the
retarget-branch-required
PureWeen
added
the
blocker
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rmarinho
suggested changes
Dec 28, 2020
There was a problem hiding this comment.
Build is failing
D:\agent\1\s\Xamarin.Forms.ControlGallery.Android\ContentDescriptionEffectRenderer.cs(8,26): error CS0234: The type or namespace name 'View' does not exist in the namespace 'Android.Support.V4' (are you missing an assembly reference?) [D:\agent\1\s\Xamarin.Forms.ControlGallery.Android\Xamarin.Forms.ControlGallery.Android.csproj]
D:\agent\1\s\Xamarin.Forms.ControlGallery.Android\ContentDescriptionEffectRenderer.cs(9,26): error CS0234: The type or namespace name 'View' does not exist in the namespace 'Android.Support.V4' (are you missing an assembly reference?) [D:\agent\1\s\Xamarin.Forms.ControlGallery.Android\Xamarin.Forms.ControlGallery.Android.csproj]
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
PureWeen
added
the
DO-NOT-MERGE-!!! 🛑
2 tasks
PureWeen
suggested changes
Dec 28, 2020
There was a problem hiding this comment.
@ryl A couple things
- I think the code for this one that fixes AutomationId needs to be part of a different PR
- I created a different PR here [Android] TalkBack now reads name and helptext on buttons. #13244 that fixes the issue with AutomationProperties.Name, AutomationProperties.HelpText on Button not read by Android TalkBack #5150 . That should fix Button and Switch.
|
Seems like this has been fixed in other PRs. Thanks for all your time and effort here! We're doing big investments in .NET MAUI to make accessibility even better there! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Modified
AutomationPropertiesProvidersuch thatAutomationProperties.NameandAutomationProperties.HelpTextwill be read by TalkBack.Re-created from #5237
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
TalkBack will read
AutomationProperties.NameandAutomationProperties.HelpTexton a button if provided.Before/After Screenshots
Not applicable
Testing Procedure
In the Control Gallery, visit G5150. Labels containing the ContentDescription for each button should appear with appropriate text.
PR Checklist