RadioButton Implementation

[jfversluis]

Description of Change

Takeover from the RadioButton PR in #5349. I've copied the relevant parts here.

Issues Resolved

• fixes [F100] RadioButton #2404
• closes RadioButton #5349

API Changes

Added:

public class RadioButton
{
      public event EventHandler Checked;
      public event EventHandler Unchecked;

      public bool IsChecked {get; set; }  //BP
      public string GroupName { get; set; } //BP
      public ImageSource ButtonSource { get; set; } //BP
}

Platforms Affected

• Core/XAML (all platforms)
• iOS
• Android
• UWP
• MacOS

Behavioral/Visual Changes

GroupName property

The "RadioButton group Gallery - Legacy" has three tabs which show group behavior.
Radio-buttons with group name null are grouped by their parent.
Radio-buttons with same group name, no matter the hierarchy, are grouped at page level.

Video: https://www.youtube.com/watch?v=fwYSmvjCfbw

Before/After Screenshots

Testing Procedure

See the newly added gallery pages

PR Checklist

• Targets the correct branch
• Tests are passing (or failures are unrelated)

TODO

• Make Mac OS work with the groups, you can now check all radiobuttons, group seems to be ignored completely

• on iOS you can uncheck a radiobutton by tapping it a second time, this should not happen

[jfversluis]

Need to have a look at the review comments in the original PR

[rmarinho]

• What does ButtonSource do? can we add the image to UWP and iOS so we can test it with VSM in all platforms?

• Padding seems to be applied only on text, not the all control viewport.

• Can we add a UITests for iOS and Android

• On UWP when i hover the border goes away.

• Is there a way to change the color of the Radio (Circle) on UWP ?! seems we can only change the TextColor, but on iOS seems TextColor changes color of text and circle

[rmarinho]

If we have a new Control why we are checking for LegacyColorManagement?

[rmarinho]

This should be CornerRadius no ? but it also doesn't work for me if i change to something like:

	var borderRadiusContainer = new ViewContainer<RadioButton>(Test.Button.BorderRadius,
				new RadioButton
				{
					Text = "BorderRadius",
					BackgroundColor = Color.Transparent,
					BorderColor = Color.Red,
					BorderWidth = 1,
					CornerRadius = 5
				}
			);

[rookiejava]

why don't you implements IFontElement, ITextElement, IBorderElement instead of inheriting Button directly.