This repository has been archived by the owner on May 1, 2024. It is now read-only.
[iOS] Implement CollectionView ScrollTo with groups #7220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfversluis
approved these changes
Aug 27, 2019
rmarinho
reviewed
Aug 27, 2019
| @@ -13,6 +13,8 @@ public class GroupableItemsViewController : SelectableItemsViewController | |||
| // BindableProperty all the time | |||
| bool _isGrouped; | |||
|
|
|||
| private Action _scrollAnimationEndedCallback; | |||
rmarinho
approved these changes
Aug 27, 2019
samhouts
added
the
approved
felipebaltazar
pushed a commit
to felipebaltazar/Xamarin.Forms
that referenced
this pull request
Oct 16, 2019
* ScrollTo with groupIndex on iOS * Add test for scrolling to group/item (objects rather than indexes) * Fix automation IDs for new fields * Add missing issue info to test page * Fix UI tests * Workaround for problems scrolling to group index/item index on first try * Make the test page legible on Android * Remove private modifiers
felipebaltazar
pushed a commit
to felipebaltazar/Xamarin.Forms
that referenced
this pull request
Oct 16, 2019
* ScrollTo with groupIndex on iOS * Add test for scrolling to group/item (objects rather than indexes) * Fix automation IDs for new fields * Add missing issue info to test page * Fix UI tests * Workaround for problems scrolling to group index/item index on first try * Make the test page legible on Android * Remove private modifiers
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Calls to
ScrollTo()which specify groups and group indexes now work.Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Not applicable
Testing Procedure
Automated tests
PR Checklist