This repository has been archived by the owner on May 1, 2024. It is now read-only.
Use XF Size instead of Android.Util.Size #7033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samhouts
added
i/high
rmarinho
approved these changes
Aug 1, 2019
StephaneDelcroix
approved these changes
Aug 1, 2019
jfversluis
approved these changes
Aug 1, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Replaces use of Android.Util.Size (not available until API 21) with Xamarin.Forms.Size to avoid missing class definition crashes on API < 21.
Also fixes transposed parameters when using ItemSizingStrategy.MeasureFirstItem.
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Not applicable
Testing Procedure
Launch Control Gallery on API 19, navigate to
CollectionView Gallery -> Item Sizing Gallery -> Item Sizing Strategies. Should no longer crash.
PR Checklist