Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Update README.md #4290

Merged
merged 3 commits into from
Nov 12, 2018
Merged

Update README.md #4290

merged 3 commits into from
Nov 12, 2018

Conversation

danielchalmers
Copy link
Contributor

Description of Change

a few tiny changes to the README :)

  • XML tab size 4 -> 2
  • to your nuget -> to your NuGet
  • Nuget.exe -> nuget.exe
  • OSX -> macOS
  • update UWPMapsAuthKey link
  • fix inconsistent markdown headers
  • clean up whitespace and newlines

Issues Resolved

API Changes

None

Platforms Affected

Behavioral/Visual Changes

None

Before/After Screenshots

Not applicable

Testing Procedure

PR Checklist

  • Has automated tests
  • Rebased on top of the target branch at time of PR
  • Changes adhere to coding standard


Make sure you have nuget.exe 4.0 or above and the latest dotnet core sdk (2.0.3). On macOS you should specify the platform in the msbuild command (`/p:Platform=iPhoneSimulator`)

nuget restore Xamarin.Forms.sln
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be in {code}

@PureWeen PureWeen added the t/housekeeping ♻︎ Internal only changes, won't be included in release notes label Nov 5, 2018
Copy link
Contributor

@davidortinau davidortinau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple comments for discussion before we merge.

README.md Outdated Show resolved Hide resolved
README.md Outdated

![Visual Studio Team Services ](https://img.shields.io/vso/build/devdiv/0bdbc590-a062-4c3f-b0f6-9383f67865ee/7981.svg?style=flat&label=VSTS%20Master "VSTS")

![Visual Studio Team Services](https://img.shields.io/vso/build/devdiv/0bdbc590-a062-4c3f-b0f6-9383f67865ee/7981.svg?style=flat&label=VSTS%20Master "VSTS")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably should replace this with Azure DevOps. @rmarinho would this work or does the label on the SVG need to change on the build system as well?

Suggested change
![Visual Studio Team Services](https://img.shields.io/vso/build/devdiv/0bdbc590-a062-4c3f-b0f6-9383f67865ee/7981.svg?style=flat&label=VSTS%20Master "VSTS")
![Azure DevOps](https://img.shields.io/vso/build/devdiv/0bdbc590-a062-4c3f-b0f6-9383f67865ee/7981.svg?style=flat&label=Azure%DevOps%20Master "Azure DevOps")

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the url is wrong o the label part.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README.md Outdated Show resolved Hide resolved
Co-Authored-By: danielchalmers <daniel.chalmers@outlook.com>
@rmarinho rmarinho merged commit ee3353e into xamarin:master Nov 12, 2018
@samhouts samhouts added this to the 4.0.0 milestone Dec 4, 2018
@samhouts samhouts modified the milestones: 4.0.0, 3.5.0 Jan 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
t/housekeeping ♻︎ Internal only changes, won't be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants