Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[build] Version and strongname the Build.Tasks #3118

Merged
merged 1 commit into from
Jun 28, 2018
Merged

[build] Version and strongname the Build.Tasks #3118

merged 1 commit into from
Jun 28, 2018

Conversation

StephaneDelcroix
Copy link
Member

Description of Change

[build] Version and strongname the Build.Tasks

Issues Resolved

@StephaneDelcroix StephaneDelcroix added the retarget-branch-required PR or associated issues target a milestone. Please target this PR to the matching branch. label Jun 22, 2018
@StephaneDelcroix StephaneDelcroix force-pushed the strongname branch 3 times, most recently from 7553d3e to 8010f87 Compare June 22, 2018 11:11
@StephaneDelcroix StephaneDelcroix force-pushed the strongname branch 2 times, most recently from 8d2ebb0 to 8b7f407 Compare June 23, 2018 05:39
@xamarin-release-manager xamarin-release-manager added the API-change Heads-up to reviewers that this PR may contain an API change label Jun 26, 2018
@xamarin-release-manager xamarin-release-manager added the API-change Heads-up to reviewers that this PR may contain an API change label Jun 27, 2018
@StephaneDelcroix StephaneDelcroix force-pushed the strongname branch 2 times, most recently from e423695 to 14b246f Compare June 27, 2018 11:41
@StephaneDelcroix StephaneDelcroix changed the base branch from 3.1.0 to 3.2.0 June 27, 2018 11:47
@StephaneDelcroix StephaneDelcroix added a/Xaml </> and removed API-change Heads-up to reviewers that this PR may contain an API change retarget-branch-required PR or associated issues target a milestone. Please target this PR to the matching branch. labels Jun 27, 2018
@xamarin-release-manager xamarin-release-manager added the API-change Heads-up to reviewers that this PR may contain an API change label Jun 27, 2018
@rmarinho rmarinho requested review from jassmith and rmarinho June 27, 2018 17:16
Copy link
Member

@rmarinho rmarinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's failing to build on Release https://devdiv.visualstudio.com/DevDiv/_build/index?buildId=1813314

But i tried locally build specific projects and works good the apps also work on Release and the dlls get signed with the tool in release

@StephaneDelcroix StephaneDelcroix removed the API-change Heads-up to reviewers that this PR may contain an API change label Jun 28, 2018
@xamarin-release-manager xamarin-release-manager added the API-change Heads-up to reviewers that this PR may contain an API change label Jun 28, 2018
@rmarinho rmarinho added this to the 3.2.0 milestone Jun 28, 2018
@rmarinho rmarinho merged commit c79c77d into 3.2.0 Jun 28, 2018
@samhouts samhouts mentioned this pull request Aug 1, 2018
3 tasks
@samhouts samhouts modified the milestone: 3.2.0 Sep 12, 2018
@StephaneDelcroix StephaneDelcroix deleted the strongname branch December 19, 2018 14:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a/Xaml </> API-change Heads-up to reviewers that this PR may contain an API change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants