-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Conversation
# Conflicts: # Xamarin.Forms.Platform.iOS/Renderers/EntryRenderer.cs
@jfversluis Re-open this, please. Explanations: #14566 (comment) |
Reopening this to make sure we have another look |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
I am getting new exception on iOS 12.4 after updating to SR6: It happens on EntryRenderer Dispose call at this line: |
@rotorgames @jfversluis I'm also seeing the same crash that @VitalyKnyazev reports above in my app after updating to SR6. AddObserver is documented as returning "An IDisposable object. Invoke the Dispose method on this object to remove the observer." so maybe we need to store the return value from AddObserver and dispose it instead of calling RemoveObserver? EDIT: This was on an iPhone 6 running iOS 12.5.5, seems sensitive to the version of iOS being used much like the original issue was. |
@VitalyKnyazev @lee-m would you mind opening a new issue for this and if possible attach a small reproduction sample to show the issue? That would be very helpful. If you can do that I will see to prioritize this for the next release |
@jfversluis @VitalyKnyazev I've opened #14804 for this. I've left the repro steps blank for now whilst I try and distill down a small example that demonstrates the problem but it might be a bit tricky. |
I'm getting this crash too. protected override void Dispose(bool disposing)
{
try
{
base.Dispose(disposing);
}
catch (Exception)
{
// TODO remove this hack on newer version of Xamarin.Forms: https://github.com/xamarin/Xamarin.Forms/pull/14526
}
} |
* Revert "Fix hangs and NREs with Entry Observer (#14859)" This reverts commit 5188c4f. * Revert "Refactor observer lifecycle (#14828)" This reverts commit f95f671. * Revert "Fix crashing on iOS < 14 if ClearButtonVisibility = WhileEditing in Entry (#14479 #14510) (#14526)" This reverts commit a21b36a.
Description of Change
Fixing crashes on iOS < 14 if ClearButtonVisibility of Entry is WhileEditing
Issues Resolved
Fixes:
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Not applicable
Testing Procedure
PR Checklist