Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Enhancement] [WPF] ActivityIndicatorRenderer to use circular animation #9372

Closed
peterfoot opened this issue Jan 30, 2020 · 0 comments · Fixed by #9389
Closed

[Enhancement] [WPF] ActivityIndicatorRenderer to use circular animation #9372

peterfoot opened this issue Jan 30, 2020 · 0 comments · Fixed by #9389
Labels
a/activityindicator in-progress This issue has an associated pull request that may resolve it! p/WPF proposal-open t/enhancement ➕

Comments

@peterfoot
Copy link
Contributor

Summary

Currently the WPF implementation of ActivityIndicator uses an indeterminate ProgressBar which doesn't really make sense in most scenarios. Windows 8 and above have used a circular spinning dots animation for this purpose although it doesn't exist as a Win32 or WPF control. I have implemented a custom renderer (https://github.com/inthehand/InTheHand.Forms/blob/master/InTheHand.Forms/InTheHand.Forms.Platform.WPF/ActivityIndicatorRenderer.cs) to achieve this consistent look using a very simple WPF UserControl which is modelled on the WinRT/UWP control. I'm proposing a Pull Request to replace the current renderer with this one which provides a better UI.

API Changes

No API changes are required to the control. The renderer fully supports the IsRunning and Color properties of the ActivityIndicator control. This change will affect the appearance on the WPF platform only.

Intended Use Case

The control is intended for showing indeterminate activity and on other platforms uses some variant of a circular spinning device. If you have designed a Xamarin Forms UI with the control a stretched ProgressBar will look out of place (and there is already a separate control for that).

@samhouts samhouts added the in-progress This issue has an associated pull request that may resolve it! label Feb 1, 2020
rmarinho pushed a commit that referenced this issue Feb 4, 2020
* Replaced ActivityIndicator for WPF to use a Windows style progress ring (animated dots).

* Removed private keyword

* Changed foreground color assignment so that Color.Default sets value to Color.Accent to avoid creating a transparent control.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a/activityindicator in-progress This issue has an associated pull request that may resolve it! p/WPF proposal-open t/enhancement ➕
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants