Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Exception occurs when giving null values in picker itemsource collection #2674

Closed
suriyakalidoss opened this issue May 11, 2018 · 2 comments · Fixed by #9478
Closed

Exception occurs when giving null values in picker itemsource collection #2674

suriyakalidoss opened this issue May 11, 2018 · 2 comments · Fixed by #9478
Assignees
@sahi82
Labels
e/2 🕑 2 hackathon help wanted We welcome community contributions to any issue, but these might be a good place to start! i/high Completely doesn't work, crashes, or is unusably slow, has no obvious workaround; occurs less often in-progress This issue has an associated pull request that may resolve it! t/bug 🐛 up-for-grabs We welcome community contributions to any issue, but these might be a good place to start!

Comments

@suriyakalidoss
Copy link

Description

Steps to Reproduce

1.Assign null value to one of the items in collection
2.Bind the collection as the itemsource to the picker
3.programs crashed when clicking the picker

Expected Behavior

When assigning null value to one of the item in the collection ,picker should not crash while clicking.

Actual Behavior

When assigning null value to one of the items in the collection, empty string should added while drop down the picker.

Basic Information

  • Version with issue:.Xamarin Forms 2.4.0.280
  • Last known good version:
  • IDE:
  • Platform Target Frameworks:
    • iOS: 11.0
    • Android: API 22
    • UWP: 10.0.14393.0

Screenshots

Please refer the below link for images
Image: http://www.syncfusion.com/downloads/support/directtrac/general/ze/BUGZILLA497018189

Reproduction Link

Sample link : http://www.syncfusion.com/downloads/support/directtrac/general/ze/Sample1031557222
@StephaneDelcroix StephaneDelcroix added has-stacktrace Bugs without reproductions but that contain a stack trace. t/bug 🐛 and removed has-stacktrace Bugs without reproductions but that contain a stack trace. labels May 11, 2018
@samhouts samhouts mentioned this issue Jul 30, 2018
Closed
4 tasks
@samhouts samhouts added the e/2 🕑 2 label Oct 16, 2018
@samhouts samhouts added the inactive Issue is older than 6 months and needs to be retested label Dec 20, 2018
@samhouts samhouts added the i/high Completely doesn't work, crashes, or is unusably slow, has no obvious workaround; occurs less often label May 29, 2019
@samhouts samhouts added help-wanted up-for-grabs We welcome community contributions to any issue, but these might be a good place to start! help wanted We welcome community contributions to any issue, but these might be a good place to start! and removed help-wanted labels Jun 28, 2019
@hartez
Copy link
Contributor

hartez commented Feb 5, 2020

_2674 Repro.zip

Looks like the Picker is missing a null check in GetDisplayMember before calling item.ToString().

@samhouts samhouts removed the inactive Issue is older than 6 months and needs to be retested label Feb 6, 2020
@sahi82
Copy link
Contributor

sahi82 commented Feb 7, 2020

Picking this issue

@hartez hartez added the in-progress This issue has an associated pull request that may resolve it! label Feb 7, 2020
@sahi82 sahi82 mentioned this issue Feb 7, 2020
Merged
2 tasks
rmarinho pushed a commit that referenced this issue Feb 10, 2020
@sahi82
Adding null check for picker items (#9478) fixes #2674
bbb07f6
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sahi82 sahi82

Labels
e/2 🕑 2 hackathon help wanted We welcome community contributions to any issue, but these might be a good place to start! i/high Completely doesn't work, crashes, or is unusably slow, has no obvious workaround; occurs less often in-progress This issue has an associated pull request that may resolve it! t/bug 🐛 up-for-grabs We welcome community contributions to any issue, but these might be a good place to start!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding null check for picker items sahi82/Xamarin.Forms
5 participants
@StephaneDelcroix @hartez @sahi82 @samhouts @suriyakalidoss