[Bug] Word wrapped Label *STILL* not measured correctly

[JohnHDev]

Original bug that was 'fixed' after 8 months and we broke in 10 minutes: #8797

Original bug is being ignored as people go off and work on the new and shiny. But sure, I'll raise a new bug for this. I clearly have more free time than those working for MS, so why not.

Description

A Label in a grid that is contained in a StackLayout isn't measured correctly, with contents below the grid in the StackLayout overlapping the grid and label.

Steps to Reproduce

Create a new template XF solution.
Replace the MainPage xml with a new MainPage.cs
Install Xamarin Community Toolkit Markup nuget
Replace the code with the following and fix the namespace accordingly:

public class MainPage: ContentPage
{
    public MainPage()
    {
        BackgroundColor = Color.Gray;

        Content = new StackLayout()
        {
            Padding = new Thickness(10, 40, 10, 10),
            Children =
            {
                new Grid()
                {
                    ColumnSpacing = 8,
                    ColumnDefinitions =
                    {
                        new ColumnDefinition() { Width = GridLength.Auto },
                        new ColumnDefinition() { Width = GridLength.Star },
                    },

                    Children =
                    {
                        new Grid()
                        {
                            RowSpacing = 0,
                            Children =
                            {
                                new Label()
                                {
                                    Text = "ABC123"
                                }
                            }
                        }.Row(0).Column(0),
                        new Frame()
                        {
                            Margin = 0,
                            Padding = 0,
                            CornerRadius = 8,
                            HasShadow = false,
                            HorizontalOptions = LayoutOptions.FillAndExpand,
                            Content = new Grid()
                            {
                                ColumnSpacing = 0,
                                VerticalOptions = LayoutOptions.CenterAndExpand,
                                ColumnDefinitions =
                                {
                                    new ColumnDefinition() { Width = GridLength.Auto },
                                    new ColumnDefinition() { Width = GridLength.Star },
                                },
                                RowDefinitions =
                                {
                                    new RowDefinition() { Height = GridLength.Auto }
                                },
                                Children =
                                {
                                    new Label()
                                    {
                                        Margin = new Thickness(6, 3, 6, 3),
                                        VerticalOptions = LayoutOptions.CenterAndExpand,
                                        Text = "dfg fg df dfg dfg dfg f dfg dfg dfg dff gdf gdf gd fg dfg df gdf g df gd gdf gf dg ffd gdf gdf g df gdf gd fg df gdg df dfg a"
                                    }.Row(0).Column(1)
                                }
                            }
                        }.Row(0).Column(1)
                    }
        }
            }
        };
    }
}

Run it.

Expected Behavior

Label should display correctly, with all the text visible.

Actual Behavior

Label is wrapping out of the grid.

Basic Information

• Version with issue: XF 5.0.0
• Last known good version: Has there ever been a 'good' Xamarin Forms version?
• Platform Target Frameworks:
  • iOS: 14.4

Workaround

Migrate all projects to Flutter

[jsuarezruiz]

Attach a reproduction sample:

Issue136832.zip

Was fixed by #11336 but seems to fail with the latest changes in GridCalc.cs.

cc @hartez

[hartez]

@JohnHDev There's certainly seems to be a bug here; we're taking a look at it.

If you're looking for a workaround in the meantime, I notice that your innermost Grid has an extra column declaration which doesn't do anything. If you remove the extra Star column from your layout (and put the Label in column 0), the problem goes away:

Content = new StackLayout()
{
	Padding = new Thickness(10, 40, 10, 10),
	Children =
{
	new Grid()
	{
		ColumnSpacing = 8,
		ColumnDefinitions =
		{
			new ColumnDefinition() { Width = GridLength.Auto },
			new ColumnDefinition() { Width = GridLength.Star },
		},

		Children =
		{
			new Grid()
			{
				RowSpacing = 0,
				Children =
				{
					new Label()
					{
						Text = "ABC123"
					}
				}
			}.Row(0).Column(0),
			new Frame()
			{
				Margin = 0,
				Padding = 0,
				CornerRadius = 8,
				HasShadow = false,
				HorizontalOptions = LayoutOptions.FillAndExpand,
				Content = new Grid()
				{
					ColumnSpacing = 0,
					VerticalOptions = LayoutOptions.CenterAndExpand,
					ColumnDefinitions =
					{
						new ColumnDefinition() { Width = GridLength.Auto },
						//new ColumnDefinition() { Width = GridLength.Star },
					},
					RowDefinitions =
					{
						new RowDefinition() { Height = GridLength.Auto }
					},
					Children =
					{
						new Label()
						{
							Margin = new Thickness(6, 3, 6, 3),
							VerticalOptions = LayoutOptions.CenterAndExpand,
							Text = "dfg fg df dfg dfg dfg f dfg dfg dfg dff gdf gdf gd fg dfg df gdf g df gd gdf gf dg ffd gdf gdf g df gdf gd fg df gdg df dfg a"
						}.Row(0)//.Column(1)
					}
				}
			}.Row(0).Column(1)
		}
}
}
};

All I did was comment out the extra column and the method which sets the Label's column. Tested on an iPhone 5s.

[JohnHDev]

@hartez thank you for taking a look, the above is just an example, cut down from a much larger version we had in production where the first column was populated as well, but the IsVisible of that is bound to a property. The same problem occurs of course when IsVisible on the view in the first column is is bound to a property with a value of false.

[JohnHDev]

@hartez when do you think this might get picked up?
I appreciate the thumbs up, but I needed to highlight that this bug does not have a suitable workaround other than manually building the UI with if statements and not using binding at all (or a hybrid of the 2). That is far from ideal and is not a great selling point that at version 5 of Xamarin Forms, Xamarin STILL can't get this right.

[JohnHDev]

@hartez feel free to ignore this, we are dropping Xamarin Forms and moving to better supported technologies.

[jeremy-bridges]

We are committed to Xamarin.Forms and would like a fix. Please keep this issue in your plans.

[mcerqueira1509]

The workaround is not pretty and the struggle is real.