GTK: Call Pixbuf ctor on MainThread for LoadImageAsync functions (#15503

)

This fix avoids threading problems caused by calling Pixbuf ctor from outside of the MainThread.

Xamarin.Forms.Platform.GTK/Renderers/ImageRenderer.cs

@@ -171,7 +171,7 @@ Task<Pixbuf> LoadImageAsync(ImageSource imagesource, CancellationToken cancelati
 
 	public sealed class FileImageSourceHandler : IImageSourceHandler
 	{
-		public Task<Pixbuf> LoadImageAsync(
+		public async Task<Pixbuf> LoadImageAsync(
 			ImageSource imagesource,
 			CancellationToken cancelationToken = default(CancellationToken),
 			float scale = 1f)
@@ -188,12 +188,15 @@ public Task<Pixbuf> LoadImageAsync(
 
 					if (File.Exists(imagePath))
 					{
-						image = new Pixbuf(imagePath);
+						await Device.InvokeOnMainThreadAsync(() =>
+						{
+							image = new Pixbuf(imagePath);
+						});
 					}
 				}
 			}
 
-			return Task.FromResult(image);
+			return image;
 		}
 	}
 
@@ -210,7 +213,12 @@ public sealed class StreamImagesourceHandler : IImageSourceHandler
 				.GetStreamAsync(cancelationToken).ConfigureAwait(false))
 			{
 				if (streamImage != null)
-					image = new Pixbuf(streamImage);
+				{	
+					await Device.InvokeOnMainThreadAsync(() =>
+					{
+						image = new Pixbuf(streamImage);
+					});
+				}
 			}
 
 			return image;
@@ -238,7 +246,10 @@ public async Task<Pixbuf> LoadImageAsync(
 					return null;
 				}
 
-				image = new Pixbuf(streamImage);
+				await Device.InvokeOnMainThreadAsync(() =>
+				{
+					image = new Pixbuf(streamImage);
+				});
 			}
 
 			return image;
@@ -248,13 +259,13 @@ public async Task<Pixbuf> LoadImageAsync(
 
 	public sealed class FontImageSourceHandler : IImageSourceHandler
 	{
-		public Task<Pixbuf> LoadImageAsync(ImageSource imageSource,
+		public async Task<Pixbuf> LoadImageAsync(ImageSource imageSource,
 			CancellationToken cancellationToken = new CancellationToken(), float scale = 1)
 		{
 			if (!(imageSource is FontImageSource fontImageSource))
 				return null;
 
-			Pixbuf pixbuf;
+			Pixbuf pixbuf = null;
 			using (var bmp = new Bitmap((int)fontImageSource.Size, (int)fontImageSource.Size))
 			{
 				using (var g = Graphics.FromImage(bmp))
@@ -270,11 +281,15 @@ public Task<Pixbuf> LoadImageAsync(ImageSource imageSource,
 				using (var stream = new MemoryStream())
 				{
 					bmp.Save(stream, ImageFormat.Jpeg);
-					pixbuf = new Pixbuf(stream.ToArray());
+					await Device.InvokeOnMainThreadAsync(() =>
+					{
+						pixbuf = new Pixbuf(stream.ToArray());
+					});
+
 				}
 			}
 
-			return Task.FromResult(pixbuf);
+			return pixbuf;
 		}
 
 		static FontFamily GetFontFamily(FontImageSource fontImageSource)