Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Commit

Permalink
- fix nav drawer
Browse files Browse the repository at this point in the history
  • Loading branch information
PureWeen committed Jun 8, 2021
1 parent bfb4d86 commit 42f0595
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 5 deletions.
4 changes: 2 additions & 2 deletions Xamarin.Forms.Platform.Android/Flags.cs
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ internal static class Flags
{
internal const string UseLegacyRenderers = "UseLegacyRenderers";

internal const string AccessibilityExperimental = "AccessibilityExperimental";
internal const string AccessibilityExperimental = "Accessibility_Experimental";

public static bool IsFlagSet(string flagName)
{
Expand All @@ -15,7 +15,7 @@ public static bool IsFlagSet(string flagName)

public static bool IsAccessibilityExperimentalSet()
{
return IsFlagSet(nameof(AccessibilityExperimental));
return IsFlagSet(AccessibilityExperimental);
}
}
}
15 changes: 12 additions & 3 deletions Xamarin.Forms.Platform.Android/Renderers/ShellToolbarTracker.cs
Original file line number Diff line number Diff line change
Expand Up @@ -333,7 +333,11 @@ protected virtual async void UpdateLeftBarButtonItem(Context context, Toolbar to
{
if (_drawerToggle == null && !context.IsDesignerContext())
{
_drawerToggle = new ActionBarDrawerToggle(context.GetActivity(), drawerLayout, toolbar, R.String.Ok, R.String.Ok)
var openId = R.String.Ok;
if (Flags.IsAccessibilityExperimentalSet())
openId = Resource.String.nav_app_bar_open_drawer_description;

_drawerToggle = new ActionBarDrawerToggle(context.GetActivity(), drawerLayout, toolbar, openId, R.String.Ok)
{
ToolbarNavigationClickListener = this,
};
Expand Down Expand Up @@ -451,8 +455,13 @@ protected virtual void UpdateToolbarIconAccessibilityText(Toolbar toolbar, Shell
else if (image == null ||
toolbar.SetNavigationContentDescription(image) == null)
{
if(CanNavigateBack && Flags.IsAccessibilityExperimentalSet())
toolbar.SetNavigationContentDescription(Resource.String.nav_app_bar_navigate_up_description);
if (Flags.IsAccessibilityExperimentalSet())
{
if(CanNavigateBack)
toolbar.SetNavigationContentDescription(Resource.String.nav_app_bar_navigate_up_description);
else
toolbar.SetNavigationContentDescription(Resource.String.nav_app_bar_open_drawer_description);
}
else
toolbar.SetNavigationContentDescription(R.String.Ok);
}
Expand Down

0 comments on commit 42f0595

Please sign in to comment.