This repository has been archived by the owner on Nov 6, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 147
Manual updates 20240725 fix for issue 754 #896
Merged
moljac
merged 7 commits into
main
from
mu-20240725-fix-issue-754-tensorflow-missing-build
Jul 29, 2024
Merged
Manual updates 20240725 fix for issue 754 #896
moljac
merged 7 commits into
main
from
mu-20240725-fix-issue-754-tensorflow-missing-build
Jul 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonpryor
reviewed
Jul 29, 2024
...sorflow-lite-support-api/Additions/Xamarin.TensorFlow.Lite.Support.Common.TensorProcessor.cs
Outdated
Show resolved
Hide resolved
jonpryor
reviewed
Jul 29, 2024
...sorflow-lite-support-api/Additions/Xamarin.TensorFlow.Lite.Support.Common.TensorProcessor.cs
Outdated
Show resolved
Hide resolved
jonpryor
reviewed
Jul 29, 2024
path="/api/package[@name='org.tensorflow.lite.support.common']/class[@name='TensorProcessor.Builder']/method[@name='build' and count(parameter)=0 and @return='org.tensorflow.lite.support.common.TensorProcessor']" | ||
name="managedName" | ||
> | ||
BuildTensorProcessor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why doesn't setting managedName
work? What error are you trying to work around by manually defining BuildTensorProcessor()
?
<class abstract="false" deprecated="not deprecated" extends="org.tensorflow.lite.support.common.SequentialProcessor.Builder" extends-generic-aware="org.tensorflow.lite.support.common.SequentialProcessor.Builder<org.tensorflow.lite.support.image.TensorImage>" jni-extends="Lorg/tensorflow/lite/support/common/SequentialProcessor$Builder;" final="false" name="ImageProcessor.Builder" static="true" visibility="public" jni-signature="Lorg/tensorflow/lite/support/image/ImageProcessor$Builder;">
<constructor deprecated="not deprecated" final="false" name="ImageProcessor.Builder" jni-signature="()V" bridge="false" static="false" type="org.tensorflow.lite.support.image.ImageProcessor.Builder" synthetic="false" visibility="public" />
<method abstract="false" deprecated="not deprecated" final="false" name="add" jni-signature="(Lorg/tensorflow/lite/support/common/Operator;)Lorg/tensorflow/lite/support/common/SequentialProcessor$Builder;" bridge="true" native="false" return="java.lang.Object" jni-return="Lorg/tensorflow/lite/support/common/SequentialProcessor$Builder;" static="false" synchronized="false" synthetic="true" visibility="public">
<parameter name="op" type="org.tensorflow.lite.support.common.Operator" jni-type="Lorg/tensorflow/lite/support/common/Operator;" />
</method>
<method abstract="false" deprecated="not deprecated" final="false" name="add" jni-signature="(Lorg/tensorflow/lite/support/common/TensorOperator;)Lorg/tensorflow/lite/support/image/ImageProcessor$Builder;" bridge="false" native="false" return="org.tensorflow.lite.support.image.ImageProcessor.Builder" jni-return="Lorg/tensorflow/lite/support/image/ImageProcessor$Builder;" static="false" synchronized="false" synthetic="false" visibility="public">
<parameter name="op" type="org.tensorflow.lite.support.common.TensorOperator" jni-type="Lorg/tensorflow/lite/support/common/TensorOperator;" />
</method>
<method abstract="false" deprecated="not deprecated" final="false" name="add" jni-signature="(Lorg/tensorflow/lite/support/image/ImageOperator;)Lorg/tensorflow/lite/support/image/ImageProcessor$Builder;" bridge="false" native="false" return="org.tensorflow.lite.support.image.ImageProcessor.Builder" jni-return="Lorg/tensorflow/lite/support/image/ImageProcessor$Builder;" static="false" synchronized="false" synthetic="false" visibility="public">
<parameter name="op" type="org.tensorflow.lite.support.image.ImageOperator" jni-type="Lorg/tensorflow/lite/support/image/ImageOperator;" />
</method>
<method abstract="false" deprecated="not deprecated" final="false" name="build" jni-signature="()Lorg/tensorflow/lite/support/image/ImageProcessor;" bridge="false" native="false" return="org.tensorflow.lite.support.image.ImageProcessor" jni-return="Lorg/tensorflow/lite/support/image/ImageProcessor;" static="false" synchronized="false" synthetic="false" visibility="public" />
<method abstract="false" deprecated="not deprecated" final="false" name="build" jni-signature="()Lorg/tensorflow/lite/support/common/SequentialProcessor;" bridge="true" native="false" return="org.tensorflow.lite.support.common.SequentialProcessor" jni-return="Lorg/tensorflow/lite/support/common/SequentialProcessor;" static="false" synchronized="false" synthetic="true" visibility="public" />
</class> |
jpobst
approved these changes
Jul 29, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this change any of the generated binding API's?
Yes. Methods surfaced and renamed
Describe your contribution
Fixes for issue #754
Error:
Error is caused by multiple (2) versions of one method (
Build()
) that returns different covariant types. Renaming the method does not work, because variable names for Delegates and other are generated based on java method names, not managed, so the managed method name gets changed, but variables cause conflicts.So, as workaround,
managedName
suffix)Maybe variable name generation based on
managedName
could prevent this in the future.Check: issue java.interop