This repository has been archived by the owner on May 15, 2024. It is now read-only.
Put in check for iOS 12 to use new openurlasync method #823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Docs Build status updates of commit 13b2656: ✅ Validation status: passed
For more details, please refer to the build report. Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report. |
|
Basically test will be to run the code on an ios 12 simulator and also an ios 11 with External for browser and that should work. |
newky2k
added
ready-to-merge
newky2k
approved these changes
Jun 26, 2019
Mrnikbobjeff
pushed a commit
to Mrnikbobjeff/Essentials
that referenced
this pull request
Aug 28, 2019
nickrandolph
pushed a commit
to builttoroam/Essentials
that referenced
this pull request
Dec 4, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
We were using too new of an API for openurl so <12 woudl have issues
Bugs Fixed
Provide links to issues here. Ensure that a GitHub issue was created for your feature or bug fix before sending PR.
API Changes
Behavioral Changes
When using external it should be fine now on devices < 12
PR Checklist